elements/src/wallet
MarcoFalke ac92ab6da5
Merge bitcoin/bitcoin#23113: Add warnings to createmultisig and addmultisig if using uncompressed keys
d5cab1a96d Add createmultisig and addmultisigaddress warnings release note (Samuel Dobson)
e46fc935aa Add warnings field to addmultisigaddress to warn about uncompressed keys (Samuel Dobson)
d1a9742623 Add warnings field to createmultisig to warn about uncompressed keys (Samuel Dobson)

Pull request description:

  Fixes #21368

  Currently, if there are any uncompressed keys when calling `AddAndGetMultisigDestination`, it will just default to a legacy address regardless of the chosen `address_type`. Rather than keeping this silent behaviour which may be confusing to users, we explicitly add a `warnings` field which will warn the user why their address format is different.

ACKs for top commit:
  achow101:
    ACK d5cab1a96d

Tree-SHA512: c2ac7f7689251bd4fcd8c26506f053921fbaf34c7a26a74e82ebc7f82cc0bd25407fd7954bf98365dcafa51fa45dcdbee6214320580ca69509690c3555e71cc0
2021-12-11 09:41:25 +01:00
..
rpc Merge bitcoin/bitcoin#23113: Add warnings to createmultisig and addmultisig if using uncompressed keys 2021-12-11 09:41:25 +01:00
test Merge bitcoin/bitcoin#22019: wallet: Introduce SelectionResult for encapsulating a coin selection solution 2021-12-09 17:21:46 +01:00
bdb.cpp wallet: Use PACKAGE_NAME to mention our software 2021-10-20 21:09:14 +03:00
bdb.h wallet: Fixed Grammatical error in bdb.h 2021-11-09 12:41:37 +01:00
coincontrol.cpp refactor: Drop CCoinControl::SetNull 2021-04-18 21:10:47 +01:00
coincontrol.h External input fund support cleanups 2021-10-06 06:55:34 +08:00
coinselection.cpp Merge bitcoin/bitcoin#22019: wallet: Introduce SelectionResult for encapsulating a coin selection solution 2021-12-09 17:21:46 +01:00
coinselection.h Use SelectionResult for waste calculation 2021-12-05 13:43:28 -05:00
context.cpp
context.h wallet: Call load handlers without cs_wallet locked 2021-11-22 09:42:36 +00:00
crypter.cpp refactor: Replace &foo[0] with foo.data() 2021-05-04 06:55:31 +02:00
crypter.h
db.cpp refactor: get wallet path relative to wallet_dir 2021-10-29 09:36:32 -05:00
db.h refactor: post Optional<> removal cleanups 2021-03-17 14:56:20 +08:00
dump.cpp Remove gArgs from wallet.h and wallet.cpp 2021-11-09 11:27:06 +01:00
dump.h
external_signer_scriptpubkeyman.cpp psbt: sign without finalizing 2021-09-28 19:13:42 -04:00
external_signer_scriptpubkeyman.h psbt: sign without finalizing 2021-09-28 19:13:42 -04:00
feebumper.cpp refactor: Detach wallet transaction methods (followup for move-only) 2021-09-01 02:22:58 -05:00
feebumper.h
fees.cpp
fees.h [MOVEONLY] consensus: move amount.h into consensus 2021-09-30 07:41:57 +08:00
init.cpp Mention bech32m in -addresstype and -changetype help 2021-11-16 12:20:13 -05:00
interfaces.cpp MOVEONLY: Move rpcwallet to rpc/wallet 2021-12-08 11:45:21 +13:00
ismine.h refactor: Use underlying type of isminetype for isminefilter 2021-11-25 14:56:30 +01:00
load.cpp refactor: Block unsafe fs::path std::string conversion calls 2021-10-05 11:10:47 -04:00
load.h refactor: remove ::vpwallets and related global variables 2021-08-17 04:05:15 -04:00
receive.cpp [MOVEONLY] consensus: move amount.h into consensus 2021-09-30 07:41:57 +08:00
receive.h [MOVEONLY] consensus: move amount.h into consensus 2021-09-30 07:41:57 +08:00
salvage.cpp Remove gArgs from wallet.h and wallet.cpp 2021-11-09 11:27:06 +01:00
salvage.h
scriptpubkeyman.cpp psbt: Make sighash_type std::optional<int> 2021-12-08 09:43:26 -05:00
scriptpubkeyman.h psbt: Actually use SIGHASH_DEFAULT 2021-12-08 09:43:30 -05:00
spend.cpp Use SelectionResult in SelectCoins 2021-12-05 13:44:10 -05:00
spend.h Use SelectionResult in SelectCoins 2021-12-05 13:44:10 -05:00
sqlite.cpp wallet: Use PACKAGE_NAME to mention our software 2021-10-20 21:09:14 +03:00
sqlite.h
transaction.cpp refactor: Make CWalletTx sync state type-safe 2021-11-15 09:11:44 -05:00
transaction.h refactor: Make CWalletTx sync state type-safe 2021-11-15 09:11:44 -05:00
wallet.cpp Merge bitcoin/bitcoin#23628: Check descriptors returned by external signers 2021-12-10 09:17:35 +08:00
wallet.h psbt: Actually use SIGHASH_DEFAULT 2021-12-08 09:43:30 -05:00
walletdb.cpp refactor: Make CWalletTx sync state type-safe 2021-11-15 09:11:44 -05:00
walletdb.h Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus 2021-10-05 09:43:23 +02:00
wallettool.cpp Merge bitcoin/bitcoin#23346: util, refactor: Improve headers for bitcoin-wallet tool 2021-12-09 13:44:24 +01:00
wallettool.h util, refactor: Improve headers for bitcoin-wallet tool 2021-10-30 21:43:49 +03:00
walletutil.cpp refactor: Block unsafe fs::path std::string conversion calls 2021-10-05 11:10:47 -04:00
walletutil.h wallet: Upgrade existing descriptor caches 2021-06-24 13:49:22 -04:00