elements/test/functional
merge-script b7ee5fb8a5 Merge bitcoin/bitcoin#33001: test: Do not pass tests on unhandled exceptions
faa3e684118bffa7a98cf76eeeb59243219df900 test: Log KeyboardInterrupt as exception (MarcoFalke)
fa30b34026f76a5b8af997152fced2d281782e0d test: Do not pass tests on unhandled exceptions (MarcoFalke)

Pull request description:

  Currently the functional tests are problematic, because they pass, even if they encounter an unhanded exception.

  Fix this by handling all exceptions: Catch `BaseException` as fallback and mark it as failure.

  Can be tested via:

  ```diff
  diff --git a/test/functional/wallet_disable.py b/test/functional/wallet_disable.py
  index da6e5d408f..ecc41fb041 100755
  --- a/test/functional/wallet_disable.py
  +++ b/test/functional/wallet_disable.py
  @@ -19,6 +19,7 @@ class DisableWalletTest (BitcoinTestFramework):
           self.wallet_names = []

       def run_test (self):
  +        import sys;sys.exit("fatal error")
           # Make sure wallet is really disabled
           assert_raises_rpc_error(-32601, 'Method not found', self.nodes[0].getwalletinfo)
           x = self.nodes[0].validateaddress('3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy')
  ```

  Previously, the test would pass. With this patch, it would fail.

ACKs for top commit:
  enirox001:
    Looks good to me—ACK faa3e68
  stickies-v:
    re-ACK faa3e684118bffa7a98cf76eeeb59243219df900
  pablomartin4btc:
    tACK faa3e684118bffa7a98cf76eeeb59243219df900

Tree-SHA512: 11ecd5201982e2c776e48d98834b17c15a415306a95524bc702daeba20a316aac797748e9592be8db575597804f149ee7ef104416037cc9e5891758625810e2d
2025-11-25 16:25:39 +00:00
..
data rpc: fix bug in 'utxo_size_inc' calculation 2023-09-13 09:27:52 +02:00
mocks Check descriptors returned by external signers 2021-12-09 11:17:04 +01:00
test_framework Merge bitcoin/bitcoin#33001: test: Do not pass tests on unhandled exceptions 2025-11-25 16:25:39 +00:00
.gitignore
combine_logs.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
combined_log_template.html
create_cache.py
example_elements_code_tutorial.py CI: example_elements_code_tutorial test test uses initialfreecoins, disable for descriptor wallets 2025-02-06 13:35:38 -08:00
example_test.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_abortnode.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_addrman.py Merge b00b60ed4f into merged_master (Bitcoin PR bitcoin/bitcoin#24201) 2023-07-02 15:50:25 +00:00
feature_anchors.py Merge a574f4ad39 into merged_master (Bitcoin PR bitcoin/bitcoin#23392) 2023-05-31 11:42:45 +00:00
feature_asmap.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
feature_assetsdir.py Merge 2e82af46e2 into merged_master (Bitcoin PR bitcoin/bitcoin#23207) 2023-05-12 09:55:10 +00:00
feature_assumevalid.py Merge 3a36ec83d0 into merged_master (Bitcoin PR bitcoin/bitcoin#23521) 2023-05-29 13:17:22 +00:00
feature_backwards_compatibility.py test: Fix intermittent test failure in feature_backwards_compatibility 2021-12-16 12:51:08 +07:00
feature_bind_extra.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
feature_bind_port_discover.py net: only assume all local addresses if listening on any 2022-03-02 15:42:40 +01:00
feature_bind_port_externalip.py net: fix GetListenPort() to derive the proper port 2022-03-02 15:42:37 +01:00
feature_bip68_sequence.py Merge bitcoin/bitcoin#32765: test: Fix list index out of range error in feature_bip68_sequence.py 2025-11-25 13:39:58 +00:00
feature_block.py lint: fix issues from lint-python.sh 2023-09-01 16:04:39 +02:00
feature_block_subsidy.py Merge 94db963de5 into merged_master (Bitcoin PR bitcoin/bitcoin#23300) 2023-05-17 13:44:36 +00:00
feature_block_v4.py Merge 2e82af46e2 into merged_master (Bitcoin PR bitcoin/bitcoin#23207) 2023-05-12 09:55:10 +00:00
feature_blockfilterindex_prune.py Merge df6e961c41 into merged_master (Bitcoin PR bitcoin/bitcoin#23777) 2023-06-13 14:10:29 +00:00
feature_blocksdir.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_blocksign.py fix typo in test/functional/feature_blocksign.py 2024-01-12 21:48:48 +08:00
feature_cltv.py Merge d4e92d8436 into merged_master (Bitcoin PR bitcoin/bitcoin#23508) 2023-06-29 11:46:17 +00:00
feature_coinstatsindex.py Merge 2f26d8ec70 into merged_master (Bitcoin PR bitcoin/bitcoin#23725) 2023-06-12 12:36:20 +00:00
feature_confidential_transactions.py add missing proof checks and tests 2025-03-26 11:35:22 +00:00
feature_config_args.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
feature_connect_genesis_outputs.py Merge ac5a435247 into merged_master (Elements PR #838) 2020-11-26 01:08:00 +00:00
feature_csv_activation.py Merge 6d76b57ca0 into merged_master (Bitcoin PR bitcoin/bitcoin#22960) 2023-04-21 11:35:05 +00:00
feature_dbcrash.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_default_asset_name.py Merge 2e82af46e2 into merged_master (Bitcoin PR bitcoin/bitcoin#23207) 2023-05-12 09:55:10 +00:00
feature_dersig.py Merge d4e92d8436 into merged_master (Bitcoin PR bitcoin/bitcoin#23508) 2023-06-29 11:46:17 +00:00
feature_dirsymlinks.py test: Run symlink regression tests on Windows 2022-02-18 15:27:08 +01:00
feature_discount_ct.py feature_discount_ct: some txs can return 2 different weights, adapt the test to it 2025-02-22 09:05:56 -08:00
feature_discount_ct_ordering.py CI: discounttests use initialfreecoins, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
feature_dynafed.py fix intermittent functional test failures 2025-08-08 14:54:54 +01:00
feature_elements_simplicity_activation.py simplicity: change deployment to version bit 21 2025-03-25 09:29:04 +02:00
feature_elements_taproot_activation.py fixed tests 2025-03-10 13:03:15 +00:00
feature_fedpeg.py feature_fedpeg: Use os.join instead of hardcoded separator 2025-02-23 10:19:51 -08:00
feature_fee_estimation.py Merge 799fd7a488 into merged_master (Bitcoin PR bitcoin/bitcoin#23075) 2023-06-15 10:42:51 +00:00
feature_filelock.py Merge bitcoin/bitcoin#30435: init: change shutdown order of load block thread and scheduler 2025-06-24 10:25:22 +01:00
feature_help.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_includeconf.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
feature_init.py test: activate all index types in feature_init.py 2022-01-31 21:21:39 +01:00
feature_initial_reissuance_token.py Merge 2e82af46e2 into merged_master (Bitcoin PR bitcoin/bitcoin#23207) 2023-05-12 09:55:10 +00:00
feature_issuance.py Enable sending of different assets to the same address (#1479) 2025-07-30 12:41:37 +01:00
feature_loadblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_logging.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_mandatory_coinbase.py Merge 2e82af46e2 into merged_master (Bitcoin PR bitcoin/bitcoin#23207) 2023-05-12 09:55:10 +00:00
feature_maxtipage.py test: add functional test for -maxtipage parameter 2022-01-25 16:20:00 +01:00
feature_maxuploadtarget.py test: Use byte unit 'M' for -maxuploadtarget functional test 2021-12-10 20:41:34 +02:00
feature_notifications.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_nulldummy.py Merge d94dc69ee4 into merged_master (Bitcoin PR bitcoin/bitcoin#23501) 2023-05-26 13:18:58 +00:00
feature_pak.py fix feature_pak test 2025-08-05 13:51:27 +01:00
feature_presegwit_node_upgrade.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_progress.py Merge 94db963de5 into merged_master (Bitcoin PR bitcoin/bitcoin#23300) 2023-05-17 13:44:36 +00:00
feature_proxy.py net: respect -onlynet= when making outbound connections 2021-11-24 12:44:05 +01:00
feature_pruning.py test: run feature_pruning.py without wallet compiled 2022-01-03 22:13:46 +01:00
feature_rbf.py lint: fix issues from lint-python.sh 2023-09-01 16:04:39 +02:00
feature_reindex.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
feature_segwit.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
feature_settings.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
feature_shutdown.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
feature_sighash_rangeproof.py Merge 6802564be5 into merged_master (Elements PR #1246) 2023-08-29 04:21:31 +00:00
feature_signet.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
feature_startupnotify.py test: wait rather than assert presence of file in startupnotify test 2022-01-05 09:25:43 +08:00
feature_syscall_sandbox.py test: Properly skip feature_syscall_sandbox in valgrind 2022-02-04 16:33:05 +01:00
feature_taphash_pegins_issuances.py CI: feature_taphash_pegins_issuances test uses initialfreecoins, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
feature_taproot.py disable simplicity on regtest 2024-10-08 14:41:39 +00:00
feature_tapscript_opcodes.py Merge pull request #1310 from GoodDaisy/master 2025-02-13 09:47:55 +02:00
feature_trim_headers.py CI: trim_headers test uses combineblocksigs, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
feature_txindex_compatibility.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
feature_txwitness.py Merge 2e82af46e2 into merged_master (Bitcoin PR bitcoin/bitcoin#23207) 2023-05-12 09:55:10 +00:00
feature_uacomment.py
feature_utxo_set_hash.py Merge 807169e10b into merged_master (Bitcoin PR bitcoin/bitcoin#24035) 2023-06-20 09:57:58 +00:00
feature_versionbits_warning.py test: refactor: take use of create_block version parameter (or use default) 2021-11-17 15:44:09 +01:00
interface_bitcoin_cli.py Rename 'bitcoin-cli' -> 'elements-cli' in logging change introduced in the merge of bitcoin/bitcoin#23712 in 4c0504b349 2023-07-24 17:50:33 +00:00
interface_http.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_rest.py Merge a41976ab77 into merged_master (Bitcoin PR bitcoin/bitcoin#24223) 2023-06-30 06:22:27 +00:00
interface_rpc.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
interface_zmq.py test: fix node_fastmerkle exception in interface_zmq.py 2023-09-08 09:57:28 +02:00
mempool_accept.py test: use bitcoin default dustrelayfee in mempool_accept.py 2025-03-13 09:38:10 +02:00
mempool_accept_wtxid.py Merge a5d00d4baf into merged_master (Bitcoin PR bitcoin/bitcoin#22788) 2023-04-21 04:02:55 +00:00
mempool_compatibility.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
mempool_expiry.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mempool_limit.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
mempool_package_limits.py lint: fix issues from lint-python.sh 2023-09-01 16:04:39 +02:00
mempool_package_onemore.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
mempool_packages.py Merge 4fd0ce75c5 into merged_master (Bitcoin PR bitcoin/bitcoin#22689) 2023-06-02 15:34:33 +00:00
mempool_persist.py Merge a5d00d4baf into merged_master (Bitcoin PR bitcoin/bitcoin#22788) 2023-04-21 04:02:55 +00:00
mempool_reorg.py test: MiniWallet: support default from_node for creating txs 2022-01-11 16:22:33 +01:00
mempool_resurrect.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mempool_spend_coinbase.py test: MiniWallet: support default from_node for creating txs 2022-01-11 16:22:33 +01:00
mempool_unbroadcast.py prevent reused utxo 2025-07-28 14:30:09 +01:00
mempool_updatefromblock.py Merge 0147278e37 into merged_master (Bitcoin PR bitcoin/bitcoin#21464) 2023-06-21 09:23:39 +00:00
mining_basic.py lint: fix issues from lint-python.sh 2023-09-01 16:04:39 +02:00
mining_getblocktemplate_longpoll.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
mining_prioritisetransaction.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
p2p_add_connections.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
p2p_addr_relay.py test: Combine addr generation helper functions 2021-12-16 12:43:38 +00:00
p2p_addrfetch.py test: use test_framework.p2p P2P_SERVICES in functional tests 2021-09-19 14:20:48 +02:00
p2p_addrv2_relay.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_blockfilters.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_blocksonly.py test: MiniWallet: support default from_node for creating txs 2022-01-11 16:22:33 +01:00
p2p_compactblocks.py Merge bitcoin/bitcoin#33296: net: check for empty header before calling FillBlock 2025-11-25 12:58:39 +00:00
p2p_compactblocks_blocksonly.py test: Implicitly sync after generate*, unless opted out 2021-10-29 13:34:52 +02:00
p2p_compactblocks_hb.py scripted-diff: Remove redundant sync_all and sync_blocks 2021-11-10 11:10:15 +01:00
p2p_disconnect_ban.py test: set ban after mocking time 2022-01-06 15:33:43 -03:00
p2p_dns_seeds.py [test] Test the delay before querying DNS seeds 2021-07-30 11:15:49 -07:00
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_eviction.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
p2p_feefilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_filter.py test: introduce getnewdestination helper for generating various address types 2021-12-26 12:10:52 +01:00
p2p_fingerprint.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_getaddr_caching.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
p2p_getdata.py
p2p_i2p_ports.py test: ensure I2P ports are handled as expected 2021-07-09 11:19:37 +02:00
p2p_ibd_txrelay.py lint: fix issues from lint-python.sh 2023-09-01 16:04:39 +02:00
p2p_invalid_block.py lint: fix issues from lint-python.sh 2023-09-01 16:04:39 +02:00
p2p_invalid_locator.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_invalid_messages.py fixed payload limit for elements 2025-10-15 16:06:22 +01:00
p2p_invalid_tx.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
p2p_leak.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_leak_tx.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_message_capture.py Merge 30308cc380 into merged_master (Bitcoin PR bitcoin/bitcoin#20196) 2023-07-03 11:17:52 +00:00
p2p_nobloomfilter_messages.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
p2p_node_network_limited.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_permissions.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
p2p_ping.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_segwit.py Merge 3a36ec83d0 into merged_master (Bitcoin PR bitcoin/bitcoin#23521) 2023-05-29 13:17:22 +00:00
p2p_sendheaders.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
p2p_timeouts.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
p2p_tx_download.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
p2p_unrequested_blocks.py test: refactor: take use of create_block txlist parameter 2021-11-17 15:45:30 +01:00
README.md Enable TLS in links in documentation 2021-09-16 22:00:20 +00:00
rpc_addresses_deprecation.py Merge a5d00d4baf into merged_master (Bitcoin PR bitcoin/bitcoin#22788) 2023-04-21 04:02:55 +00:00
rpc_bind.py
rpc_blockchain.py fixed tests 2025-03-10 13:03:15 +00:00
rpc_calcfastmerkleroot.py
rpc_createmultisig.py test: ensure createmultisig and addmultisigaddress are not returning any warning for expected cases 2025-03-10 16:21:52 +00:00
rpc_decodescript.py Merge 8add59d77d into merged_master (Bitcoin PR bitcoin/bitcoin#24367) 2023-07-02 07:33:56 +00:00
rpc_deprecated.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_deriveaddresses.py use elements regtest address for derive test 2025-03-10 23:02:16 +00:00
rpc_dumptxoutset.py Merge 6acda4b00b into merged_master (Bitcoin PR bitcoin/bitcoin#23155) 2023-06-01 11:31:51 +00:00
rpc_estimatefee.py scripted-diff: Remove setup_clean_chain if default is not changed 2021-02-01 23:13:38 +01:00
rpc_fundrawtransaction.py remove unused variable 2025-07-07 15:55:11 +01:00
rpc_generate.py scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
rpc_generateblock.py Merge 807169e10b into merged_master (Bitcoin PR bitcoin/bitcoin#24035) 2023-06-20 09:57:58 +00:00
rpc_getblockfilter.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getblockfrompeer.py Merge bitcoin/bitcoin#23706: rpc: getblockfrompeer followups 2022-01-25 18:48:41 +01:00
rpc_getblockstats.py rpc: Quote user supplied strings in error messages 2021-12-13 15:18:35 +01:00
rpc_getchaintips.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_getdescriptorinfo.py rpc: Quote user supplied descriptor in error msg 2022-01-01 00:26:08 +13:00
rpc_getnewblockhex.py Merge bb60960750 into merged_master (Bitcoin PR bitcoin/bitcoin#22593) 2023-04-03 20:34:45 +00:00
rpc_help.py doc: Rework generate* doc 2022-02-21 11:02:20 +01:00
rpc_invalid_address_message.py Fix: address error messages and test (#1486) 2025-08-25 15:05:57 +02:00
rpc_invalidateblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_mempool_entry_fee_fields_deprecation.py test: add functional test for deprecatedrpc=fees 2021-11-02 10:05:38 +01:00
rpc_misc.py Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive 2025-02-15 00:22:57 -08:00
rpc_named_arguments.py
rpc_net.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
rpc_packages.py Merge a5d00d4baf into merged_master (Bitcoin PR bitcoin/bitcoin#22788) 2023-04-21 04:02:55 +00:00
rpc_preciousblock.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_psbt.py Merge branch 'master' into elem-23.3.1-rc1 2025-07-14 16:35:03 -07:00
rpc_rawtransaction.py Enable sending of different assets to the same address (#1479) 2025-07-30 12:41:37 +01:00
rpc_scantxoutset.py Merge d3582f2d3b into merged_master (Bitcoin PR bitcoin/bitcoin#23866) 2023-06-14 13:08:29 +00:00
rpc_setban.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signer.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
rpc_signmessagewithprivkey.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
rpc_signrawtransaction.py test: reduce sleep time in witness_script_test and bump precision for csv test 2023-10-18 14:09:09 +02:00
rpc_tweakfedpeg.py test: fix tests broken by change to getpeginaddress 2024-05-06 14:21:44 +02:00
rpc_txoutproof.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
rpc_uptime.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
rpc_users.py Merge 4a540683ec into merged_master (Bitcoin PR #20813) 2021-06-16 14:11:07 +00:00
rpc_whitelist.py Merge 6cb80a068d into merged_master (Bitcoin PR #17806) 2020-11-14 16:52:01 +00:00
test-shell.md scripted-diff: Use generate* from TestFramework 2021-09-02 10:34:35 +02:00
test_runner.py fixed payload limit for elements 2025-10-15 16:06:22 +01:00
tool_wallet.py Merge 801aaac2b3 into merged_master (Bitcoin PR bitcoin/bitcoin#23834) 2023-06-15 09:35:17 +00:00
wallet_abandonconflict.py Merge 02e1d8d06f into merged_master (Bitcoin PR bitcoin/bitcoin#24083) 2023-06-30 06:11:44 +00:00
wallet_address_types.py Merge 3ac38058ce into merged_master (Bitcoin PR bitcoin/bitcoin#23789) 2023-06-14 05:39:34 +00:00
wallet_avoidreuse.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_backup.py Merge a30642926a into merged_master (Bitcoin PR bitcoin/bitcoin#23721) 2023-06-13 13:41:22 +00:00
wallet_balance.py Merge 3ac38058ce into merged_master (Bitcoin PR bitcoin/bitcoin#23789) 2023-06-14 05:39:34 +00:00
wallet_basic.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_bumpfee.py Merge 3a36ec83d0 into merged_master (Bitcoin PR bitcoin/bitcoin#23521) 2023-05-29 13:17:22 +00:00
wallet_coinbase_category.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_create_tx.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_createwallet.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 2021-11-16 12:20:13 -05:00
wallet_descriptor.py Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default 2021-11-16 12:20:13 -05:00
wallet_disable.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_dump.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_elements_21million.py add reissuance token moneyrange check 2025-11-11 00:24:23 +00:00
wallet_elements_dust_relay.py test: add dust relay output value test 2025-03-19 14:48:27 +02:00
wallet_elements_regression_1172.py Merge 2e82af46e2 into merged_master (Bitcoin PR bitcoin/bitcoin#23207) 2023-05-12 09:55:10 +00:00
wallet_elements_regression_1259.py fix intermittent functional test failures 2025-08-08 14:54:54 +01:00
wallet_elements_regression_1263.py CI: wallet_elements_regression_1263 uses getpeginaddress, disable for descriptor wallets 2025-02-06 13:35:20 -08:00
wallet_encryption.py Replace "can not" with "cannot" in docs, user messages, and tests 2022-02-21 19:07:29 +01:00
wallet_fallbackfee.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_groups.py test: fix flaky test wallet_groups.py 2023-11-22 08:55:40 +02:00
wallet_hd.py Merge 3ac38058ce into merged_master (Bitcoin PR bitcoin/bitcoin#23789) 2023-06-14 05:39:34 +00:00
wallet_implicitsegwit.py
wallet_import_rescan.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_import_with_label.py
wallet_importdescriptors.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_importmulti.py Merge 89ea2b3809 into merged_master (Bitcoin PR bitcoin/bitcoin#20583) 2023-06-02 12:25:30 +00:00
wallet_importprunedfunds.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_inactive_hdchains.py tests: Tests for inactive HD chains 2022-02-22 14:41:52 -05:00
wallet_keypool.py Merge 47fe7445e7 into merged_master (Bitcoin PR bitcoin/bitcoin#22364) 2023-05-29 12:58:36 +00:00
wallet_keypool_topup.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_labels.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_listdescriptors.py Merge 47fe7445e7 into merged_master (Bitcoin PR bitcoin/bitcoin#22364) 2023-05-29 12:58:36 +00:00
wallet_listreceivedby.py Merge 63c63b5533 into merged_master (Bitcoin PR bitcoin/bitcoin#14707) 2023-06-05 11:19:58 +00:00
wallet_listsinceblock.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_listtransactions.py Merge 369978686e into merged_master (Bitcoin PR bitcoin/bitcoin#23835) 2023-06-14 07:10:26 +00:00
wallet_multisig_descriptor_psbt.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_multiwallet.py Merge 3ace3a17c9 into merged_master (Bitcoin PR bitcoin/bitcoin#20744) 2023-06-30 07:38:29 +00:00
wallet_orphanedreward.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_reorgsrestore.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_resendwallettransactions.py Merge bitcoin/bitcoin#23474: test: scripted-diff cleanups after generate* changes 2021-11-16 11:22:06 +08:00
wallet_send.py tests: Calculate input weight more accurately 2025-03-10 15:15:58 +00:00
wallet_send_zero_fee.py test: minor improvements for send_zero_fee 2025-07-25 15:03:22 +02:00
wallet_signer.py Merge 2d7ea201fc into merged_master (Bitcoin PR bitcoin/bitcoin#24307) 2023-06-30 12:57:14 +00:00
wallet_signmessagewithaddress.py scripted-diff: Bump copyright headers 2021-11-10 11:10:24 +01:00
wallet_startup.py scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
wallet_taproot.py Merge 064c729a96 into merged_master (Bitcoin PR bitcoin/bitcoin#23512) 2023-05-31 06:23:55 +00:00
wallet_timelock.py Merge 8add59d77d into merged_master (Bitcoin PR bitcoin/bitcoin#24367) 2023-07-02 07:33:56 +00:00
wallet_transactiontime_rescan.py Merge 32d9f3770a into merged_master (Bitcoin PR bitcoin/bitcoin#23596) 2023-06-02 08:38:00 +00:00
wallet_txn_clone.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_txn_doublespend.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00
wallet_upgradewallet.py tests: Test upgrading wallet with privkeys disabled 2022-02-22 13:52:40 -05:00
wallet_watchonly.py Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474) 2023-05-26 10:32:04 +00:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The CI linter job also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use f'{x}' for string formatting in preference to '{}'.format(x) or '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to True to initialize an empty blockchain and start from the Genesis block, rather than load a premined blockchain from cache with the default value of False. The cached data directories contain a 200-block pre-mined blockchain with the spendable mining rewards being split between four nodes. Each node has 25 mature block subsidies (25x50=1250 BTC) in its wallet. Using them is much more efficient than mining blocks in your test.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • P2Ps can be used to test specific P2P protocol behavior. p2p.py contains test framework p2p objects and messages.py contains all the definitions for objects passed over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

P2PConnections can be used as such:

p2p_conn = node.add_p2p_connection(P2PInterface())
p2p_conn.send_and_ping(msg)

They can also be referenced by indexing into a TestNode's p2ps list, which contains the list of test framework p2p objects connected to itself (it does not include any TestNodes):

node.p2ps[0].sync_with_ping()

More examples can be found in p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

p2p.py

Test objects for interacting with a bitcoind node over the p2p interface.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2ps[0].send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: