Murch af56d63eca Revert "bnb: exit selection when best_waste is 0" ... This reverts commit 9b5950db86. Waste can be negative. At feerates lower than long_term_feerate this means that a waste of 0 may be a suboptimal solution and this causes the search to exit prematurely. Only when the feerate is equal to the long_term_feerate would achieving a waste of 0 indicate that we have achieved an optimal solution, because it would mean that the excess is 0. It seems unlikely that this would ever occur outside of test cases, and even then we should prefer solutions with more inputs over solutions with fewer according to previous decisions—but solutions with more inputs are found later in the branch exploration. The "optimization" described in #18257 and implemented in #18262 is therefore a premature exit on a suboptimal solution and should be reverted.		2022-06-28 17:27:06 -04:00
..
rpc	scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs	2022-06-19 20:32:51 -03:00
test	Revert "bnb: exit selection when best_waste is 0"	2022-06-28 17:27:06 -04:00
bdb.cpp	scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)	2022-05-12 15:44:24 +02:00
bdb.h	scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)	2022-05-12 15:44:24 +02:00
coincontrol.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
coincontrol.h	scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs	2022-06-19 20:32:51 -03:00
coinselection.cpp	Revert "bnb: exit selection when best_waste is 0"	2022-06-28 17:27:06 -04:00
coinselection.h	Set effective_value when initializing a COutput	2022-05-21 11:25:54 -04:00
context.cpp	refactor: use C++11 default initializers	2022-05-17 17:18:58 +01:00
context.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
db.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
db.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
dump.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
dump.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
external_signer_scriptpubkeyman.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
external_signer_scriptpubkeyman.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
feebumper.cpp	scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs	2022-06-19 20:32:51 -03:00
feebumper.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
fees.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
fees.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
init.cpp	scripted-diff: Avoid incompatibility with CMake AUTOUIC feature	2022-06-14 10:38:51 +02:00
interfaces.cpp	wallet: IsSpent, 'COutPoint' arg instead of (hash, index)	2022-06-08 11:22:39 -03:00
ismine.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
load.cpp	wallet: Postpone NotifyWalletLoaded() for encrypted wallets	2022-03-30 21:28:53 +02:00
load.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
receive.cpp	wallet: avoid extra IsSpentKey -> GetWalletTx lookups	2022-06-08 11:22:40 -03:00
receive.h	Add more proper thread safety annotations	2022-05-16 20:51:40 +02:00
salvage.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
salvage.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
scriptpubkeyman.cpp	wallet: also search taproot pubkeys in FillPSBT	2022-06-27 16:47:48 -04:00
scriptpubkeyman.h	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
spend.cpp	scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs	2022-06-19 20:32:51 -03:00
spend.h	wallet: GetAvailableBalance, remove double walk-through every available coin	2022-06-08 11:30:26 -03:00
sqlite.cpp	scripted-diff: Convert global Mutexes to GlobalMutexes	2022-05-21 01:23:23 +10:00
sqlite.h	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
transaction.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
transaction.h	wallet: add GetWitnessHash()	2022-02-01 08:44:51 -03:00
wallet.cpp	psbt: Remove non_witness_utxo for segwit v1+	2022-06-27 16:47:48 -04:00
wallet.h	wallet: avoid extra wtx lookup in AddToSpends	2022-06-20 14:21:57 -03:00
walletdb.cpp	Merge bitcoin/bitcoin#24924: bench: Make WalletLoading benchmark run faster	2022-06-28 18:34:10 +01:00
walletdb.h	walletdb: Create a mock database of specific type	2022-05-10 11:54:02 -04:00
wallettool.cpp	Replace use of ArgsManager with DatabaseOptions	2022-03-16 08:26:28 +01:00
wallettool.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
walletutil.cpp	Use ArgsManager::GetPathArg() for "-walletdir" option	2022-02-09 19:31:23 +02:00
walletutil.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00