mirror of https://github.com/ElementsProject/elements.git synced 2026-08-20 13:37:28 +02:00

No description

Find a file

MarcoFalke abc26fa378 Merge bitcoin/bitcoin#22856 : test: Fix bug in transaction generation in ComplexMempool benchmark `29e983386b` Fixes Bug in Transaction generation in ComplexMempool benchmark (Shorya) Pull request description: This fixes issues with `ComplexMempool` benchmark introduced in [#17292](https://github.com/bitcoin/bitcoin/pull/17292) , this stress test benchmarks performance of ancestor and descendant tracking of mempool graph algorithms on a complex Mempool. This Benchmark first creates 100 base transactions and stores them in `available_coins` vector. `available_coins` is used for selecting ancestor transactions while creating 800 new transactions. For this a random transaction is picked from `available_coins` and some of its outputs are mapped to the inputs of the new transaction being created. Now in case we exhaust all the outputs of an entry in `available_coins` then we need to remove it from `available_coins` before the next iteration of choosing a potential ancestor , it is now implemented with this patch. As the index of the entry is randomly chosen from `available_coins` , In order to remove it from the vector , if index of the selected entry is not at the end of `available_coins` vector , it is swapped with the entry at the back of the vector , then the entry at the end of `available_coins` is popped out. Earlier the code responsible for constructing outputs of the newly created transaction was inside the loop used for assigning ancestors to the transaction , which does some unnecessary work as it creates outputs of the transaction again and again , now it is moved out of the loop so outputs of the transaction are created just once before adding it to the final list of the transactions created. This one is a minor change to save some computation. These changes have changed the `ComplexMempool` benchmark results on `bitcoin:master` as follows : Before > \| ns/op \| op/s \| err% \| total \| benchmark \|--------------------:\|--------------------:\|--------:\|----------:\|:---------- \| 232,881,625.00 \| 4.29 \| 0.7% \| 2.55 \| `ComplexMemPool` After > \| ns/op \| op/s \| err% \| total \| benchmark \|--------------------:\|--------------------:\|--------:\|----------:\|:---------- \| 497,275,135.00 \| 2.01 \| 0.5% \| 5.49 \| `ComplexMemPool` Top commit has no ACKs. Tree-SHA512: d6946d7e65c55f54c84cc49d7abee52e59ffc8b7668b3c80b4ce15a57690ab00a600c6241cc71a2a075def9c30792a311256fed325ef162f37aeacd2cce93624		2021-12-07 10:46:11 +01:00
.github	doc: Remove label from good first issue template	2020-08-24 09:31:24 +02:00
.tx	qt: Bump transifex slug for 22.x	2021-04-21 13:46:41 +02:00
build-aux/m4	build: remove x-prefix comparisons	2021-12-03 21:03:35 +08:00
build_msvc	doc: Update `build_msvc/README.md` for Qt 5.15.2	2021-12-03 14:07:12 +08:00
ci	test: Bump shellcheck version to 0.8.0	2021-11-30 21:15:40 +02:00
contrib	build: qt 5.15.2	2021-12-03 14:07:12 +08:00
depends	build: remove x-prefix comparisons	2021-12-03 21:03:35 +08:00
doc	doc: Merge release note snippets	2021-12-06 13:55:02 +01:00
share	test: Enable SC2086 shellcheck rule	2021-11-13 16:54:56 +02:00
src	Merge bitcoin/bitcoin#22856 : test: Fix bug in transaction generation in ComplexMempool benchmark	2021-12-07 10:46:11 +01:00
test	Merge bitcoin/bitcoin#20583 : rpc: Add missing BlockUntilSyncedToCurrentChain to wallet RPCs	2021-12-07 09:24:34 +01:00
.cirrus.yml	ci: Bump Qt to 5.15.2 in the native Windows task	2021-12-03 14:07:12 +08:00
.editorconfig	ci: Drop AppVeyor CI integration	2021-09-07 06:12:53 +03:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	build: add *~ to .gitignore	2021-05-12 18:10:47 +02:00
.python-version	Bump minimum python version to 3.6	2020-11-09 17:53:47 +10:00
.style.yapf	test: .style.yapf: Set column_limit=160	2019-03-04 18:28:13 -05:00
autogen.sh	scripted-diff: Bump copyright of files changed in 2019	2019-12-30 10:42:20 +13:00
configure.ac	build: remove x-prefix comparisons	2021-12-03 21:03:35 +08:00
CONTRIBUTING.md	Enable TLS in links in documentation	2021-09-16 22:00:20 +00:00
COPYING	doc: Update license year range to 2021	2020-12-30 16:24:47 +01:00
INSTALL.md	doc: Added hyperlink for doc/build	2021-09-09 19:53:12 +05:30
libbitcoinconsensus.pc.in	build: remove libcrypto as internal dependency in libbitcoinconsensus.pc	2019-11-19 15:03:44 +01:00
Makefile.am	Add minisketch dependency	2021-10-21 09:38:55 +08:00
README.md	doc: Rework internal and external links	2021-02-17 09:18:46 +01:00
REVIEWERS	release: remove gitian	2021-08-31 09:37:23 +08:00
SECURITY.md	doc: Suggest `keys.openpgp.org` as keyserver in SECURITY.md	2021-11-08 12:22:04 +01:00

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.

Further information about Bitcoin Core is available in the doc folder.

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information read the original Bitcoin whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be completely stable. Tags are created regularly from release branches to indicate new official, stable release versions of Bitcoin Core.

The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.