mirror of
https://github.com/ElementsProject/elements.git
synced 2026-08-18 13:17:55 +02:00
e47c6c7656Reset settings.json when GUI options are reset (Ryan Ofsky)99ccc02b65Add release notes about unified bitcoin-qt and bitcoind persistent settings (Ryan Ofsky)504b06b1deMigrate -lang setting from QSettings to settings.json (Ryan Ofsky)9a016a3c07Migrate -prune setting from QSettings to settings.json (Ryan Ofsky)f067e19433Migrate -proxy and -onion settings from QSettings to settings.json (Ryan Ofsky)a09e3b7cf2Migrate -listen and -server settings from QSettings to settings.json (Ryan Ofsky)d2ada6e635Migrate -upnp and -natpmp settings from QSettings to settings.json (Ryan Ofsky)1dc4fc29c1Migrate -spendzeroconfchange and -signer settings from QSettings to settings.json (Ryan Ofsky)a7ef6d5975Migrate -par setting from QSettings to settings.json (Ryan Ofsky)284f339de6Migrate -dbcache setting from QSettings to settings.json (Ryan Ofsky) Pull request description: If a setting like pruning, port mapping, or a network proxy is enabled in the GUI, it will now be stored in the bitcoin persistent setting file in the datadir and shared with bitcoind, instead of being stored as Qt settings which end up in the the windows registry or platform specific config files and are ignored by bitcoind. This PR has been split off from bitcoin/bitcoin#15936 so some review of these commits previously took place in that PR. ACKs for top commit: furszy: Code review ACKe47c6c76hebasto: ACKe47c6c7656Tree-SHA512: 076ea7c7efe67805b4a357113bfe1643dce364d0032774106de59566a0ed5771d57a5923920085e03d686beb34b98114bd278555dfdf8bb7af0b778b0f35b7d2
231 lines
8 KiB
C++
231 lines
8 KiB
C++
// Copyright (c) 2017-2021 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <qt/test/addressbooktests.h>
|
|
#include <qt/test/util.h>
|
|
#include <test/util/setup_common.h>
|
|
|
|
#include <interfaces/chain.h>
|
|
#include <interfaces/node.h>
|
|
#include <qt/addressbookpage.h>
|
|
#include <qt/clientmodel.h>
|
|
#include <qt/editaddressdialog.h>
|
|
#include <qt/optionsmodel.h>
|
|
#include <qt/platformstyle.h>
|
|
#include <qt/qvalidatedlineedit.h>
|
|
#include <qt/walletmodel.h>
|
|
|
|
#include <key.h>
|
|
#include <key_io.h>
|
|
#include <wallet/wallet.h>
|
|
#include <walletinitinterface.h>
|
|
|
|
#include <chrono>
|
|
|
|
#include <QApplication>
|
|
#include <QLineEdit>
|
|
#include <QMessageBox>
|
|
#include <QTableView>
|
|
#include <QTimer>
|
|
|
|
using wallet::AddWallet;
|
|
using wallet::CWallet;
|
|
using wallet::CreateMockWalletDatabase;
|
|
using wallet::RemoveWallet;
|
|
using wallet::WALLET_FLAG_DESCRIPTORS;
|
|
using wallet::WalletContext;
|
|
|
|
namespace
|
|
{
|
|
|
|
/**
|
|
* Fill the edit address dialog box with data, submit it, and ensure that
|
|
* the resulting message meets expectations.
|
|
*/
|
|
void EditAddressAndSubmit(
|
|
EditAddressDialog* dialog,
|
|
const QString& label, const QString& address, QString expected_msg)
|
|
{
|
|
QString warning_text;
|
|
|
|
dialog->findChild<QLineEdit*>("labelEdit")->setText(label);
|
|
dialog->findChild<QValidatedLineEdit*>("addressEdit")->setText(address);
|
|
|
|
ConfirmMessage(&warning_text, 5ms);
|
|
dialog->accept();
|
|
QCOMPARE(warning_text, expected_msg);
|
|
}
|
|
|
|
/**
|
|
* Test adding various send addresses to the address book.
|
|
*
|
|
* There are three cases tested:
|
|
*
|
|
* - new_address: a new address which should add as a send address successfully.
|
|
* - existing_s_address: an existing sending address which won't add successfully.
|
|
* - existing_r_address: an existing receiving address which won't add successfully.
|
|
*
|
|
* In each case, verify the resulting state of the address book and optionally
|
|
* the warning message presented to the user.
|
|
*/
|
|
void TestAddAddressesToSendBook(interfaces::Node& node)
|
|
{
|
|
TestChain100Setup test;
|
|
auto wallet_loader = interfaces::MakeWalletLoader(*test.m_node.chain, *Assert(test.m_node.args));
|
|
test.m_node.wallet_loader = wallet_loader.get();
|
|
node.setContext(&test.m_node);
|
|
const std::shared_ptr<CWallet> wallet = std::make_shared<CWallet>(node.context()->chain.get(), "", gArgs, CreateMockWalletDatabase());
|
|
wallet->LoadWallet();
|
|
wallet->SetWalletFlag(WALLET_FLAG_DESCRIPTORS);
|
|
{
|
|
LOCK(wallet->cs_wallet);
|
|
wallet->SetupDescriptorScriptPubKeyMans();
|
|
}
|
|
|
|
auto build_address = [&wallet]() {
|
|
CKey key;
|
|
key.MakeNewKey(true);
|
|
CTxDestination dest(GetDestinationForKey(
|
|
key.GetPubKey(), wallet->m_default_address_type));
|
|
|
|
return std::make_pair(dest, QString::fromStdString(EncodeDestination(dest)));
|
|
};
|
|
|
|
CTxDestination r_key_dest, s_key_dest;
|
|
|
|
// Add a preexisting "receive" entry in the address book.
|
|
QString preexisting_r_address;
|
|
QString r_label("already here (r)");
|
|
|
|
// Add a preexisting "send" entry in the address book.
|
|
QString preexisting_s_address;
|
|
QString s_label("already here (s)");
|
|
|
|
// Define a new address (which should add to the address book successfully).
|
|
QString new_address_a;
|
|
QString new_address_b;
|
|
|
|
std::tie(r_key_dest, preexisting_r_address) = build_address();
|
|
std::tie(s_key_dest, preexisting_s_address) = build_address();
|
|
std::tie(std::ignore, new_address_a) = build_address();
|
|
std::tie(std::ignore, new_address_b) = build_address();
|
|
|
|
{
|
|
LOCK(wallet->cs_wallet);
|
|
wallet->SetAddressBook(r_key_dest, r_label.toStdString(), "receive");
|
|
wallet->SetAddressBook(s_key_dest, s_label.toStdString(), "send");
|
|
}
|
|
|
|
auto check_addbook_size = [&wallet](int expected_size) {
|
|
LOCK(wallet->cs_wallet);
|
|
QCOMPARE(static_cast<int>(wallet->m_address_book.size()), expected_size);
|
|
};
|
|
|
|
// We should start with the two addresses we added earlier and nothing else.
|
|
check_addbook_size(2);
|
|
|
|
// Initialize relevant QT models.
|
|
std::unique_ptr<const PlatformStyle> platformStyle(PlatformStyle::instantiate("other"));
|
|
OptionsModel optionsModel(node);
|
|
bilingual_str error;
|
|
QVERIFY(optionsModel.Init(error));
|
|
ClientModel clientModel(node, &optionsModel);
|
|
WalletContext& context = *node.walletLoader().context();
|
|
AddWallet(context, wallet);
|
|
WalletModel walletModel(interfaces::MakeWallet(context, wallet), clientModel, platformStyle.get());
|
|
RemoveWallet(context, wallet, /* load_on_start= */ std::nullopt);
|
|
EditAddressDialog editAddressDialog(EditAddressDialog::NewSendingAddress);
|
|
editAddressDialog.setModel(walletModel.getAddressTableModel());
|
|
|
|
AddressBookPage address_book{platformStyle.get(), AddressBookPage::ForEditing, AddressBookPage::SendingTab};
|
|
address_book.setModel(walletModel.getAddressTableModel());
|
|
auto table_view = address_book.findChild<QTableView*>("tableView");
|
|
QCOMPARE(table_view->model()->rowCount(), 1);
|
|
|
|
EditAddressAndSubmit(
|
|
&editAddressDialog, QString("uhoh"), preexisting_r_address,
|
|
QString(
|
|
"Address \"%1\" already exists as a receiving address with label "
|
|
"\"%2\" and so cannot be added as a sending address."
|
|
).arg(preexisting_r_address).arg(r_label));
|
|
check_addbook_size(2);
|
|
QCOMPARE(table_view->model()->rowCount(), 1);
|
|
|
|
EditAddressAndSubmit(
|
|
&editAddressDialog, QString("uhoh, different"), preexisting_s_address,
|
|
QString(
|
|
"The entered address \"%1\" is already in the address book with "
|
|
"label \"%2\"."
|
|
).arg(preexisting_s_address).arg(s_label));
|
|
check_addbook_size(2);
|
|
QCOMPARE(table_view->model()->rowCount(), 1);
|
|
|
|
// Submit a new address which should add successfully - we expect the
|
|
// warning message to be blank.
|
|
EditAddressAndSubmit(
|
|
&editAddressDialog, QString("io - new A"), new_address_a, QString(""));
|
|
check_addbook_size(3);
|
|
QCOMPARE(table_view->model()->rowCount(), 2);
|
|
|
|
EditAddressAndSubmit(
|
|
&editAddressDialog, QString("io - new B"), new_address_b, QString(""));
|
|
check_addbook_size(4);
|
|
QCOMPARE(table_view->model()->rowCount(), 3);
|
|
|
|
auto search_line = address_book.findChild<QLineEdit*>("searchLineEdit");
|
|
|
|
search_line->setText(r_label);
|
|
QCOMPARE(table_view->model()->rowCount(), 0);
|
|
|
|
search_line->setText(s_label);
|
|
QCOMPARE(table_view->model()->rowCount(), 1);
|
|
|
|
search_line->setText("io");
|
|
QCOMPARE(table_view->model()->rowCount(), 2);
|
|
|
|
// Check wildcard "?".
|
|
search_line->setText("io?new");
|
|
QCOMPARE(table_view->model()->rowCount(), 0);
|
|
search_line->setText("io???new");
|
|
QCOMPARE(table_view->model()->rowCount(), 2);
|
|
|
|
// Check wildcard "*".
|
|
search_line->setText("io*new");
|
|
QCOMPARE(table_view->model()->rowCount(), 2);
|
|
search_line->setText("*");
|
|
QCOMPARE(table_view->model()->rowCount(), 3);
|
|
|
|
search_line->setText(preexisting_r_address);
|
|
QCOMPARE(table_view->model()->rowCount(), 0);
|
|
|
|
search_line->setText(preexisting_s_address);
|
|
QCOMPARE(table_view->model()->rowCount(), 1);
|
|
|
|
search_line->setText(new_address_a);
|
|
QCOMPARE(table_view->model()->rowCount(), 1);
|
|
|
|
search_line->setText(new_address_b);
|
|
QCOMPARE(table_view->model()->rowCount(), 1);
|
|
|
|
search_line->setText("");
|
|
QCOMPARE(table_view->model()->rowCount(), 3);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
void AddressBookTests::addressBookTests()
|
|
{
|
|
#ifdef Q_OS_MACOS
|
|
if (QApplication::platformName() == "minimal") {
|
|
// Disable for mac on "minimal" platform to avoid crashes inside the Qt
|
|
// framework when it tries to look up unimplemented cocoa functions,
|
|
// and fails to handle returned nulls
|
|
// (https://bugreports.qt.io/browse/QTBUG-49686).
|
|
QWARN("Skipping AddressBookTests on mac build with 'minimal' platform set due to Qt bugs. To run AppTests, invoke "
|
|
"with 'QT_QPA_PLATFORM=cocoa test_bitcoin-qt' on mac, or else use a linux or windows build.");
|
|
return;
|
|
}
|
|
#endif
|
|
TestAddAddressesToSendBook(m_node);
|
|
}
|