MarcoFalke 171f4a516b Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase ... d8e9ca66d1 walletdb: Move Rewrite into BerkeleyDatabase (Andrew Chow) 91d109156d walletdb: Move PeriodicFlush into WalletDatabase (Andrew Chow) 8f1bcf8b7b walletdb: Combine VerifyDatabaseFile and VerifyEnvironment (Andrew Chow) Pull request description: The `BerkeleyBatch` class has 4 static functions that operate on `BerkeleyDatabase` or `BerkeleyEnvironment`. It doesn't make sense for these to be standalone nor for them to be static functions. So instead, move them from `BerkeleyBatch` into `BerkeleyDatabase` and make them member functions instead of static. `BerkeleyBatch::VerifyEnvironment` and `BerkeleyBatch::VerifyDatabaseFile` are combined into a single `BerkeleyDatabase::Verify` function that operates on that `BerkeleyDatabase` object. `BerkeleyBatch::Rewrite` and `BerkeleyBatch::PeriodicFlush` both took a `BerkeleyDatabase` as an argument and did stuff on it. So we just make it a member function so it doesn't need to take a database as an argument. Part of #18971 ACKs for top commit: MarcoFalke: re-ACK d8e9ca66d1 only change is test fixup 🤞 promag: Code review ACK d8e9ca66d1, good stuff. Tree-SHA512: 9847e55b13d98bf4e5636cc14bc3f5351d56737f7e320fafffaed128606240765599e5400382c5aecac06690f7e36265ca3e1031f3f6d8a9688f6d5cb1bacd2a		2020-07-05 18:06:00 -04:00
..
test	Merge #19277: util: Add Assert identity function	2020-07-04 08:44:45 -04:00
bdb.cpp	Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase	2020-07-05 18:06:00 -04:00
bdb.h	Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase	2020-07-05 18:06:00 -04:00
coincontrol.cpp
coincontrol.h
coinselection.cpp
coinselection.h
context.cpp
context.h
crypter.cpp
crypter.h
db.cpp
db.h
feebumper.cpp
feebumper.h
fees.cpp
fees.h
init.cpp	scripted-diff: Move ui_interface to the node lib	2020-06-27 11:49:28 -04:00
ismine.h
load.cpp
load.h
rpcdump.cpp	Merge #19114: scripted-diff: TxoutType C++11 scoped enum class	2020-06-28 14:20:00 -04:00
rpcwallet.cpp	Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO	2020-07-02 16:10:49 +02:00
rpcwallet.h
salvage.cpp	walletdb: Combine VerifyDatabaseFile and VerifyEnvironment	2020-07-01 12:32:03 -04:00
salvage.h
scriptpubkeyman.cpp	Merge #19215: psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs	2020-07-03 09:23:22 +12:00
scriptpubkeyman.h	FillPSBT: report number of inputs signed (or would sign)	2020-06-18 23:32:59 -07:00
wallet.cpp	Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase	2020-07-05 18:06:00 -04:00
wallet.h	Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO	2020-07-02 16:10:49 +02:00
walletdb.cpp	Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase	2020-07-05 18:06:00 -04:00
walletdb.h
wallettool.cpp	walletdb: Combine VerifyDatabaseFile and VerifyEnvironment	2020-07-01 12:32:03 -04:00
wallettool.h
walletutil.cpp
walletutil.h