elements/src/test
MarcoFalke 80a699fda9
Merge #21525: [Bundle 4.5/n] Followup fixups to bundle 4
693414d271 node/ifaces: ChainImpl: Use an accessor for ChainMan (Carl Dong)
98c4e252f0 node/ifaces: NodeImpl: Use an accessor for ChainMan (Carl Dong)
7e8b5ee814 validation: Make BlockManager::LookupBlockIndex const (Carl Dong)
88aead263c node: Avoid potential UB by asserting assumptions (Carl Dong)
1dd8ed7a84 net_processing: Move comments to declarations (Carl Dong)
07156eb387 node/coinstats: Replace #include with fwd-declaration (Carl Dong)
7b8e976cd5 miner: Add chainstate member to BlockAssembler (Carl Dong)
e62067e7bc Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock" (Carl Dong)
eede0647b0 Revert "scripted-diff: Invoke CreateNewBlock with chainstate" (Carl Dong)
0c1b2bc549 Revert "miner: Remove old CreateNewBlock w/o chainstate param" (Carl Dong)

Pull request description:

  Chronological history of this changeset:
  1. Bundle 4 (#21270) got merged
  2. Posthumous reviews were posted
  3. These changes were prepended in bundle 5
  4. More reviews were added in bundle 5
  5. Someone suggested that we split the prepended changes up to another PR
  6. This is that PR

  In the future, I will just do posthumous review changes in another PR instead. I apologize for the confusion.

  Addresses posthumous reviews on bundle 4:
    - From jnewbery:
      - https://github.com/bitcoin/bitcoin/pull/21270#issuecomment-796738048
        - I didn't fix this one, but I added a `TODO` comment so that we don't lost track of it
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592291225
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592296942
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592299738
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592301704
    - From MarcoFalke:
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593096212
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593097032
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593097867
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593100570

  Addresses reviews on bundle 5:
  - Checking chainman existence before locking cs_main
    - MarcoFalke
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r596601776
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r596601876
  - Appropriate locking, usage of chainman, and control flow in `src/node/interfaces.cpp`
    - MarcoFalke
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r596601383
    - jnewbery
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597029360
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597029921
    - ryanofsky
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597163828
  - Style/comment formatting changes
    - jnewbery
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597026552
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597027186
  - Making LookupBlockIndex const
    - jnewbery
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597035062

ACKs for top commit:
  MarcoFalke:
    review ACK 693414d271 🛐
  ryanofsky:
    Code review ACK 693414d271. I reviewed this previously as part of #21391. I am a fan of the increasingly complicated bundle numbering, and kind of hope there in the next round there is some way we can get bundles 5.333333 and 5.666667!
  jamesob:
    ACK 693414d271 ([`jamesob/ackr/21525.1.dongcarl.bundle_4_5_n_followup_f`](https://github.com/jamesob/bitcoin/tree/ackr/21525.1.dongcarl.bundle_4_5_n_followup_f))

Tree-SHA512: 9bdc199f70400d01764e1bd03c25bdb6cff26dcef60e4ca3b649baf8d017a2dfc1f058099067962b4b6ccd32d078002b1389d733039f4c337558cb70324c0ee3
2021-04-01 10:58:53 +02:00
..
data Add signet support to gen_key_io_test_vectors.py 2021-03-16 10:48:40 -07:00
fuzz Merge #21553: fuzz: Misc refactor 2021-03-30 20:07:53 +02:00
util Merge #21525: [Bundle 4.5/n] Followup fixups to bundle 4 2021-04-01 10:58:53 +02:00
addrman_tests.cpp p2p, refactor: pass and use uint16_t CService::port as uint16_t 2021-03-16 19:52:31 +01:00
allocator_tests.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
amount_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
arith_uint256_tests.cpp
base32_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
base58_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
base64_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
bech32_tests.cpp Add Bech32m test vectors 2021-03-15 17:26:39 -07:00
bip32_tests.cpp
blockchain_tests.cpp
blockencodings_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
blockfilter_index_tests.cpp miner: Add chainstate member to BlockAssembler 2021-03-24 15:40:56 -04:00
blockfilter_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
bloom_tests.cpp Treat CDataStream bytes as uint8_t 2020-11-23 21:19:50 +01:00
bswap_tests.cpp test: remove qt byteswap compattests 2021-03-29 11:12:26 +08:00
checkqueue_tests.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
coins_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
compilerbug_tests.cpp
compress_tests.cpp test: Fix outstanding -Wsign-compare errors 2020-05-08 11:18:43 -07:00
crypto_tests.cpp test: Add MuHash3072 unit tests 2020-12-21 19:57:28 +01:00
cuckoocache_tests.cpp refactor: replace Boost shared_mutex with std shared_mutex in cuckoocache tests 2021-02-02 12:35:40 +08:00
dbwrapper_tests.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
denialofservice_tests.cpp [net] remove fUpdateConnectionTime from FinalizeNode 2021-03-22 10:25:39 +00:00
descriptor_tests.cpp refactor: post Optional<> removal cleanups 2021-03-17 14:56:20 +08:00
flatfile_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
fs_tests.cpp Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem. 2021-02-04 11:38:09 +01:00
getarg_tests.cpp scripted-diff: replace gArgs with argsman 2020-05-28 06:22:19 -07:00
hash_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
i2p_tests.cpp test: add I2P test for a runaway SAM proxy 2021-03-16 14:58:38 +01:00
interfaces_tests.cpp test: Remove no longer needed MakeChain calls 2020-12-07 20:46:03 -05:00
key_io_tests.cpp test: signet network selection tests 2020-09-18 10:19:42 +09:00
key_tests.cpp Fix length of R check in test/key_tests.cpp:key_signature_tests 2020-11-25 18:07:37 +05:00
logging_tests.cpp
main.cpp
Makefile
mempool_tests.cpp
merkle_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
merkleblock_tests.cpp
miner_tests.cpp miner: Add chainstate member to BlockAssembler 2021-03-24 15:40:56 -04:00
multisig_tests.cpp scripted-diff: TxoutType C++11 scoped enum class 2020-06-21 06:41:55 -04:00
net_peer_eviction_tests.cpp Add unit test coverage for our onion peer eviction protection 2021-03-19 20:13:11 +01:00
net_tests.cpp Merge #20197: p2p: protect onions in AttemptToEvictConnection(), add eviction protection test coverage 2021-03-30 16:20:47 +02:00
netbase_tests.cpp test: add missing netaddress include headers 2021-03-16 19:52:37 +01:00
pmt_tests.cpp
policy_fee_tests.cpp test: Add FeeFilterRounder test 2020-06-19 09:26:59 -04:00
policyestimator_tests.cpp
pow_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
prevector_tests.cpp
raii_event_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
random_tests.cpp Merge #18781: Add templated GetRandDuration<> 2020-05-15 08:58:49 -04:00
README.md
reverselock_tests.cpp sync: Improve CheckLastCritical() 2020-12-10 20:46:29 +02:00
rpc_tests.cpp refactor: replace util::Ref by std::any (C++17) 2021-03-29 23:29:42 +02:00
sanity_tests.cpp compat: remove memcpy -> memmove backwards compatibility alias 2021-03-10 14:31:10 +08:00
scheduler_tests.cpp refactor: remove boost::thread_group usage 2021-01-29 15:39:44 +08:00
script_p2sh_tests.cpp Only relay Taproot spends if next block has it active 2020-10-30 15:52:19 -07:00
script_standard_tests.cpp Merge #20211: Use -Wswitch for TxoutType where possible 2021-02-11 11:48:12 +01:00
script_tests.cpp test: Replace ARRAYLEN with C++11 ranged for loop 2020-10-26 14:27:33 +01:00
scriptnum10.h
scriptnum_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
serialize_tests.cpp Treat CDataStream bytes as uint8_t 2020-11-23 21:19:50 +01:00
settings_tests.cpp refactor: Make HexStr take a span 2020-08-06 19:41:43 +02:00
sighash_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
sigopcount_tests.cpp Replace usage of GetScriptForWitness with GetScriptForDestination 2020-08-14 08:44:42 +12:00
skiplist_tests.cpp
sock_tests.cpp test: add a test to ensure RecvUntilTerminator() limit works 2021-03-16 11:00:57 +01:00
streams_tests.cpp Merge #20464: refactor: Treat CDataStream bytes as uint8_t 2021-02-01 15:17:28 +01:00
sync_tests.cpp refactor: remove straggling boost::mutex usage 2021-01-26 15:57:28 +08:00
system_tests.cpp configure: add --enable-external-signer 2021-02-21 16:27:10 +01:00
timedata_tests.cpp Make GetWarnings() return bilingual_str 2020-06-10 15:01:20 +03:00
torcontrol_tests.cpp
transaction_tests.cpp test: Replace accidentally placed bit-OR with logical-OR 2021-02-24 12:57:03 +02:00
txindex_tests.cpp
txrequest_tests.cpp Report and verify expirations 2020-10-12 12:14:53 -07:00
txvalidation_tests.cpp scripted-diff: Invoke ::AcceptToMemoryPool with chainstate 2021-02-18 14:49:06 -05:00
txvalidationcache_tests.cpp Merge #21202: [validation] Two small clang lock annotation improvements 2021-02-22 09:47:15 +01:00
uint256_tests.cpp uint256: Update constructors to c++11, make ONE static 2020-09-28 12:14:19 +10:00
util_tests.cpp Merge #21317: util: Make Assume() usable as unary expression 2021-03-22 08:35:21 +01:00
util_threadnames_tests.cpp test: Set -logthreadnames in unit tests 2020-05-21 08:13:23 -04:00
validation_block_tests.cpp miner: Add chainstate member to BlockAssembler 2021-03-24 15:40:56 -04:00
validation_chainstate_tests.cpp sync: Use decltype(auto) return type for WITH_LOCK 2020-12-04 12:23:05 -05:00
validation_chainstatemanager_tests.cpp test: Add tests with maleated snapshot data 2021-02-12 07:53:40 -06:00
validation_flush_tests.cpp Pass mempool reference to chainstate constructor 2020-08-28 10:42:04 +02:00
validation_tests.cpp chainparams: add allowed assumeutxo values 2021-02-12 07:53:22 -06:00
validationinterface_tests.cpp test: Remove const to work around compiler error on xenial 2020-05-14 18:40:57 +02:00
versionbits_tests.cpp tests: check never active versionbits 2021-03-03 14:14:40 +01:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests -- DEBUG_LOG_OUT

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. The DEBUG_LOG_OUT after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdbor lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin