GlcoinCore/elements
1
0
Fork 0
mirror of https://github.com/ElementsProject/elements.git synced 2026-08-19 13:27:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
elements/src/wallet/test
History
Andrew Chow d71b0e78eb
Merge bitcoin/bitcoin#25966: test: Remove redundant test 
fb1c6c14c1 test: Remove redundant test (yancy)

Pull request description:

  I can't think of any reason to keep this test case around labeled [fix me](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L242).  The test was originally added [here](4566ab75f2) however there was never an assertion about the coins that should be selected, only that a solution is found (which is a redundant solution to the test [above](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L222)).  The comment was later added here to [fix](384273260a) it, however it's unclear what exactly it's testing.  A test was later added [here](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L366) where if the [long term fee](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L357) is less than the current [fee](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L356), then select fewer UTXOs, which may have been the original intent.

ACKs for top commit:
  S3RK:
    ACK fb1c6c14c1
  Zero-1729:
    Concept ACK fb1c6c14c1
  achow101:
    ACK fb1c6c14c1

Tree-SHA512: bce2cdae669c144ffaa130237a1643e3b6728e13d603cebf5d9493c4c7c68b3635868e4d93d210783c2ded2a871f185ca09a2053168c05b26a1e056ff6edf68f
2023-02-03 17:32:46 -05:00
..
fuzz scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
coinselector_tests.cpp Merge bitcoin/bitcoin#25966: test: Remove redundant test 2023-02-03 17:32:46 -05:00
db_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
feebumper_tests.cpp test: Remove unused txmempool include from tests 2022-10-18 14:02:09 +02:00
init_test_fixture.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
init_test_fixture.h Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
init_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
ismine_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
psbt_wallet_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
rpc_util_tests.cpp refactor: move Boost datetime usage to wallet 2022-10-01 11:41:53 +01:00
scriptpubkeyman_tests.cpp Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
spend_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
util.cpp Use DataStream where possible 2023-01-26 10:44:05 +01:00
util.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_crypto_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_test_fixture.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_test_fixture.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
wallet_tests.cpp Fix clang-tidy readability-const-return-type violations 2023-02-01 11:33:35 +01:00
wallet_transaction_tests.cpp Add src/wallet/* code to wallet:: namespace 2022-01-06 22:14:16 -05:00
walletdb_tests.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
walletload_tests.cpp Use DataStream where possible 2023-01-26 10:44:05 +01:00