Ryan Ofsky 16a6174613 Merge bitcoin/bitcoin#29904: refactor: Use our own implementation of urlDecode ... 992c714451 common: Don't terminate on null character in UrlDecode (Fabian Jahr) 099fa57151 scripted-diff: Modernize name of urlDecode function and param (Fabian Jahr) 8f39aaae41 refactor: Remove hooking code for urlDecode (Fabian Jahr) 650d43ec15 refactor: Replace libevent use in urlDecode with our own code (Fabian Jahr) 46bc6c2aaa test: Add unit tests for urlDecode (Fabian Jahr) Pull request description: Fixes #29654 (as a side-effect) Removing dependencies is a general goal of the project and the xz backdoor has been an additional wake up call recently. Libevent shows many of the same symptoms, few maintainers and slow releases. While libevent can not be removed completely over night we should start removing it’s usage where it's possible, ideally with the end goal to removing it completely. This is a pretty easy win in that direction. The [`evhttp_uridecode` function from libevent](e0a4574ba2/http.c (L3542)) we were using in `urlDecode` could be easily emulated in fewer LOC. This also ports the [applicable test vectors over from libevent](https://github.com/libevent/libevent/blob/master/test/regress_http.c#L3430). ACKs for top commit: achow101: ACK 992c714451 theStack: Code-review ACK 992c714451 maflcko: ACK 992c714451 👈 stickies-v: ACK 992c714451 Tree-SHA512: 78f76ae7ab3b6710eab2aaac20f55eb0da7803e057eaa6220e865f328666a5399ef1a479702aaf630b2f974ad3aa15e2b6adac9c11bc8c3d4be21e8af1667fea		2024-04-25 13:02:43 -04:00
..
args.cpp	[init] Create deterministic addrman in tests using -test=addrman	2024-01-08 21:54:56 +05:30
args.h	[init] Add new command line arg for use only in functional tests	2024-01-08 21:54:55 +05:30
bloom.cpp	Use Txid in COutpoint	2023-11-21 13:15:44 +00:00
bloom.h
config.cpp	scripted-diff: move settings to common namespace	2023-05-30 17:26:51 +02:00
init.cpp	Merge bitcoin/bitcoin#27302: init: Error if ignored bitcoin.conf file is found	2023-05-26 13:33:42 +01:00
init.h	Deduplicate bitcoind and bitcoin-qt init code	2023-02-28 12:04:47 -05:00
interfaces.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
run_command.cpp	refactor: Rename subprocess.hpp to follow our header name conventions	2024-04-23 18:22:58 +01:00
run_command.h	refactor: move run_command from util to common	2022-10-04 21:21:05 +00:00
settings.cpp	init: settings, do not load auto-generated warning msg	2024-01-23 21:01:32 -03:00
settings.h	scripted-diff: move settings to common namespace	2023-05-30 17:26:51 +02:00
system.cpp	scripted-diff: Fix bitcoin_config_h includes	2024-02-13 20:10:44 +00:00
system.h	Merge bitcoin/bitcoin#28486: test, bench: Initialize and terminate use of Winsock properly	2023-11-29 17:14:34 +00:00
url.cpp	common: Don't terminate on null character in UrlDecode	2024-04-24 23:27:50 +02:00
url.h	scripted-diff: Modernize name of urlDecode function and param	2024-04-24 23:26:24 +02:00