mirror of
https://github.com/ElementsProject/elements.git
synced 2026-08-20 13:37:28 +02:00
466e4df3fbassert_mempool_contents: assert not duplicates expected (Greg Sanders)ea5db2f269functional: only generate required blocks for test (Greg Sanders)d033acb608fuzz: package_eval: let fuzzer run out input in main tx creation loop (Greg Sanders)ba35a570c5CheckEphemeralSpends: return boolean, and set child state and txid outparams (Greg Sanders)cf0cee1617func: add note about lack of 1P1C propagation in tree submitpackage (Greg Sanders)8424290304unit test: ephemeral_tests is using a dust relay rate, not minrelay (Greg Sanders)d9cfa5fc4eCheckEphemeralSpends: no need to iterate inputs if no parent dust (Greg Sanders)87b26e3dc0func: rename test_free_relay to test_no_minrelay_fee (Greg Sanders)e5709a4a41func: slight elaboration on submitpackage restriction (Greg Sanders)08e969bd10RPC: only enforce dust rules on priority when standardness active (Greg Sanders)ca050d12e7unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX (Greg Sanders)7c3490169cfuzz: package_eval: move last_tx inside txn ctor (Greg Sanders)445eaed182fuzz: use optional status instead of should_rbf_eph_spend (Greg Sanders)4dfdf615b9fuzz: remove unused TransactionsDelta validation interface (Greg Sanders)09ce926e4afunc: cleanup reorg test comment (Greg Sanders)768a0c1889func: cleanup test_dustrelay comments (Greg Sanders)bedca1cb66fuzz: Directly place transactions in vector (Greg Sanders)c041ad6eccfuzz: explain package eval coin tracking better (Greg Sanders)bc0d98ea61fuzz: remove dangling reference to GetEntry (Greg Sanders)15b6cbf07funit test: make dust index less magical (Greg Sanders)5fbcfd12b8unit test: assert txid returned on CheckEphemeralSpends failures (Greg Sanders)ef94d84b4ebench: remove unnecessary CMTxn constructors (Greg Sanders)c5c10fd317ephemeral policy doxygen cleanup (Greg Sanders)dd9044b8d4ephemeral policy: IWYU (Greg Sanders)c6859ce2deMove+rename GetDustIndexes -> GetDust (Greg Sanders)62016b3230Use std::ranges for ephemeral policy checks (Greg Sanders)3ed930a1f4Have HasDust and PreCheckValidEphemeralTx take CTransaction (Greg Sanders)04a614bf9aRename CheckValidEphemeralTx to PreCheckEphemeralTx (Greg Sanders)cbf1a47d60CheckEphemeralSpends: only compute txid of tx when needed (Greg Sanders) Pull request description: Follow-up to https://github.com/bitcoin/bitcoin/pull/30239 Here are the parent PR's comments that should be addressed by this PR: https://github.com/bitcoin/bitcoin/pull/30239/files#r1834529646 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831247308 https://github.com/bitcoin/bitcoin/pull/30239/files#r1832622481 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831195216 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834639096 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834624976 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834619709 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834610434 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834504436 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834500036 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832985488 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830929809 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832376920 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832755799 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832492686 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832980576 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832784278 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1837989979 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830996993 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830997947 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830012890 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830037288 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830977092 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832622481 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834726168 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832453654 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848488226 ACKs for top commit: naumenkogs: ACK466e4df3fbhodlinator: ACK466e4df3fbtheStack: lgtm ACK466e4df3fbglozow: utACK466e4df3fbTree-SHA512: 89106f695755c238b84e0996b89446c0733e10a94c867f656d516d26697d2efe38dfc332188b8589a0a26a3d2bd2c88c6ab70c108e187ce5bfcb91bbf3fb0391
87 lines
2.5 KiB
C++
87 lines
2.5 KiB
C++
// Copyright (c) 2011-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <bench/bench.h>
|
|
#include <consensus/amount.h>
|
|
#include <kernel/cs_main.h>
|
|
#include <policy/ephemeral_policy.h>
|
|
#include <policy/policy.h>
|
|
#include <primitives/transaction.h>
|
|
#include <script/script.h>
|
|
#include <sync.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <test/util/txmempool.h>
|
|
#include <txmempool.h>
|
|
#include <util/check.h>
|
|
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
|
|
static void AddTx(const CTransactionRef& tx, CTxMemPool& pool) EXCLUSIVE_LOCKS_REQUIRED(cs_main, pool.cs)
|
|
{
|
|
int64_t nTime{0};
|
|
unsigned int nHeight{1};
|
|
uint64_t sequence{0};
|
|
bool spendsCoinbase{false};
|
|
unsigned int sigOpCost{4};
|
|
uint64_t fee{0};
|
|
LockPoints lp;
|
|
AddToMempool(pool, CTxMemPoolEntry(
|
|
tx, fee, nTime, nHeight, sequence,
|
|
spendsCoinbase, sigOpCost, lp));
|
|
}
|
|
|
|
static void MempoolCheckEphemeralSpends(benchmark::Bench& bench)
|
|
{
|
|
const auto testing_setup = MakeNoLogFileContext<const TestingSetup>();
|
|
|
|
int number_outputs{1000};
|
|
if (bench.complexityN() > 1) {
|
|
number_outputs = static_cast<int>(bench.complexityN());
|
|
}
|
|
|
|
// Tx with many outputs
|
|
CMutableTransaction tx1;
|
|
tx1.vin.resize(1);
|
|
tx1.vout.resize(number_outputs);
|
|
for (size_t i = 0; i < tx1.vout.size(); i++) {
|
|
tx1.vout[i].scriptPubKey = CScript();
|
|
// Each output progressively larger
|
|
tx1.vout[i].nValue = i * CENT;
|
|
}
|
|
|
|
const auto& parent_txid = tx1.GetHash();
|
|
|
|
// Spends all outputs of tx1, other details don't matter
|
|
CMutableTransaction tx2;
|
|
tx2.vin.resize(tx1.vout.size());
|
|
for (size_t i = 0; i < tx2.vin.size(); i++) {
|
|
tx2.vin[0].prevout.hash = parent_txid;
|
|
tx2.vin[0].prevout.n = i;
|
|
}
|
|
tx2.vout.resize(1);
|
|
|
|
CTxMemPool& pool = *Assert(testing_setup->m_node.mempool);
|
|
LOCK2(cs_main, pool.cs);
|
|
// Create transaction references outside the "hot loop"
|
|
const CTransactionRef tx1_r{MakeTransactionRef(tx1)};
|
|
const CTransactionRef tx2_r{MakeTransactionRef(tx2)};
|
|
|
|
AddTx(tx1_r, pool);
|
|
|
|
uint32_t iteration{0};
|
|
|
|
TxValidationState dummy_state;
|
|
Txid dummy_txid;
|
|
|
|
bench.run([&]() NO_THREAD_SAFETY_ANALYSIS {
|
|
|
|
CheckEphemeralSpends({tx2_r}, /*dust_relay_rate=*/CFeeRate(iteration * COIN / 10), pool, dummy_state, dummy_txid);
|
|
iteration++;
|
|
});
|
|
}
|
|
|
|
BENCHMARK(MempoolCheckEphemeralSpends, benchmark::PriorityLevel::HIGH);
|