Ryan Ofsky 5cd0717a54 streams: Drop confusing DataStream::Serialize method and << operator ... DataStream Serialize method has surprising behavior because it just serializes raw bytes without a length prefix. When you serialize a string or vector, a length prefix is serialized before the raw object contents so the object can be unambiguously deserialized later. But DataStreams don't support deserializing at all and just dump the raw bytes. Having this inconsistency is not necessary and could be confusing (see https://github.com/bitcoin/bitcoin/pull/27790#discussion_r1212315030) so this PR just drops the DataStream::Serialize method.		2023-06-01 10:27:33 -04:00
..
bench	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
common	Merge bitcoin/bitcoin#27636: kernel: Remove util/system from kernel library, interface_ui from validation.	2023-05-30 14:57:22 +01:00
compat	refactor: don't avoid sys/types.h on when building for Windows	2023-04-03 14:44:48 +01:00
config
consensus	Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uint256.*	2023-02-06 13:56:51 -05:00
crc32c	Update crc32c subtree to latest upstream master	2022-08-13 13:55:38 +01:00
crypto	scripted-diff: Use platform-agnostic ALWAYS_INLINE macro	2023-05-04 20:58:01 +01:00
index	index: prevent race by calling 'CustomInit' prior setting 'synced' flag	2023-05-22 12:56:16 -03:00
init	move-only: Extract common/args and common/config.cpp from util/system	2023-04-19 10:48:30 +02:00
interfaces	wallet: skip block scan if block was created before wallet birthday	2023-05-25 10:45:38 -03:00
ipc	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
kernel	Merge bitcoin/bitcoin#27774: refactor: Add [[nodiscard]] where ignoring a Result return type is an error	2023-05-30 15:32:19 +01:00
leveldb	Update leveldb-subtree subtree to latest upstream	2022-09-29 16:43:30 +01:00
logging	Use steady clock for logging timer	2023-01-31 18:48:50 +01:00
minisketch	Update minisketch subtree to latest upstream	2022-10-23 15:03:04 +01:00
node	Merge bitcoin/bitcoin#27774: refactor: Add [[nodiscard]] where ignoring a Result return type is an error	2023-05-30 15:32:19 +01:00
policy	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
primitives	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
qt	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
rpc	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
script	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
secp256k1	Update src/secp256k1 to latest upstream master (v0.3.1 + CI fix)	2023-04-14 10:35:51 -04:00
support	Add pool based memory resource & allocator	2023-03-23 19:38:38 +01:00
test	Merge bitcoin/bitcoin#27780: fuzz: Avoid timeout in utxo_total_supply	2023-05-31 11:24:57 +01:00
univalue	Remove unused find_value global function	2023-05-09 18:48:10 +02:00
util	Merge bitcoin/bitcoin#27636: kernel: Remove util/system from kernel library, interface_ui from validation.	2023-05-30 14:57:22 +01:00
wallet	streams: Drop confusing DataStream::Serialize method and << operator	2023-06-01 10:27:33 -04:00
zmq	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
.bear-tidy-config	tidy: enable modernize-use-nullptr	2022-04-26 10:43:33 +01:00
.clang-format
.clang-tidy	clang-tidy: Exclude performance-* checks rather including them	2023-03-26 20:18:13 +01:00
addrdb.cpp	Add [[nodiscard]] where ignoring a Result return type is an error	2023-05-29 13:12:45 +02:00
addrdb.h	fix includes for touched header files (iwyu)	2023-05-29 13:26:31 +02:00
addrman.cpp	addrman: add functionality to select by network	2023-03-17 17:59:02 -07:00
addrman.h	doc: clarify new_only param for Select function	2023-03-17 18:02:40 -07:00
addrman_impl.h	addrman: add functionality to select by network	2023-03-17 17:59:02 -07:00
arith_uint256.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
arith_uint256.h	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
attributes.h	Introduce platform-agnostic ALWAYS_INLINE macro	2023-05-04 20:57:51 +01:00
banman.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
banman.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
base58.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
base58.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bech32.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
bech32.h
bitcoin-chainstate.cpp	Merge bitcoin/bitcoin#27636: kernel: Remove util/system from kernel library, interface_ui from validation.	2023-05-30 14:57:22 +01:00
bitcoin-cli-res.rc
bitcoin-cli.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoin-tx-res.rc
bitcoin-tx.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoin-util-res.rc
bitcoin-util.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
bitcoind-res.rc
bitcoind.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
blockencodings.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
blockencodings.h	script: remove out-of-date snprintf TODO	2023-02-15 14:42:28 -08:00
blockfilter.cpp	refactor: use Hash helper for double-SHA256 calculations	2023-01-31 19:34:35 +01:00
blockfilter.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chain.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
chain.h	refactor: add kernel/cs_main.*	2023-01-05 09:05:14 +00:00
chainparams.cpp	test: Throw error when -signetchallenge is non-hex	2023-05-25 19:24:05 +02:00
chainparams.h	test: Throw error when -signetchallenge is non-hex	2023-05-25 19:24:05 +02:00
chainparamsbase.cpp	refactor: Use ChainType enum exhaustively	2023-05-10 10:39:58 +02:00
chainparamsbase.h	refactor: Use ChainType enum exhaustively	2023-05-10 10:39:58 +02:00
chainparamsseeds.h	p2p: update hardcoded mainnet seeds for 25.x	2023-04-20 06:08:22 -07:00
checkqueue.h	refactor: Use move semantics in CCheckQueue::Loop	2023-03-21 13:04:21 +00:00
clientversion.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
clientversion.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
coins.cpp	Use PoolAllocator for CCoinsMap	2023-03-23 19:38:38 +01:00
coins.h	Use PoolAllocator for CCoinsMap	2023-03-23 19:38:38 +01:00
compressor.cpp
compressor.h
core_io.h	rpc: decode Miniscript descriptor when possible in decodescript	2023-02-03 18:15:42 +01:00
core_memusage.h
core_read.cpp	Use DataStream where possible	2023-01-26 10:44:05 +01:00
core_write.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
cuckoocache.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
dbwrapper.cpp	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
dbwrapper.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
deploymentinfo.cpp	Decouple RegTestChainParams from ArgsManager	2023-03-15 16:42:42 +01:00
deploymentinfo.h	Decouple RegTestChainParams from ArgsManager	2023-03-15 16:42:42 +01:00
deploymentstatus.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
deploymentstatus.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
dummywallet.cpp	move-only: Extract common/args and common/config.cpp from util/system	2023-04-19 10:48:30 +02:00
external_signer.cpp	Fix clang-tidy performance-unnecessary-copy-initialization warnings	2023-05-09 18:48:52 +02:00
external_signer.h	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
flatfile.cpp	refactor: Extract util/fs_helpers from util/system	2023-03-23 12:52:00 +01:00
flatfile.h	Merge bitcoin/bitcoin#27254: refactor: Extract util/fs from util/system	2023-04-03 14:41:22 +01:00
hash.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
hash.h	Merge bitcoin/bitcoin#26649: refactor: Use AutoFile and HashVerifier (without ser-type and ser-version) where possible	2023-01-30 15:57:12 +00:00
headerssync.cpp	[headerssync] Make m_commit_offset protected	2022-12-12 21:06:04 +00:00
headerssync.h	[headerssync] Make m_commit_offset protected	2022-12-12 21:06:04 +00:00
httprpc.cpp	scripted-diff: Use UniValue::find_value method	2023-05-09 18:47:14 +02:00
httprpc.h
httpserver.cpp	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
httpserver.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
i2p.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
i2p.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
indirectmap.h
init.cpp	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
init.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
key.cpp	refactor: use Hash helper for double-SHA256 calculations	2023-01-31 19:34:35 +01:00
key.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
key_io.cpp	use 'byte'/'bytes' for bech32(m) validation error	2023-05-25 06:30:10 +00:00
key_io.h
logging.cpp	Merge bitcoin/bitcoin#27317: log: Check that the timestamp string is non-empty to avoid undefined behavior	2023-04-05 11:50:27 +01:00
logging.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
Makefile.am	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
Makefile.bench.include	[bench] add streams findbyte	2023-05-05 06:03:14 -06:00
Makefile.crc32c.include	build: Create .la library for crc32c	2022-04-26 16:25:38 -04:00
Makefile.leveldb.include	Use more specific path when including memenv.h header	2022-06-23 15:33:01 +02:00
Makefile.minisketch.include	build: Build minisketch test in make check, not in make	2022-07-21 10:42:09 +01:00
Makefile.qt.include	Build: Log when test -f fails in Makefile	2023-02-03 22:33:14 +01:00
Makefile.qt_locale.include	qt: Periodic translation updates from Transifex	2023-02-27 13:53:29 +00:00
Makefile.qttest.include	build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)	2022-09-13 17:15:17 +01:00
Makefile.test.include	Merge bitcoin/bitcoin#27021: Implement Mini version of BlockAssembler to calculate mining scores	2023-05-19 10:26:19 -04:00
Makefile.test_fuzz.include	[fuzz] Move ConsumeNetAddr to fuzz/util/net.h	2022-11-17 14:52:45 +00:00
Makefile.test_util.include	Add pool based memory resource & allocator	2023-03-23 19:38:38 +01:00
Makefile.univalue.include
mapport.cpp	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
mapport.h	Remove configure-time setting of DEFAULT_UPNP	2023-01-28 15:24:13 +00:00
memusage.h	Calculate memory usage correctly for unordered_maps that use PoolAllocator	2023-03-23 19:38:38 +01:00
merkleblock.cpp
merkleblock.h
net.cpp	p2p, refactor: return vector/optional<CService> in Lookup	2023-05-26 13:40:02 -03:00
net.h	Support up to 3 parallel compact block txn fetchings	2023-05-23 13:07:49 -04:00
net_permissions.cpp	Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost	2023-05-30 11:39:59 -04:00
net_permissions.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_processing.cpp	streams: Drop confusing DataStream::Serialize method and << operator	2023-06-01 10:27:33 -04:00
net_processing.h	Support up to 3 parallel compact block txn fetchings	2023-05-23 13:07:49 -04:00
net_types.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
net_types.h
netaddress.cpp	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
netaddress.h	Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming	2023-02-17 13:34:40 -05:00
netbase.cpp	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
netbase.h	p2p, refactor: return std::optional<CNetAddr> in LookupHost	2023-05-26 13:41:07 -03:00
netgroup.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
netgroup.h	[netgroupman] Remove NetGroupManager::GetAsmap()	2022-04-20 14:35:53 +01:00
netmessagemaker.h
noui.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
noui.h
outputtype.cpp	Don't return OutputType::UNKNOWN in ParseOutputType	2023-04-16 23:48:05 +02:00
outputtype.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pow.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
pow.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
prevector.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
protocol.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
protocol.h	doc: Remove unused NO_BLOOM_VERSION constant	2023-05-15 10:18:58 +02:00
psbt.cpp	Merge bitcoin/bitcoin#25939: rpc: In utxoupdatepsbt also look for the tx in the txindex	2023-04-21 14:06:12 -04:00
psbt.h	Merge bitcoin/bitcoin#25939: rpc: In utxoupdatepsbt also look for the tx in the txindex	2023-04-21 14:06:12 -04:00
pubkey.cpp	Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0	2023-01-13 09:40:57 +00:00
pubkey.h	Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0	2023-01-13 09:40:57 +00:00
random.cpp	random: switch to using getrandom() directly	2023-05-20 17:20:01 +01:00
random.h	Merge bitcoin/bitcoin#26153: Reduce wasted pseudorandom bytes in ChaCha20 + various improvements	2023-02-15 14:58:47 +00:00
randomenv.cpp	refactor: don't avoid sys/types.h on when building for Windows	2023-04-03 14:44:48 +01:00
randomenv.h
rest.cpp	refactor: Split util::AnyPtr into its own file	2023-05-20 12:03:33 +02:00
rest.h	Handle query string when parsing data format	2022-03-10 12:01:53 +01:00
reverse_iterator.h	doc: remove usages of C++11	2023-01-12 13:42:44 +00:00
scheduler.cpp	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
scheduler.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
serialize.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
shutdown.cpp	Add InitError(error, details) overload	2023-02-28 12:04:47 -05:00
shutdown.h
signet.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
signet.h
span.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
streams.h	streams: Drop confusing DataStream::Serialize method and << operator	2023-06-01 10:27:33 -04:00
sync.cpp
sync.h	doc: Export threadsafety.h from sync.h	2023-01-25 09:33:26 +01:00
threadsafety.h
timedata.cpp	move-only: Extract common/args and common/config.cpp from util/system	2023-04-19 10:48:30 +02:00
timedata.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
tinyformat.h	clang-tidy: Fix modernize-use-default-member-init in headers	2023-01-31 11:50:10 +00:00
torcontrol.cpp	p2p, refactor: return vector/optional<CService> in Lookup	2023-05-26 13:40:02 -03:00
torcontrol.h	refactor: Move fs.* to util/fs.*	2023-03-23 12:55:18 +01:00
txdb.cpp	refactor: Replace std::optional<bilingual_str> with util::Result	2023-05-24 08:55:47 -04:00
txdb.h	fix includes for touched header files (iwyu)	2023-05-29 13:26:31 +02:00
txmempool.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
txmempool.h	[mempool] find connected mempool entries with GatherClusters(…)	2023-03-27 17:35:12 -04:00
txorphanage.cpp	Merge bitcoin/bitcoin#26551: p2p: Track orphans by who provided them	2023-01-26 10:36:18 +00:00
txorphanage.h	Merge bitcoin/bitcoin#26551: p2p: Track orphans by who provided them	2023-01-26 10:36:18 +00:00
txrequest.cpp	build: Bump minimum supported GCC to g++-9	2023-05-18 12:24:40 +02:00
txrequest.h
uint256.cpp	refactor: modernize the implementation of uint256.*	2022-12-10 14:34:44 -06:00
uint256.h	Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uint256.*	2023-02-06 13:56:51 -05:00
undo.h
validation.cpp	Merge bitcoin/bitcoin#27636: kernel: Remove util/system from kernel library, interface_ui from validation.	2023-05-30 14:57:22 +01:00
validation.h	kernel: Add progress method to notifications	2023-05-20 12:03:26 +02:00
validationinterface.cpp	Fix clang-tidy readability-const-return-type violations	2023-02-01 11:33:35 +01:00
validationinterface.h	refactor: add kernel/cs_main.*	2023-01-05 09:05:14 +00:00
version.h	doc: Remove unused NO_BLOOM_VERSION constant	2023-05-15 10:18:58 +02:00
versionbits.cpp	refactor: use braced init for integer constants instead of c style casts	2023-01-03 19:31:29 -06:00
versionbits.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
walletinitinterface.h	scripted-diff: Bump copyright headers	2022-12-24 23:49:50 +00:00
warnings.cpp	refactor: Move system from util to common library	2023-05-20 12:08:13 +02:00
warnings.h