elements/src/test
Wladimir J. van der Laan 564385f4bf
Merge #14094: refactoring: Remove unreferenced local variables
8ecaee13f7 Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4 (12 is assuming the changes in #14086 are also implemented). (practicalswift)

Pull request description:

  Remove unreferenced local variables:

  Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4. 12 is the number of MSVC warnings under our current appveyor setup assuming the changes in #14086 are also implemented.

  This makes it easier to spot errors or more important warnings in the verbose appveyor output. MSVC warnings are good, so having access to them in a noise free way (read: without trivial warnings) via appveyor without having to use Windows is really valuable.

  See https://github.com/bitcoin/bitcoin/pull/14086#issuecomment-416610313 plus discussion for context.

  Before:

  ```
  c:\projects\bitcoin\src\script\script.cpp(272): warning C4018: '>': signed/unsigned mismatch [C:\projects\bitcoin\build_msvc\libbitcoinconsensus\libbitcoinconsensus.vcxproj]
  c:\projects\bitcoin\src\rest.cpp(467): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\libbitcoin_server\libbitcoin_server.vcxproj]
  c:\projects\bitcoin\src\test\allocator_tests.cpp(147): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\coins_tests.cpp(511): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\coins_tests.cpp(524): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\coins_tests.cpp(722): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\coins_tests.cpp(783): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\crypto_tests.cpp(535): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\dbwrapper_tests.cpp(265): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\net_tests.cpp(118): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\net_tests.cpp(151): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\scheduler_tests.cpp(57): warning C4305: 'argument': truncation from 'int' to 'bool' [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  ```

  After:

  ```
  c:\projects\bitcoin\src\script\script.cpp(272): warning C4018: '>': signed/unsigned mismatch [C:\projects\bitcoin\build_msvc\libbitcoinconsensus\libbitcoinconsensus.vcxproj]
  c:\projects\bitcoin\src\test\allocator_tests.cpp(147): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\crypto_tests.cpp(535): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  c:\projects\bitcoin\src\test\scheduler_tests.cpp(57): warning C4305: 'argument': truncation from 'int' to 'bool' [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
  ```

Tree-SHA512: 5051134126c570b8421d57c710f1f1b977600398d2b5e69f8a8bd766b3696f992bf4e3459643b99a6b7e08dee1adc92985ee4d0d52b20755954415cb6f23f2fb
2018-09-04 12:44:49 +02:00
..
data blockfilter: Omit empty scripts from filter contents. 2018-08-28 12:12:32 -07:00
addrman_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
allocator_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
amount_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
arith_uint256_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
base32_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
base58_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
base64_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
bech32_tests.cpp Merge #12881: Minor optimizations to bech32::Decode(); add tests. 2018-05-15 12:10:34 +02:00
bip32_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
blockchain_tests.cpp Use bracket syntax includes ("#include <foo.h>") 2018-06-06 11:09:05 +02:00
blockencodings_tests.cpp Merge #13792: tx pool: Avoid passing redundant hash into addUnchecked (scripted-diff) 2018-08-29 16:30:58 +02:00
blockfilter_tests.cpp blockfilter: Omit empty scripts from filter contents. 2018-08-28 12:12:32 -07:00
bloom_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
bswap_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
checkqueue_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
coins_tests.cpp Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4 (12 is assuming the changes in #14086 are also implemented). 2018-09-03 19:53:56 +02:00
compress_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
crypto_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
cuckoocache_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
dbwrapper_tests.cpp Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4 (12 is assuming the changes in #14086 are also implemented). 2018-09-03 19:53:56 +02:00
denialofservice_tests.cpp tests: Add missing locking annotations and locks 2018-08-30 16:36:26 +02:00
descriptor_tests.cpp Remove unused variable 2018-08-02 14:30:59 +02:00
getarg_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
hash_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
key_io_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
key_tests.cpp Merge #13666: Always create signatures with Low R values 2018-08-13 12:07:20 +02:00
limitedmap_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
main_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
Makefile build: add stub makefiles for easier subdir builds 2014-06-05 16:05:43 -04:00
mempool_tests.cpp Merge #13792: tx pool: Avoid passing redundant hash into addUnchecked (scripted-diff) 2018-08-29 16:30:58 +02:00
merkle_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
merkleblock_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
miner_tests.cpp Merge #13792: tx pool: Avoid passing redundant hash into addUnchecked (scripted-diff) 2018-08-29 16:30:58 +02:00
multisig_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
net_tests.cpp Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4 (12 is assuming the changes in #14086 are also implemented). 2018-09-03 19:53:56 +02:00
netbase_tests.cpp Implements ParseNetwork unit test. 2018-08-28 18:37:34 +02:00
pmt_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
policyestimator_tests.cpp Merge #13792: tx pool: Avoid passing redundant hash into addUnchecked (scripted-diff) 2018-08-29 16:30:58 +02:00
pow_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
prevector_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
raii_event_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
random_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
README.md scripted-diff: Remove trailing whitespaces 2018-07-24 20:46:23 +01:00
reverselock_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
rpc_tests.cpp Replace median fee rate with feerate percentiles 2018-08-11 15:00:17 -04:00
sanity_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
scheduler_tests.cpp Merge #14088: tests: Don't assert(...) with side effects 2018-08-31 15:00:15 +02:00
script_p2sh_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
script_standard_tests.cpp Merge #13429: Return the script type from Solver 2018-08-25 17:41:00 +02:00
script_tests.cpp Merge #13767: Remove redundant assignments (dead stores) 2018-08-27 13:39:46 -04:00
scriptnum10.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
scriptnum_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
serialize_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
sighash_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
sigopcount_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
skiplist_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
streams_tests.cpp streams: Unit tests for BitStreamReader and BitStreamWriter. 2018-08-25 10:02:37 -07:00
sync_tests.cpp scripted-diff: Small locking rename 2018-08-31 10:00:38 -04:00
test_bitcoin.cpp util: Replace boost::signals2 with std::function 2018-08-24 08:34:38 -04:00
test_bitcoin.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
test_bitcoin_fuzzy.cpp util: Replace boost::signals2 with std::function 2018-08-24 08:34:38 -04:00
test_bitcoin_main.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
timedata_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
torcontrol_tests.cpp Declare TorReply parsing functions in torcontrol_tests 2018-05-21 10:53:18 -07:00
transaction_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
txindex_tests.cpp qa: Stop txindex thread before calling destructor 2018-08-26 10:18:06 -04:00
txvalidation_tests.cpp Don't assert(foo()) where foo has side effects 2018-07-07 10:08:49 +02:00
txvalidationcache_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
uint256_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
util_tests.cpp Implements custom tolower and toupper functions. 2018-08-28 18:42:27 +02:00
validation_block_tests.cpp Mark single-argument constructors "explicit" 2018-07-26 17:15:32 +02:00
versionbits_tests.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the bitcoind tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the bitcoind tests.

To add more bitcoind tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the bitcoin-qt tests manually, launch src/qt/test/test_bitcoin-qt

To add more bitcoin-qt tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Note on adding test cases

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since bitcoin already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is setup to compile an executable called test_bitcoin that runs all of the unit tests. The main source file is called test_bitcoin.cpp. To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, examine uint256_tests.cpp.

For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.