53a75ebbae
This causes crash on elements wallet when dealing with transactions that have explicit values and confidential assets. This creates a somewhat serious DoS attack as the sender can cause the reciever's wallet to crash by partially blinding the change output. To make matters worse, the wallet initially accepts the transaction, but fails while spending the output. This is likely caused by a combination of two bugs: 1) The wallet's current behaviour stores the complete transaction of interest in CWalletTx instead of just Outpoints. Only that the spend time do we iterate over all outputs, try to unblind them and check which are isMine. When calling wtx.GetOutputValueOut() or similar calls, we hit this assertion. While the current behaviour is okay, I think the correct way is move the IsMine == ISMINE_NO at the start of the loop. We should not do be any checks on outputs that are not ours. This is used in multiple places at different parts of the codebase for different RPCs. 2) When dealing with partially blinded trasactions, ComputeBlindingData correctly sets value = -1, and the cache byte to 1. When getting the data again with GetBlindingData for explicit value and confidential asset, we load the precomputed data with value = -1 and assert the loaded value be the explicit value in the transaction. This is only true for explicit value and explicit asset. The changed assertion checks that written value should be same as the explicit value that was written only when the amounts are valid |
||
|---|---|---|
| .github | ||
| .tx | ||
| build-aux/m4 | ||
| build_msvc | ||
| ci | ||
| contrib | ||
| depends | ||
| doc | ||
| share | ||
| src | ||
| test | ||
| .appveyor.yml | ||
| .cirrus.yml | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .python-version | ||
| .style.yapf | ||
| autogen.sh | ||
| configure.ac | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| INSTALL.md | ||
| libbitcoinconsensus.pc.in | ||
| Makefile.am | ||
| README.md | ||
| REVIEWERS | ||
| SECURITY.md | ||
Elements Project blockchain platform
This is the integration and staging tree for the Elements blockchain platform, a collection of feature experiments and extensions to the Bitcoin protocol. This platform enables anyone to build their own businesses or networks pegged to Bitcoin as a sidechain or run as a standalone blockchain with arbitrary asset tokens.
Modes
Elements supports a few different pre-set chains for syncing. Note though some are intended for QA and debugging only:
- Liquid mode:
elementsd -chain=liquidv1(syncs with Liquid network) - Bitcoin mainnet mode:
elementsd -chain=main(not intended to be run for commerce) - Bitcoin testnet mode:
elementsd -chain=testnet3 - Bitcoin regtest mode:
elementsd -chain=regtest - Elements custom chains: Any other
-chain=argument. It has regtest-like default parameters that can be over-ridden by the user by a rich set of start-up options.
Confidential Assets
The latest feature in the Elements blockchain platform is Confidential Assets, the ability to issue multiple assets on a blockchain where asset identifiers and amounts are blinded yet auditable through the use of applied cryptography.
- Announcement of Confidential Assets
- Confidential Assets Whitepaper to be presented April 7th at Financial Cryptography 2017 in Malta
- Confidential Assets Tutorial
- Confidential Assets Demo
- Elements Code Tutorial covering blockchain configuration and how to use the main features.
Features of the Elements blockchain platform
Compared to Bitcoin itself, it adds the following features:
- Confidential Assets
- Confidential Transactions
- Federated Two-Way Peg
- Signed Blocks
- Additional opcodes
Previous elements that have been integrated into Bitcoin:
- Segregated Witness
- Relative Lock Time
Elements deferred for additional research and standardization:
Additional RPC commands and parameters:
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
License
Elements is released under the terms of the MIT license. See COPYING for more information or see http://opensource.org/licenses/MIT.
What is the Elements Project?
Elements is an open source, sidechain-capable blockchain platform. It also allows experiments to more rapidly bring technical innovation to the Bitcoin ecosystem.
Learn more on the Elements Project website
https://github.com/ElementsProject/elementsproject.github.io