fanquake 4f5d3ce5a0 Merge bitcoin/bitcoin#24486: wallet: refactor: dedup sqlite blob binding ... 8ea6167099 wallet: refactor: dedup sqlite blob binding (Sebastian Falbesoner) Pull request description: This refactoring PR deduplicates repeated SQLite blob binding to a statement with a newly introduced helper function `BindBlobToStatement`, abstracting away the calls to `sqlite3_bind_blob(...)`. This should be more readable and less error-prone, e.g. in case that the error handling has to be adapted. As a slight drawback, the function where the binding happens is not printed anymore (`__func__`), i.e. one could argue this is not strictly a refactoring, but IMHO the advantages of deduplication outweigh this; binding errors are purely internal logic errors (wrong use of the sqlite API) rather than something that is dependend on external data like DB content. ACKs for top commit: laanwj: Code review ACK 8ea6167099 achow101: ACK 8ea6167099 klementtan: ACK 8ea6167099 Tree-SHA512: 1de0d214f836bc405a01e98a3a2d71f2deaddc7d23c31cad80219d1614bec92619c06d9a4a091dd563d3e95ffb879649c29745d8f89669b2a5330552c212af3f		2022-03-10 12:40:20 +00:00
..
rpc	Merge bitcoin/bitcoin#24198: wallet, rpc: add wtxid in WalletTxToJSON	2022-03-08 14:32:10 -05:00
test	blockstorage: Make m_block_index own CBlockIndex's	2022-02-22 11:52:19 -05:00
bdb.cpp	refactor: replace boost::filesystem with std::filesystem	2022-02-03 18:35:52 +08:00
bdb.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
coincontrol.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
coincontrol.h	wallet: add input weights to CCoinControl	2022-01-24 11:23:31 -05:00
coinselection.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
coinselection.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
context.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
context.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
crypter.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
db.cpp	refactor: replace boost::filesystem with std::filesystem	2022-02-03 18:35:52 +08:00
db.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
dump.cpp	refactor: replace boost::filesystem with std::filesystem	2022-02-03 18:35:52 +08:00
dump.h	refactor: replace boost::filesystem with std::filesystem	2022-02-03 18:35:52 +08:00
external_signer_scriptpubkeyman.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
external_signer_scriptpubkeyman.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
feebumper.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
feebumper.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
fees.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
fees.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
init.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
interfaces.cpp	interfaces: Remove unused is_final	2022-01-14 11:28:45 +01:00
ismine.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
load.cpp	Use ArgsManager::GetPathArg() for "-walletdir" option	2022-02-09 19:31:23 +02:00
load.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
receive.cpp	wallet: Avoid dropping confirmed coins	2022-01-25 10:15:12 +01:00
receive.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
salvage.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
salvage.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
scriptpubkeyman.cpp	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
scriptpubkeyman.h	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
spend.cpp	User-facing content fixups from transifex translator feedback	2022-02-17 12:59:30 +01:00
spend.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
sqlite.cpp	wallet: refactor: dedup sqlite blob binding	2022-03-06 20:43:16 +01:00
sqlite.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
transaction.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
transaction.h	wallet: add GetWitnessHash()	2022-02-01 08:44:51 -03:00
wallet.cpp	Merge bitcoin/bitcoin#24401: wallet: Add external-signer-support specific error message	2022-02-23 17:19:49 -05:00
wallet.h	wallet: Allow user specified input size to override	2022-01-24 11:23:31 -05:00
walletdb.cpp	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
walletdb.h	Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places	2022-03-02 09:35:07 +01:00
wallettool.cpp	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
wallettool.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00
walletutil.cpp	Use ArgsManager::GetPathArg() for "-walletdir" option	2022-02-09 19:31:23 +02:00
walletutil.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00