GlcoinCore/elements
1
0
Fork 0
mirror of https://github.com/ElementsProject/elements.git synced 2026-08-14 12:43:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
elements/src/wallet/test
History
MarcoFalke 5ec19df687
Merge #19277: util: Add Assert identity function 
fab80fef61 refactor: Remove unused EnsureChainman (MarcoFalke)
fa34587f1c scripted-diff: Replace EnsureChainman with Assert in unit tests (MarcoFalke)
fa6ef701ad util: Add Assert identity function (MarcoFalke)
fa457fbd33 move-only: Move NDEBUG compile time check to util/check (MarcoFalke)

Pull request description:

  The utility function is primarily useful to dereference pointer types, which are known to be not null at that time.

  For example, the ArgsManager is known to exist when the wallets are started: https://github.com/bitcoin/bitcoin/pull/18923/files#diff-fdb2a1a1d8bc790fcddeb6cf5a42ac55R503 . Instead of silently relying on that assumption, `Assert` can be used to abort the program and avoid UB should the assumption ever be violated.

ACKs for top commit:
  promag:
    Tested ACK fab80fef61.
  ryanofsky:
    Code review ACK fab80fef61

Tree-SHA512: 830fba10152ba17d47c4dd42809c7e26f9fe6d38e17a2d5b3f054fd644a5c4c9841286ac421ec9bb28cea9f5faeb659740fcf00de6cc589d423fee7694c42d16
2020-07-04 08:44:45 -04:00
..
coinselector_tests.cpp scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase 2020-06-17 14:12:41 -04:00
db_tests.cpp walletdb: Move BDB specific things into bdb.{cpp/h} 2020-06-15 20:41:05 -04:00
init_test_fixture.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
init_test_fixture.h test: Avoid overwriting the NodeContext member of the testing setup 2020-06-06 09:50:32 -04:00
init_tests.cpp scripted-diff: test: Move setup_common to test library 2019-11-06 11:56:41 -05:00
ismine_tests.cpp Convert CPubKey to WitnessV0KeyHash directly 2020-06-19 12:14:07 -07:00
psbt_wallet_tests.cpp psbt: always put a non_witness_utxo and don't remove it 2020-06-24 16:32:19 -04:00
scriptpubkeyman_tests.cpp scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase 2020-06-17 14:12:41 -04:00
wallet_crypto_tests.cpp refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o) 2020-06-24 18:41:45 +02:00
wallet_test_fixture.cpp scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase 2020-06-17 14:12:41 -04:00
wallet_test_fixture.h test: Avoid overwriting the NodeContext member of the testing setup 2020-06-06 09:50:32 -04:00
wallet_tests.cpp Merge #19277: util: Add Assert identity function 2020-07-04 08:44:45 -04:00