GlcoinCore/elements
1
0
Fork 0
mirror of https://github.com/ElementsProject/elements.git synced 2026-08-16 13:01:19 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
elements/src/common
History
fanquake 9564f98fee
Merge bitcoin/bitcoin#27636: kernel: Remove util/system from kernel library, interface_ui from validation. 
7d3b35004b refactor: Move system from util to common library (TheCharlatan)
7eee356c0a refactor: Split util::AnyPtr into its own file (TheCharlatan)
44de325d95 refactor: Split util::insert into its own file (TheCharlatan)
9ec5da36b6 refactor: Move ScheduleBatchPriority to its own file (TheCharlatan)
f871c69191 kernel: Add warning method to notifications (TheCharlatan)
4452707ede kernel: Add progress method to notifications (TheCharlatan)
84d71457e7 kernel: Add headerTip method to notifications (TheCharlatan)
447761c822 kernel: Add notification interface (TheCharlatan)

Pull request description:

  This pull request is part of the `libbitcoinkernel` project https://github.com/bitcoin/bitcoin/issues/27587 https://github.com/bitcoin/bitcoin/projects/18 and more specifically its "Step 2: Decouple most non-consensus code from libbitcoinkernel".

  ---

  It removes the kernel library's dependency on `util/system` and `interface_ui`. `util/system` contains networking and shell-related code that should not be part of the kernel library. The following pull requests prepared `util/system` for this final step: https://github.com/bitcoin/bitcoin/pull/27419 https://github.com/bitcoin/bitcoin/pull/27254 https://github.com/bitcoin/bitcoin/pull/27238.

  `interface_ui` defines functions for a more general node interface and has a dependency on `boost/signals2`. After applying the patches from this pull request, the kernel's reliance on boost is down to `boost::multiindex`.

  The approach implemented here introduces some indirection, which makes the code a bit harder to read. Any suggestions for improving or reworking this pull request to make it more concise, or even reworking it into a more proper interface, are appreciated.

ACKs for top commit:
  MarcoFalke:
    re-ACK 7d3b35004b (no change) 🎋
  stickies-v:
    Code Review ACK 7d3b35004b
  hebasto:
    re-ACK 7d3b35004b, only last two commits dropped since my [recent](https://github.com/bitcoin/bitcoin/pull/27636#pullrequestreview-1435394620) review.

Tree-SHA512: c8cfc698dc9d78e20191c444708f2d957501229abe95e5806106d1126fb9c5fbcee686fb55645658c0107ce71f10646f37a2fdf7fde16bbf22cbf1ac885dd08d
2023-05-30 14:57:22 +01:00
..
args.cpp Merge bitcoin/bitcoin#27302: init: Error if ignored bitcoin.conf file is found 2023-05-26 13:33:42 +01:00
args.h Merge bitcoin/bitcoin#27302: init: Error if ignored bitcoin.conf file is found 2023-05-26 13:33:42 +01:00
bloom.cpp Use DataStream where possible 2023-01-26 10:44:05 +01:00
bloom.h scripted-diff: Bump copyright headers 2021-12-30 19:36:57 +02:00
config.cpp Merge bitcoin/bitcoin#27302: init: Error if ignored bitcoin.conf file is found 2023-05-26 13:33:42 +01:00
init.cpp Merge bitcoin/bitcoin#27302: init: Error if ignored bitcoin.conf file is found 2023-05-26 13:33:42 +01:00
init.h Deduplicate bitcoind and bitcoin-qt init code 2023-02-28 12:04:47 -05:00
interfaces.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
run_command.cpp refactor: move run_command from util to common 2022-10-04 21:21:05 +00:00
run_command.h refactor: move run_command from util to common 2022-10-04 21:21:05 +00:00
system.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
system.h refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
url.cpp scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00
url.h scripted-diff: Bump copyright headers 2022-12-24 23:49:50 +00:00