Added a method testPeginClaimAcceptance to interfaces::CChain. It is not clear to me that this is meaningfully different from the existing method broadcastTransaction (with the `relay` flag set to false so it doesn't actually broadcast), except that this method returns the TxValidationState, which we display to the user in the RPC error. Worth revisiting this. Another nonobvious change was replacing a block of mempool-searching logic in wallet/rpcwallet.cpp with the single line `pwallet->chain().findCoins(coins)`. This I stole from the current state of upstream #17211, our favorite in-progress PR from which the original logic came. |
||
|---|---|---|
| .. | ||
| chain.cpp | ||
| chain.h | ||
| handler.cpp | ||
| handler.h | ||
| node.cpp | ||
| node.h | ||
| README.md | ||
| wallet.cpp | ||
| wallet.h | ||
Internal c++ interfaces
The following interfaces are defined here:
-
Chain— used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973. -
ChainClient— used by node to start & stopChainclients. Added in #14437. -
Node— used by GUI to start & stop bitcoin node. Added in #10244. -
Handler— returned byhandleEventmethods on interfaces above and used to manage lifetimes of event handlers. -
Init— used by multiprocess code to access interfaces above on startup. Added in #10102.
The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.