elements/src/script
Ava Chow 228aba2c4d
Merge bitcoin/bitcoin#31555: descriptor: remove unreachable verification for pkh
366ae00b77 descriptor: Assume `ParseScript` is not being called with a P2WPKH context (brunoerg)
e366408590 descriptor: remove unreachable verification for `pkh` (brunoerg)

Pull request description:

  This PR removes an unreachable verification in the `ParseScript` function. It returns an error if `pkh` is not being used at top level, sh, wsh or tr. However, any usage of `pkh` without these contexts will not reach this verification but other ones like "invalid keys" (e.g. `wpkh(pkh(L4gM1FBdyHNpkzsFh9ipnofLhpZRp2mwobpeULy1a6dBTvw8Ywtd))`).

ACKs for top commit:
  davidgumberg:
    crACK 366ae00b77
  achow101:
    ACK 366ae00b77
  tdb3:
    cr ACK 366ae00b77
  sipa:
    crACK 366ae00b77

Tree-SHA512: b954221a77eed623aeed5eb54f14e82c49540a151d3388831924caa7a784e48a2a975e418af1e13d491e4f8cded3b1797aa39e0e4e39e302a991105df09cdec0
2024-12-30 16:40:11 -05:00
..
descriptor.cpp descriptor: Assume ParseScript is not being called with a P2WPKH context 2024-12-24 11:01:47 -03:00
descriptor.h descriptors: Change Parse to return vector of descriptors 2024-08-08 12:47:22 -04:00
interpreter.cpp Fix unsigned integer overflows in interpreter 2024-10-01 10:45:44 +02:00
interpreter.h interpreter: Use the same type for SignatureHash in the definition 2024-11-25 15:36:05 +01:00
keyorigin.h Implement operator< for KeyOriginInfo and CExtPubKey 2021-12-10 08:29:47 -05:00
miniscript.cpp refactor: Drop deprecated space in operator""_mst 2024-11-11 12:14:08 +01:00
miniscript.h refactor: Avoid passing span iterators when data pointers are expected 2024-12-19 14:39:55 +01:00
parsing.cpp util: move spanparsing.h to script/parsing.h 2024-05-16 10:16:08 -05:00
parsing.h util: move spanparsing.h to script/parsing.h 2024-05-16 10:16:08 -05:00
script.cpp policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
script.h Allow CScript's operator<< to accept spans, not just vectors 2024-09-11 17:41:27 +02:00
script_error.cpp Implement Tapscript script validation rules (BIP 342) 2020-10-12 17:18:24 -07:00
script_error.h scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
sigcache.cpp kernel: De-globalize signature cache 2024-07-05 09:03:04 +02:00
sigcache.h kernel: De-globalize signature cache 2024-07-05 09:03:04 +02:00
sign.cpp refactor: move SignSignature helpers to test utils 2024-09-04 21:06:09 +02:00
sign.h refactor: move SignSignature helpers to test utils 2024-09-04 21:06:09 +02:00
signingprovider.cpp ci: Bump TIDY_LLVM_V 2024-03-15 13:34:05 +00:00
signingprovider.h tidy: modernize-use-equals-default 2024-07-08 11:12:01 +02:00
solver.cpp policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
solver.h refactor: Replace fwd-decl with proper include 2024-12-19 13:46:43 +01:00