Changes API for AcceptToMemoryPool to no longer check maximum fee; we remove this check from interfaces::CChain::testPeginClaimAcceptance. This is fine, the check never should have been there (this method's job is to notice double claim attempts and provide a more helpful message to the user; other mempool failures should be caught later in the `claimrawpegin` logic when we call `pwallet->commitTransaction` which actually subits to the mempool). It was only checking fees because the API made it easier to do so than to not. |
||
|---|---|---|
| .. | ||
| chain.cpp | ||
| chain.h | ||
| handler.cpp | ||
| handler.h | ||
| node.cpp | ||
| node.h | ||
| README.md | ||
| wallet.cpp | ||
| wallet.h | ||
Internal c++ interfaces
The following interfaces are defined here:
-
Chain— used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973. -
ChainClient— used by node to start & stopChainclients. Added in #14437. -
Node— used by GUI to start & stop bitcoin node. Added in #10244. -
Handler— returned byhandleEventmethods on interfaces above and used to manage lifetimes of event handlers. -
Init— used by multiprocess code to access interfaces above on startup. Added in #10102.
The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.