mirror of
https://github.com/ElementsProject/elements.git
synced 2026-08-20 13:37:28 +02:00
07c59eda00
Affects both secure_allocator and zero_after_free_allocator. Giving the C++ Standard Committee control of the public interface of your type means they will break it. C++23 adds a new `allocate_at_least` member to `std::allocator`. Very bad things happen when, say, `std::vector` uses `allocate_at_least` from `secure_allocator`'s base to allocate memory which it then tries to free with `secure_allocator::deallocate`. Drive-by: Aggressively remove facilities unnecessary since C++11 from both allocators to keep things simple.
60 lines
1.7 KiB
C++
60 lines
1.7 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2021 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_SUPPORT_ALLOCATORS_SECURE_H
|
|
#define BITCOIN_SUPPORT_ALLOCATORS_SECURE_H
|
|
|
|
#include <support/lockedpool.h>
|
|
#include <support/cleanse.h>
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
//
|
|
// Allocator that locks its contents from being paged
|
|
// out of memory and clears its contents before deletion.
|
|
//
|
|
template <typename T>
|
|
struct secure_allocator {
|
|
using value_type = T;
|
|
|
|
secure_allocator() = default;
|
|
template <typename U>
|
|
secure_allocator(const secure_allocator<U>&) noexcept {}
|
|
|
|
T* allocate(std::size_t n)
|
|
{
|
|
T* allocation = static_cast<T*>(LockedPoolManager::Instance().alloc(sizeof(T) * n));
|
|
if (!allocation) {
|
|
throw std::bad_alloc();
|
|
}
|
|
return allocation;
|
|
}
|
|
|
|
void deallocate(T* p, std::size_t n)
|
|
{
|
|
if (p != nullptr) {
|
|
memory_cleanse(p, sizeof(T) * n);
|
|
}
|
|
LockedPoolManager::Instance().free(p);
|
|
}
|
|
|
|
template <typename U>
|
|
friend bool operator==(const secure_allocator&, const secure_allocator<U>&) noexcept
|
|
{
|
|
return true;
|
|
}
|
|
template <typename U>
|
|
friend bool operator!=(const secure_allocator&, const secure_allocator<U>&) noexcept
|
|
{
|
|
return false;
|
|
}
|
|
};
|
|
|
|
// This is exactly like std::string, but with a custom allocator.
|
|
// TODO: Consider finding a way to make incoming RPC request.params[i] mlock()ed as well
|
|
typedef std::basic_string<char, std::char_traits<char>, secure_allocator<char> > SecureString;
|
|
|
|
#endif // BITCOIN_SUPPORT_ALLOCATORS_SECURE_H
|