Ava Chow 85f96b01b7 Merge bitcoin/bitcoin#30909: wallet, assumeutxo: Don't Assume m_chain_tx_count, Improve wallet RPC errors ... 9d2d9f7ce2 rpc: Include assumeutxo as a failure reason of rescanblockchain (Fabian Jahr) 595edee169 test, assumeutxo: import descriptors during background sync (Alfonso Roman Zubeldia) d73ae603d4 rpc: Improve importdescriptor RPC error messages (Fabian Jahr) 27f99b6d63 validation: Don't assume m_chain_tx_count in GuessVerificationProgress (Fabian Jahr) 42d5d53363 interfaces: Add helper function for wallet on pruning (Fabian Jahr) Pull request description: A test that is added as part of #30455 uncovered this issue: The `GuessVerificationProgress` function is used during during descriptor import and relies on `m_chain_tx_count`. In #29370 an [`Assume` was added](https://github.com/bitcoin/bitcoin/pull/29370/commits/0fd915ee6bef63bb360ccc5c039a3c11676c38e3) expecting the `m_chaint_tx_count` to be set. However, as the test uncovered, `GuessVerificationProgress` is called with background sync blocks that have `m_chaint_tx_count = 0` when they have not been downloaded and processed yet. The simple fix is to remove the `Assume`. Users should not be thrown off by the `Internal bug detected` error. The behavior of `importdescriptor` is kept consistent with the behavior for blocks missing due to pruning. The test by alfonsoromanz is cherry-picked here to show that the [CI errors](https://cirrus-ci.com/task/5110045812195328?logs=ci#L2535) should be fixed by this change. This PR also improves error messages returned by the `importdescriptors` and `rescanblockchain` RPCs. The error message now changes depending on the situation of the node, i.e. if pruning is happening or an assumutxo backgroundsync is active. ACKs for top commit: achow101: ACK 9d2d9f7ce2 mzumsande: Code Review ACK 9d2d9f7ce2 furszy: Code review ACK 9d2d9f7ce2 Tree-SHA512: b841a9b371e5eb8eb3bfebca35645ff2fdded7a3e5e06308d46a33a51ca42cc4c258028c9958fbbb6cda9bb990e07ab8d8504dd9ec6705ef78afe0435912b365		2025-01-31 15:45:14 -05:00
..
addresses.cpp	scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h	2024-10-10 12:22:12 +02:00
backup.cpp	Merge bitcoin/bitcoin#30909: wallet, assumeutxo: Don't Assume m_chain_tx_count, Improve wallet RPC errors	2025-01-31 15:45:14 -05:00
coins.cpp	doc: rpc: Use "output script" consistently (2/2)	2024-07-25 16:36:08 +02:00
encrypt.cpp	rpc, doc: encryptwallet, mention HD seed rotation and new backup	2023-12-05 18:46:58 -03:00
signmessage.cpp	util: move util/message to common/signmessage	2024-05-16 11:16:08 -04:00
spend.cpp	Merge bitcoin/bitcoin#30844: RPC: improve SFFO arg parsing, error catching and coverage	2025-01-29 16:33:13 -05:00
transactions.cpp	rpc: Include assumeutxo as a failure reason of rescanblockchain	2025-01-05 17:28:34 +01:00
util.cpp	Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead	2024-12-02 15:09:31 +01:00
util.h	Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead	2024-12-02 15:09:31 +01:00
wallet.cpp	scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h	2024-10-10 12:22:12 +02:00
wallet.h	Add src/wallet/* code to wallet:: namespace	2022-01-06 22:14:16 -05:00