elements/src/test
glozow 2aff9a36c3
Merge bitcoin/bitcoin#30352: policy: Add PayToAnchor(P2A), OP_1 <0x4e73> as a standard output script for spending
75648cea5a test: add P2A ProduceSignature coverage (Greg Sanders)
7998ce6b20 Add release note for P2A output feature (Greg Sanders)
71c9b02a04 test: add P2A coverage for decodescript (Greg Sanders)
1349e9ec15 test: Add anchor mempool acceptance test (Greg Sanders)
9d89209937 policy: stop 3rd party wtxid malleability of anchor spend (Greg Sanders)
b60aaf8b23 policy: make anchor spend standard (Greg Sanders)
455fca86cf policy: Add OP_1 <0x4e73> as a standard output type (Greg Sanders)

Pull request description:

  This is a sub-feature taken out of the original proposal for ephemeral anchors #30239

  This PR makes *spending* of `OP_1 <0x4e73>` (i.e. `bc1pfeessrawgf`) standard. Creation of this output type is already standard.

  Any future witness output types are considered relay-standard to create, but not to spend. This preserves upgrade hooks, such as a completely new output type for a softfork such as BIP341.  It also gives us a bit of room to use a new output type for policy uses.

  This particular sized witness program has no other known use-cases (https://bitcoin.stackexchange.com/a/110664/17078), s it affords insufficient cryptographic security for a secure commitment to data, such as a script or a public key. This makes this type of output "keyless", or unauthenticated.

  As a witness program, the `scriptSig` of the input MUST be blank, by BIP141. This helps ensure txid-stability of the spending transaction, which may be required for smart contracting wallets. If we do not use segwit, a miner can simply insert an `OP_NOP` in the `scriptSig` without effecting the result of program execution.

  An additional relay restriction is to disallow non-empty witness data, which an adversary may use to penalize the "honest" transactor when RBF'ing the transaction due to the incremental fee requirement of RBF rules.

  The intended use-case for this output type is to "anchor" the transaction with a spending child to bring exogenous CPFP fees into the transaction package, encouraging the inclusion of the package in a block. The minimal size of creation and spending of this output makes it an attractive contrast to outputs like `p2sh(OP_TRUE)` and `p2wsh(OP_TRUE)` which
  are significantly larger in vbyte terms.

  Combined with TRUC transactions which limits the size of child transactions significantly, this is an attractive option for presigned transactions that need to be fee-bumped after the fact.

ACKs for top commit:
  sdaftuar:
    utACK 75648cea5a
  theStack:
    re-ACK 75648cea5a
  ismaelsadeeq:
    re-ACK 75648cea5a via [diff](e7ce6dc070..75648cea5a)
  glozow:
    ACK 75648cea5a
  tdb3:
    ACK 75648cea5a

Tree-SHA512: d529de23d20857e6cdb40fa611d0446b49989eaafed06c28280e8fd1897f1ed8d89a4eabbec1bbf8df3d319910066c3dbbba5a70a87ff0b2967d5205db32ad1e
2024-08-02 15:49:44 +01:00
..
data refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
fuzz Merge bitcoin/bitcoin#30352: policy: Add PayToAnchor(P2A), OP_1 <0x4e73> as a standard output script for spending 2024-08-02 15:49:44 +01:00
util [fuzz] Harness for version handshake 2024-07-31 13:25:52 +01:00
.gitignore test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
addrman_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
allocator_tests.cpp refactor: Move system from util to common library 2023-05-20 12:08:13 +02:00
amount_tests.cpp test: Add tests for CFeeRate multiplication operator 2023-12-11 16:27:58 -05:00
argsman_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
arith_uint256_tests.cpp refactor: Remove unused and fragile string interface from arith_uint256 2023-11-21 17:37:25 +01:00
banman_tests.cpp
base32_tests.cpp
base58_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
base64_tests.cpp
bech32_tests.cpp
bip32_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
bip324_tests.cpp crypto: Spanify EllSwiftPubKey constructor 2023-09-07 08:53:45 -04:00
blockchain_tests.cpp Merge bitcoin/bitcoin#29668: prune, rpc: Check undo data when finding pruneheight 2024-07-10 15:27:05 -04:00
blockencodings_tests.cpp test: Make blockencodings_tests deterministic 2024-06-19 22:56:30 +01:00
blockfilter_index_tests.cpp Always pass options to BlockAssembler constructor 2024-06-18 18:47:51 +02:00
blockfilter_tests.cpp refactor: Replace ParseHashStr with FromHex 2024-07-24 17:40:18 +02:00
blockmanager_tests.cpp Merge bitcoin/bitcoin#29668: prune, rpc: Check undo data when finding pruneheight 2024-07-10 15:27:05 -04:00
bloom_tests.cpp refactor: remove TxidFromString 2024-07-31 16:47:39 +01:00
bswap_tests.cpp serialization: detect byteswap builtins without autoconf tests 2024-02-28 13:42:38 +00:00
checkqueue_tests.cpp test: [refactor] Pass TestOpts 2024-07-08 16:11:15 +02:00
cluster_linearize_tests.cpp tests: framework for testing DepGraph class 2024-07-25 10:16:37 -04:00
coins_tests.cpp tests: overhaul deterministic test randomness 2024-07-01 10:26:46 -04:00
coinstatsindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
common_url_tests.cpp test: Add two more urlDecode tests 2024-04-26 08:33:56 +02:00
compilerbug_tests.cpp
compress_tests.cpp test: add script compression coverage for not-on-curve P2PK outputs 2024-01-22 13:38:48 +01:00
crypto_tests.cpp random: add RandomMixin::randbits with compile-known bits 2024-07-01 10:26:46 -04:00
cuckoocache_tests.cpp random: cleanup order, comments, static 2024-07-01 12:39:57 -04:00
dbwrapper_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
denialofservice_tests.cpp Merge bitcoin/bitcoin#29575: net_processing: make any misbehavior trigger immediate discouragement 2024-06-20 13:28:38 -04:00
descriptor_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
disconnected_transactions.cpp [test] DisconnectedBlockTransactions::DynamicMemoryUsage 2023-10-19 16:14:36 +01:00
feefrac_tests.cpp Avoid explicitly computing diagram; compare based on chunks 2024-04-22 09:36:36 -04:00
flatfile_tests.cpp serialize: Drop useless version param from GetSerializeSize() 2023-11-16 11:14:13 +10:00
fs_tests.cpp Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup 2023-12-14 16:46:54 -05:00
getarg_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
hash_tests.cpp refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
headers_sync_chainwork_tests.cpp tidy: modernize-use-emplace 2023-10-12 11:27:19 +02:00
httpserver_tests.cpp bugfix: rest: avoid segfault for invalid URI 2023-04-17 10:13:34 -03:00
i2p_tests.cpp test: [refactor] Pass TestOpts 2024-07-08 16:11:15 +02:00
interfaces_tests.cpp Rename script/standard.{cpp/h} to script/solver.{cpp/h} 2023-08-14 17:39:49 -04:00
ipc_test.capnp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.cpp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.h multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_tests.cpp test: add ipc test to test multiprocess type conversion code 2023-11-28 12:35:50 -05:00
key_io_tests.cpp Remove unused raw-pointer read helper from univalue 2023-07-27 14:24:52 +02:00
key_tests.cpp Merge bitcoin/bitcoin#29015: kernel: Streamline util library 2024-06-12 17:12:54 -04:00
logging_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
main.cpp test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-07 10:11:45 -07:00
Makefile
mempool_tests.cpp refactor: Drop util::Result operator= 2024-04-25 16:08:24 -04:00
merkle_tests.cpp
merkleblock_tests.cpp refactor: remove TxidFromString 2024-07-31 16:47:39 +01:00
miner_tests.cpp Merge bitcoin/bitcoin#29325: consensus: Store transaction nVersion as uint32_t 2024-06-12 10:32:31 +01:00
miniminer_tests.cpp Use Txid in COutpoint 2023-11-21 13:15:44 +00:00
miniscript_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
minisketch_tests.cpp
multisig_tests.cpp
net_peer_connection_tests.cpp test: [refactor] Pass TestOpts 2024-07-08 16:11:15 +02:00
net_peer_eviction_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
net_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
netbase_tests.cpp Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections 2024-02-28 10:05:56 -03:00
node_warnings_tests.cpp introduce and use the generalized node::Warnings interface 2024-06-13 11:20:48 +01:00
orphanage_tests.cpp remove obsoleted TxOrphanage::m_mutex 2024-07-16 10:21:41 +01:00
peerman_tests.cpp Always pass options to BlockAssembler constructor 2024-06-18 18:47:51 +02:00
pmt_tests.cpp Remove unused version.h include 2023-11-30 11:28:19 +01:00
policy_fee_tests.cpp [net processing] FeeFilterRounder doesn't own a FastRandomContext 2023-10-04 13:16:52 +01:00
policyestimator_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
pool_tests.cpp pool: change memusage_test to use int64_t, add allocation check 2023-11-20 17:10:34 +01:00
pow_tests.cpp test: refactor: Replace SetHex with uint256 constructor directly 2024-07-24 09:14:57 +02:00
prevector_tests.cpp random: replace construct/assign with explicit Reseed() 2024-07-01 12:39:57 -04:00
raii_event_tests.cpp
random_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
rbf_tests.cpp Avoid explicitly computing diagram; compare based on chunks 2024-04-22 09:36:36 -04:00
README.md Merge bitcoin/bitcoin#26564: test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-11 07:03:02 -04:00
rest_tests.cpp
result_tests.cpp
reverselock_tests.cpp
rpc_tests.cpp Merge bitcoin/bitcoin#29015: kernel: Streamline util library 2024-06-12 17:12:54 -04:00
sanity_tests.cpp Revert "time: add runtime sanity check" 2024-03-18 16:01:08 +01:00
scheduler_tests.cpp scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner 2024-02-15 14:43:14 +01:00
script_p2sh_tests.cpp kernel: De-globalize signature cache 2024-07-05 09:03:04 +02:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp policy: Add OP_1 <0x4e73> as a standard output type 2024-07-30 14:06:58 -04:00
script_tests.cpp test: add P2A ProduceSignature coverage 2024-07-30 14:06:58 -04:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp serfloat: improve/simplify tests 2024-02-20 11:33:32 +00:00
serialize_tests.cpp serialization: Add ParamsStream GetStream() method 2024-02-21 07:35:38 -05:00
settings_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
sighash_tests.cpp refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
sigopcount_tests.cpp refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
skiplist_tests.cpp
sock_tests.cpp test: improve sock_tests/move_assignment 2023-08-28 14:32:17 +02:00
span_tests.cpp Fix CI-detected codespell warnings 2024-02-23 23:01:07 +01:00
streams_tests.cpp tests: overhaul deterministic test randomness 2024-07-01 10:26:46 -04:00
sync_tests.cpp
system_tests.cpp scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes 2024-05-01 08:33:04 +02:00
timeoffsets_tests.cpp refactor: remove warnings globals 2024-06-13 11:20:49 +01:00
torcontrol_tests.cpp
transaction_tests.cpp Merge bitcoin/bitcoin#30352: policy: Add PayToAnchor(P2A), OP_1 <0x4e73> as a standard output script for spending 2024-08-02 15:49:44 +01:00
translation_tests.cpp
txindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
txpackage_tests.cpp refactor: remove TxidFromString 2024-07-31 16:47:39 +01:00
txreconciliation_tests.cpp
txrequest_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
txvalidation_tests.cpp use version=3 instead of v3 in debug strings 2024-07-02 12:20:12 +01:00
txvalidationcache_tests.cpp Merge bitcoin/bitcoin#30407: test: [refactor] Pass TestOpts 2024-07-15 17:21:55 +01:00
uint256_tests.cpp test: add uint256::FromHex unittest coverage 2024-07-31 16:47:37 +01:00
util_tests.cpp Merge bitcoin/bitcoin#30386: Early logging improvements 2024-07-26 08:06:08 -04:00
util_threadnames_tests.cpp Merge bitcoin/bitcoin#29015: kernel: Streamline util library 2024-06-12 17:12:54 -04:00
validation_block_tests.cpp Always pass options to BlockAssembler constructor 2024-06-18 18:47:51 +02:00
validation_chainstate_tests.cpp refactor, test: Always initialize pointer 2024-05-02 23:10:05 +01:00
validation_chainstatemanager_tests.cpp test: [refactor] Pass TestOpts 2024-07-08 16:11:15 +02:00
validation_flush_tests.cpp
validation_tests.cpp test: removes unnecessary check from validation_tests 2024-02-29 09:54:47 -05:00
validationinterface_tests.cpp scripted-diff: Rename MainSignals to ValidationSignals 2024-02-15 14:45:51 +01:00
versionbits_tests.cpp doc: fix typos 2023-11-07 10:21:51 +09:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check, which includes unit tests from subtrees, or make && make -C src check-unit for just the unit tests.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example.

test_bitcoin also accepts some of the command line arguments accepted by bitcoind. Use -- to separate these sets of arguments:

test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes sends debug logging, which normally goes only to debug.log within the data directory, also to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

test_bitcoin creates a temporary working (data) directory with a randomly generated pathname within test_common_Bitcoin Core/, which in turn is within the system's temporary directory (see temp_directory_path). This data directory looks like a simplified form of the standard bitcoind data directory. Its content will vary depending on the test, but it will always have a debug.log file, for example.

The location of the temporary data directory can be specified with the -testdatadir option. This can make debugging easier. The directory path used is the argument path appended with /test_common_Bitcoin Core/<test-name>/datadir. The directory path is created if necessary. Specifying this argument also causes the data directory not to be removed after the last test. This is useful for looking at what the test wrote to debug.log after it completes, for example. (The directory is removed at the start of the next test run, so no leftover state is used.)

$ test_bitcoin --run_test=getarg_tests/doubledash -- -testdatadir=/somewhere/mydatadir
Test directory (will not be deleted): "/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir
Running 1 test case...

*** No errors detected
$ ls -l '/somewhere/mydatadir/test_common_Bitcoin Core/getarg_tests/doubledash/datadir'
total 8
drwxrwxr-x 2 admin admin 4096 Nov 27 22:45 blocks
-rw-rw-r-- 1 admin admin 1003 Nov 27 22:45 debug.log

If you run an entire test suite, such as --run_test=getarg_tests, or all the test suites (by not specifying --run_test), a separate directory will be created for each individual test.

Run test_bitcoin --help for the full list of tests.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred