mirror of
https://github.com/ElementsProject/elements.git
synced 2026-08-14 12:43:40 +02:00
4b301666ff
876dbdfb4702410dfd4037614dc9298a0c09c63e tests: drop expect_disconnect behaviour for tx relay (Anthony Towns)
b29ae9efdfeeff774e32ee433ce67d8ed8ecd49f validation: only check input scripts once (Anthony Towns)
266dd0e10d08c0bfde63205db15d6c210a021b90 net_processing: drop MaybePunishNodeForTx (Anthony Towns)
Pull request description:
Because we do not discourage nodes for transactions we consider non-standard, we don't get any DoS protection from this check in adversarial scenarios, so remove the check entirely both to simplify the code and reduce the risk of splitting the network due to changes in tx relay policy.
Then, because we no longer make use of the distinction between consensus and standardness failures during script validation, don't re-validate each script with only-consensus rules, reducing the cost to us of transactions that we won't relay.
ACKs for top commit:
achow101:
ACK 876dbdfb4702410dfd4037614dc9298a0c09c63e
darosior:
re-ACK 876dbdfb4702410dfd4037614dc9298a0c09c63e
sipa:
re-ACK 876dbdfb4702410dfd4037614dc9298a0c09c63e
glozow:
ACK 876dbdfb4702410dfd4037614dc9298a0c09c63e
Tree-SHA512: 8bb0395766dde54fc48f7077b80b88e35581aa6e3054d6d65735965147abefffa7348f0850bb3d46f6c2541fd384ecd40a00a57fa653adabff8a35582e2d1811
142 lines
7.4 KiB
Python
Executable file
142 lines
7.4 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2016-2021 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test NULLDUMMY softfork.
|
|
|
|
Connect to a single node.
|
|
Generate 2 blocks (save the coinbases for later).
|
|
Generate COINBASE_MATURITY (CB) more blocks to ensure the coinbases are mature.
|
|
[Policy/Consensus] Check that NULLDUMMY compliant transactions are accepted in block CB + 3.
|
|
[Policy] Check that non-NULLDUMMY transactions are rejected before activation.
|
|
[Consensus] Check that the new NULLDUMMY rules are not enforced on block CB + 4.
|
|
[Policy/Consensus] Check that the new NULLDUMMY rules are enforced on block CB + 5.
|
|
"""
|
|
import time
|
|
|
|
from test_framework.blocktools import (
|
|
COINBASE_MATURITY,
|
|
NORMAL_GBT_REQUEST_PARAMS,
|
|
add_witness_commitment,
|
|
create_block,
|
|
create_transaction,
|
|
)
|
|
from test_framework.messages import CTransaction
|
|
from test_framework.script import (
|
|
OP_0,
|
|
OP_TRUE,
|
|
)
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework import util
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
)
|
|
|
|
NULLDUMMY_ERROR = "mempool-script-verify-flag-failed (Dummy CHECKMULTISIG argument must be zero)"
|
|
|
|
def invalidate_nulldummy_tx(tx):
|
|
"""Transform a NULLDUMMY compliant tx (i.e. scriptSig starts with OP_0)
|
|
to be non-NULLDUMMY compliant by replacing the dummy with OP_TRUE"""
|
|
assert_equal(tx.vin[0].scriptSig[0], OP_0)
|
|
tx.vin[0].scriptSig = bytes([OP_TRUE]) + tx.vin[0].scriptSig[1:]
|
|
tx.rehash()
|
|
|
|
|
|
class NULLDUMMYTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.setup_clean_chain = True
|
|
# This script tests NULLDUMMY activation, which is part of the 'segwit' deployment, so we go through
|
|
# normal segwit activation here (and don't use the default always-on behaviour).
|
|
self.extra_args = [[
|
|
f'-testactivationheight=segwit@{COINBASE_MATURITY + 5}',
|
|
'-addresstype=legacy',
|
|
'-par=1', # Use only one script thread to get the exact reject reason for testing
|
|
]]
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
util.node_fastmerkle = self.nodes[0]
|
|
self.nodes[0].createwallet(wallet_name='wmulti', disable_private_keys=True)
|
|
wmulti = self.nodes[0].get_wallet_rpc('wmulti')
|
|
w0 = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
|
|
self.address = w0.getnewaddress()
|
|
self.pubkey = w0.getaddressinfo(self.address)['pubkey']
|
|
self.ms_address = wmulti.addmultisigaddress(1, [self.pubkey])['address']
|
|
self.wit_address = w0.getnewaddress(address_type='p2sh-segwit')
|
|
self.wit_ms_address = wmulti.addmultisigaddress(1, [self.pubkey], '', 'p2sh-segwit')['address']
|
|
if not self.options.descriptors:
|
|
# Legacy wallets need to import these so that they are watched by the wallet. This is unnecessary (and does not need to be tested) for descriptor wallets
|
|
wmulti.importaddress(self.ms_address)
|
|
wmulti.importaddress(self.wit_ms_address)
|
|
|
|
self.coinbase_blocks = self.generate(self.nodes[0], 2) # block height = 2
|
|
coinbase_txid = []
|
|
for i in self.coinbase_blocks:
|
|
coinbase_txid.append(self.nodes[0].getblock(i)['tx'][0])
|
|
self.generate(self.nodes[0], COINBASE_MATURITY) # block height = COINBASE_MATURITY + 2
|
|
self.lastblockhash = self.nodes[0].getbestblockhash()
|
|
self.lastblockheight = COINBASE_MATURITY + 2
|
|
self.lastblocktime = int(time.time()) + self.lastblockheight
|
|
|
|
self.log.info(f"Test 1: NULLDUMMY compliant base transactions should be accepted to mempool and mined before activation [{COINBASE_MATURITY + 3}]")
|
|
coinbase_value = self.nodes[0].gettxout(coinbase_txid[0], 0)["value"]
|
|
test1txs = [create_transaction(self.nodes[0], coinbase_txid[0], self.ms_address, amount=49, fee=coinbase_value-49)]
|
|
txid1 = self.nodes[0].sendrawtransaction(test1txs[0].serialize_with_witness().hex(), 0)
|
|
test1txs.append(create_transaction(self.nodes[0], txid1, self.ms_address, amount=48, fee=49-48))
|
|
txid2 = self.nodes[0].sendrawtransaction(test1txs[1].serialize_with_witness().hex(), 0)
|
|
coinbase_value = self.nodes[0].gettxout(coinbase_txid[1], 0)["value"]
|
|
test1txs.append(create_transaction(self.nodes[0], coinbase_txid[1], self.wit_ms_address, amount=49, fee=coinbase_value-49))
|
|
txid3 = self.nodes[0].sendrawtransaction(test1txs[2].serialize_with_witness().hex(), 0)
|
|
self.block_submit(self.nodes[0], test1txs, accept=True)
|
|
|
|
self.log.info("Test 2: Non-NULLDUMMY base multisig transaction should not be accepted to mempool before activation")
|
|
test2tx = create_transaction(self.nodes[0], txid2, self.ms_address, amount=47, fee=48-47)
|
|
invalidate_nulldummy_tx(test2tx)
|
|
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test2tx.serialize_with_witness().hex(), 0)
|
|
|
|
self.log.info(f"Test 3: Non-NULLDUMMY base transactions should be accepted in a block before activation [{COINBASE_MATURITY + 4}]")
|
|
self.block_submit(self.nodes[0], [test2tx], accept=True)
|
|
|
|
self.log.info("Test 4: Non-NULLDUMMY base multisig transaction is invalid after activation")
|
|
test4tx = create_transaction(self.nodes[0], test2tx.hash, self.address, amount=46, fee=47-46)
|
|
test6txs = [CTransaction(test4tx)]
|
|
invalidate_nulldummy_tx(test4tx)
|
|
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test4tx.serialize_with_witness().hex(), 0)
|
|
self.block_submit(self.nodes[0], [test4tx], accept=False)
|
|
|
|
self.log.info("Test 5: Non-NULLDUMMY P2WSH multisig transaction invalid after activation")
|
|
test5tx = create_transaction(self.nodes[0], txid3, self.wit_address, amount=48, fee=49-48)
|
|
test6txs.append(CTransaction(test5tx))
|
|
test5tx.wit.vtxinwit[0].scriptWitness.stack[0] = b'\x01'
|
|
assert_raises_rpc_error(-26, NULLDUMMY_ERROR, self.nodes[0].sendrawtransaction, test5tx.serialize_with_witness().hex(), 0)
|
|
self.block_submit(self.nodes[0], [test5tx], with_witness=True, accept=False)
|
|
|
|
self.log.info(f"Test 6: NULLDUMMY compliant base/witness transactions should be accepted to mempool and in block after activation [{COINBASE_MATURITY + 5}]")
|
|
for i in test6txs:
|
|
self.nodes[0].sendrawtransaction(i.serialize_with_witness().hex(), 0)
|
|
self.block_submit(self.nodes[0], test6txs, with_witness=True, accept=True)
|
|
|
|
def block_submit(self, node, txs, *, with_witness=False, accept):
|
|
tmpl = node.getblocktemplate(NORMAL_GBT_REQUEST_PARAMS)
|
|
assert_equal(tmpl['previousblockhash'], self.lastblockhash)
|
|
assert_equal(tmpl['height'], self.lastblockheight + 1)
|
|
block = create_block(tmpl=tmpl, ntime=self.lastblocktime + 1, txlist=txs)
|
|
if with_witness:
|
|
add_witness_commitment(block)
|
|
block.solve()
|
|
assert_equal(None if accept else NULLDUMMY_ERROR, node.submitblock(block.serialize().hex()))
|
|
if accept:
|
|
assert_equal(node.getbestblockhash(), block.hash)
|
|
self.lastblockhash = block.hash
|
|
self.lastblocktime += 1
|
|
self.lastblockheight += 1
|
|
else:
|
|
assert_equal(node.getbestblockhash(), self.lastblockhash)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
NULLDUMMYTest().main()
|