// Copyright (c) 2024 // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. #include #include #include #include #include #include #include #include namespace node { // TxDownloadManager wrappers TxDownloadManager::TxDownloadManager(const TxDownloadOptions& options) : m_impl{std::make_unique(options)} {} TxDownloadManager::~TxDownloadManager() = default; TxOrphanage& TxDownloadManager::GetOrphanageRef() { return m_impl->m_orphanage; } TxRequestTracker& TxDownloadManager::GetTxRequestRef() { return m_impl->m_txrequest; } CRollingBloomFilter& TxDownloadManager::RecentRejectsFilter() { return m_impl->RecentRejectsFilter(); } CRollingBloomFilter& TxDownloadManager::RecentRejectsReconsiderableFilter() { return m_impl->RecentRejectsReconsiderableFilter(); } void TxDownloadManager::ActiveTipChange() { m_impl->ActiveTipChange(); } void TxDownloadManager::BlockConnected(const std::shared_ptr& pblock) { m_impl->BlockConnected(pblock); } void TxDownloadManager::BlockDisconnected() { m_impl->BlockDisconnected(); } bool TxDownloadManager::AlreadyHaveTx(const GenTxid& gtxid, bool include_reconsiderable) { return m_impl->AlreadyHaveTx(gtxid, include_reconsiderable); } void TxDownloadManager::ConnectedPeer(NodeId nodeid, const TxDownloadConnectionInfo& info) { m_impl->ConnectedPeer(nodeid, info); } void TxDownloadManager::DisconnectedPeer(NodeId nodeid) { m_impl->DisconnectedPeer(nodeid); } bool TxDownloadManager::AddTxAnnouncement(NodeId peer, const GenTxid& gtxid, std::chrono::microseconds now, bool p2p_inv) { return m_impl->AddTxAnnouncement(peer, gtxid, now, p2p_inv); } std::vector TxDownloadManager::GetRequestsToSend(NodeId nodeid, std::chrono::microseconds current_time) { return m_impl->GetRequestsToSend(nodeid, current_time); } void TxDownloadManager::ReceivedNotFound(NodeId nodeid, const std::vector& txhashes) { m_impl->ReceivedNotFound(nodeid, txhashes); } std::optional TxDownloadManager::Find1P1CPackage(const CTransactionRef& ptx, NodeId nodeid) { return m_impl->Find1P1CPackage(ptx, nodeid); } // TxDownloadManagerImpl void TxDownloadManagerImpl::ActiveTipChange() { RecentRejectsFilter().reset(); RecentRejectsReconsiderableFilter().reset(); } void TxDownloadManagerImpl::BlockConnected(const std::shared_ptr& pblock) { m_orphanage.EraseForBlock(*pblock); for (const auto& ptx : pblock->vtx) { RecentConfirmedTransactionsFilter().insert(ptx->GetHash().ToUint256()); if (ptx->HasWitness()) { RecentConfirmedTransactionsFilter().insert(ptx->GetWitnessHash().ToUint256()); } m_txrequest.ForgetTxHash(ptx->GetHash()); m_txrequest.ForgetTxHash(ptx->GetWitnessHash()); } } void TxDownloadManagerImpl::BlockDisconnected() { // To avoid relay problems with transactions that were previously // confirmed, clear our filter of recently confirmed transactions whenever // there's a reorg. // This means that in a 1-block reorg (where 1 block is disconnected and // then another block reconnected), our filter will drop to having only one // block's worth of transactions in it, but that should be fine, since // presumably the most common case of relaying a confirmed transaction // should be just after a new block containing it is found. RecentConfirmedTransactionsFilter().reset(); } bool TxDownloadManagerImpl::AlreadyHaveTx(const GenTxid& gtxid, bool include_reconsiderable) { const uint256& hash = gtxid.GetHash(); if (gtxid.IsWtxid()) { // Normal query by wtxid. if (m_orphanage.HaveTx(Wtxid::FromUint256(hash))) return true; } else { // Never query by txid: it is possible that the transaction in the orphanage has the same // txid but a different witness, which would give us a false positive result. If we decided // not to request the transaction based on this result, an attacker could prevent us from // downloading a transaction by intentionally creating a malleated version of it. While // only one (or none!) of these transactions can ultimately be confirmed, we have no way of // discerning which one that is, so the orphanage can store multiple transactions with the // same txid. // // While we won't query by txid, we can try to "guess" what the wtxid is based on the txid. // A non-segwit transaction's txid == wtxid. Query this txid "casted" to a wtxid. This will // help us find non-segwit transactions, saving bandwidth, and should have no false positives. if (m_orphanage.HaveTx(Wtxid::FromUint256(hash))) return true; } if (include_reconsiderable && RecentRejectsReconsiderableFilter().contains(hash)) return true; if (RecentConfirmedTransactionsFilter().contains(hash)) return true; return RecentRejectsFilter().contains(hash) || m_opts.m_mempool.exists(gtxid); } void TxDownloadManagerImpl::ConnectedPeer(NodeId nodeid, const TxDownloadConnectionInfo& info) { // If already connected (shouldn't happen in practice), exit early. if (m_peer_info.contains(nodeid)) return; m_peer_info.try_emplace(nodeid, info); if (info.m_wtxid_relay) m_num_wtxid_peers += 1; } void TxDownloadManagerImpl::DisconnectedPeer(NodeId nodeid) { m_orphanage.EraseForPeer(nodeid); m_txrequest.DisconnectedPeer(nodeid); if (auto it = m_peer_info.find(nodeid); it != m_peer_info.end()) { if (it->second.m_connection_info.m_wtxid_relay) m_num_wtxid_peers -= 1; m_peer_info.erase(it); } } bool TxDownloadManagerImpl::AddTxAnnouncement(NodeId peer, const GenTxid& gtxid, std::chrono::microseconds now, bool p2p_inv) { // If this is an inv received from a peer and we already have it, we can drop it. if (p2p_inv && AlreadyHaveTx(gtxid, /*include_reconsiderable=*/true)) return true; auto it = m_peer_info.find(peer); if (it == m_peer_info.end()) return false; const auto& info = it->second.m_connection_info; if (!info.m_relay_permissions && m_txrequest.Count(peer) >= MAX_PEER_TX_ANNOUNCEMENTS) { // Too many queued announcements for this peer return false; } // Decide the TxRequestTracker parameters for this announcement: // - "preferred": if fPreferredDownload is set (= outbound, or NetPermissionFlags::NoBan permission) // - "reqtime": current time plus delays for: // - NONPREF_PEER_TX_DELAY for announcements from non-preferred connections // - TXID_RELAY_DELAY for txid announcements while wtxid peers are available // - OVERLOADED_PEER_TX_DELAY for announcements from peers which have at least // MAX_PEER_TX_REQUEST_IN_FLIGHT requests in flight (and don't have NetPermissionFlags::Relay). auto delay{0us}; if (!info.m_preferred) delay += NONPREF_PEER_TX_DELAY; if (!gtxid.IsWtxid() && m_num_wtxid_peers > 0) delay += TXID_RELAY_DELAY; const bool overloaded = !info.m_relay_permissions && m_txrequest.CountInFlight(peer) >= MAX_PEER_TX_REQUEST_IN_FLIGHT; if (overloaded) delay += OVERLOADED_PEER_TX_DELAY; m_txrequest.ReceivedInv(peer, gtxid, info.m_preferred, now + delay); return false; } std::vector TxDownloadManagerImpl::GetRequestsToSend(NodeId nodeid, std::chrono::microseconds current_time) { std::vector requests; std::vector> expired; auto requestable = m_txrequest.GetRequestable(nodeid, current_time, &expired); for (const auto& entry : expired) { LogDebug(BCLog::NET, "timeout of inflight %s %s from peer=%d\n", entry.second.IsWtxid() ? "wtx" : "tx", entry.second.GetHash().ToString(), entry.first); } for (const GenTxid& gtxid : requestable) { if (!AlreadyHaveTx(gtxid, /*include_reconsiderable=*/false)) { LogDebug(BCLog::NET, "Requesting %s %s peer=%d\n", gtxid.IsWtxid() ? "wtx" : "tx", gtxid.GetHash().ToString(), nodeid); requests.emplace_back(gtxid); m_txrequest.RequestedTx(nodeid, gtxid.GetHash(), current_time + GETDATA_TX_INTERVAL); } else { // We have already seen this transaction, no need to download. This is just a belt-and-suspenders, as // this should already be called whenever a transaction becomes AlreadyHaveTx(). m_txrequest.ForgetTxHash(gtxid.GetHash()); } } return requests; } void TxDownloadManagerImpl::ReceivedNotFound(NodeId nodeid, const std::vector& txhashes) { for (const auto& txhash : txhashes) { // If we receive a NOTFOUND message for a tx we requested, mark the announcement for it as // completed in TxRequestTracker. m_txrequest.ReceivedResponse(nodeid, txhash); } } std::optional TxDownloadManagerImpl::Find1P1CPackage(const CTransactionRef& ptx, NodeId nodeid) { const auto& parent_wtxid{ptx->GetWitnessHash()}; Assume(RecentRejectsReconsiderableFilter().contains(parent_wtxid.ToUint256())); // Prefer children from this peer. This helps prevent censorship attempts in which an attacker // sends lots of fake children for the parent, and we (unluckily) keep selecting the fake // children instead of the real one provided by the honest peer. const auto cpfp_candidates_same_peer{m_orphanage.GetChildrenFromSamePeer(ptx, nodeid)}; // These children should be sorted from newest to oldest. In the (probably uncommon) case // of children that replace each other, this helps us accept the highest feerate (probably the // most recent) one efficiently. for (const auto& child : cpfp_candidates_same_peer) { Package maybe_cpfp_package{ptx, child}; if (!RecentRejectsReconsiderableFilter().contains(GetPackageHash(maybe_cpfp_package))) { return PackageToValidate{ptx, child, nodeid, nodeid}; } } // If no suitable candidate from the same peer is found, also try children that were provided by // a different peer. This is useful because sometimes multiple peers announce both transactions // to us, and we happen to download them from different peers (we wouldn't have known that these // 2 transactions are related). We still want to find 1p1c packages then. // // If we start tracking all announcers of orphans, we can restrict this logic to parent + child // pairs in which both were provided by the same peer, i.e. delete this step. const auto cpfp_candidates_different_peer{m_orphanage.GetChildrenFromDifferentPeer(ptx, nodeid)}; // Find the first 1p1c that hasn't already been rejected. We randomize the order to not // create a bias that attackers can use to delay package acceptance. // // Create a random permutation of the indices. std::vector tx_indices(cpfp_candidates_different_peer.size()); std::iota(tx_indices.begin(), tx_indices.end(), 0); std::shuffle(tx_indices.begin(), tx_indices.end(), m_opts.m_rng); for (const auto index : tx_indices) { // If we already tried a package and failed for any reason, the combined hash was // cached in m_lazy_recent_rejects_reconsiderable. const auto [child_tx, child_sender] = cpfp_candidates_different_peer.at(index); Package maybe_cpfp_package{ptx, child_tx}; if (!RecentRejectsReconsiderableFilter().contains(GetPackageHash(maybe_cpfp_package))) { return PackageToValidate{ptx, child_tx, nodeid, child_sender}; } } return std::nullopt; } } // namespace node