Byron Hambly
9368fbac1c
test: fix flaky test wallet_groups.py
...
since the SRD coin selection was added, Elements sometimes picks a 1.0
input instead of 0.5 in this test
2023-11-22 08:55:40 +02:00
James Dorfman
48ca8b0f76
test: fix bug in wallet_groups.py functional test that was introduced in merge of bitcoin/bitcoin#22364 in 00f2e32
2023-11-15 20:01:50 +00:00
Byron Hambly
fa3c0f4eaa
Merge 3ac38058ce into merged_master (Bitcoin PR bitcoin/bitcoin#23789 )
2023-06-14 05:39:34 +00:00
Byron Hambly
00f2e32c8e
Merge 47fe7445e7 into merged_master (Bitcoin PR bitcoin/bitcoin#22364 )
...
- some fixmes in this commit, related to invalid schnorr signatures
which need investigation
2023-05-29 12:58:36 +00:00
Byron Hambly
bd68371fb6
Merge ffdab41f94 into merged_master (Bitcoin PR bitcoin/bitcoin#23474 )
2023-05-26 10:32:04 +00:00
James Dorfman
a28e1a34b5
Merge d5d0a5c604 into merged_master (Bitcoin PR bitcoin/bitcoin#17526 )
2023-04-26 04:23:36 +00:00
James Dorfman
ae89c4bc51
Merge a5d00d4baf into merged_master (Bitcoin PR bitcoin/bitcoin#22788 )
2023-04-21 04:02:55 +00:00
MarcoFalke
fada6c65d2
wallet: Strictly match tx change type to improve privacy
2021-12-17 07:59:39 +01:00
Andrew Chow
8fb57845ee
Create a tr() descriptor bech32m DescriptorScriptPubKeyMan by default
2021-11-16 12:20:13 -05:00
MarcoFalke
fac23c2114
scripted-diff: Bump copyright headers
...
The previous diff touched most files in ./test/, so bump the headers to
avoid having to touch them again for a bump later.
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./test/
-END VERIFY SCRIPT-
2021-11-10 11:10:24 +01:00
MarcoFalke
fa974f1f14
scripted-diff: Remove redundant sync_all and sync_blocks
...
The sync calls are redundant after a call to generate, because generate
already syncs itself.
-BEGIN VERIFY SCRIPT-
perl -0777 -pi -e 's/(generate[^\n]*\)[^\n]*)(\n|\s)+self.sync_(all|blocks)\([^\)]*\)\n/\1\n/g' $(git grep -l generate ./test)
-END VERIFY SCRIPT-
2021-11-10 11:10:15 +01:00
MarcoFalke
fa0b916971
scripted-diff: Use generate* from TestFramework
...
-BEGIN VERIFY SCRIPT-
sed --regexp-extended -i \
's/((self\.)?(nodes\[[^]]+\]|[a-z_]*(wallet|node)[0-9a-z_]*))\.(generate(|toaddress|block|todescriptor)(\(|, ))/self.\5\1, /g' \
$(git grep -l generate ./test | grep -v 'test_framework/' | grep -v 'feature_rbf')
-END VERIFY SCRIPT-
2021-09-02 10:34:35 +02:00
Andrew Poelstra
083e08cf82
Merge d6a59166a1 into merged_master (Bitcoin PR bitcoin/bitcoin#22257 )
...
Just as mechanical and annoying as it looks.
2021-07-28 21:06:57 +00:00
Andrew Poelstra
01b1d5f844
Merge c5ee0cc11a into merged_master (Bitcoin PR bitcoin/bitcoin#21989 )
2021-07-19 13:07:08 +00:00
Andrew Poelstra
43d7756b36
Merge e9b6400a1e into merged_master (Bitcoin PR #21411 )
2021-06-26 21:31:48 +00:00
Sebastian Falbesoner
a79396fe5f
test: remove ToHex helper, use .serialize().hex() instead
2021-06-21 14:30:03 +02:00
Sebastian Falbesoner
2ce7b47958
test: introduce tx_from_hex helper for tx deserialization
...
`FromHex` is mostly used for transactions, so we introduce a
shortcut `tx_from_hex` for `FromHex(CTransaction, hex_str)`.
2021-06-21 14:28:05 +02:00
Kiminuo
bfa9309ad6
Use COINBASE_MATURITY constant in functional tests.
2021-05-31 07:32:28 +02:00
Jon Atack
c62f9bc0e9
test: use fewer blocks in wallet_groups and move sync call
...
- generate 101 blocks instead of 110
- move a sync_all call into the loop so that fewer blocks are
synced on each call to hopefully see fewer timeouts
2021-03-11 17:15:05 +01:00
Jon Atack
3a16b5ef95
test: add missing logging to wallet_groups.py
2021-03-07 20:25:11 +01:00
Andrew Poelstra
ddd9b819bb
Merge a2a250c7d0 into merged_master (Bitcoin PR #19743 )
2020-11-28 00:53:18 +00:00
Andrew Poelstra
fa471ad724
Merge e6e277f9ed into merged_master (Bitcoin PR #19756 )
...
lol
2020-11-28 00:31:20 +00:00
Andrew Poelstra
f197c02e18
Merge c831e105c5 into merged_master (Bitcoin PR #14582 )
2020-11-27 23:36:05 +00:00
Andrew Poelstra
c98788b086
Merge cb1ee1551c into merged_master (Bitcoin PR #19674 )
2020-11-27 14:17:51 +00:00
Andrew Poelstra
fd37b7c5d6
Merge 54f812d9d2 into merged_master (Bitcoin PR #18673 )
2020-11-26 01:08:23 +00:00
Andrew Poelstra
5c5d93eb64
Merge d402c1e4d3 into merged_master (Bitcoin PR #18345 )
2020-11-26 01:07:55 +00:00
Andrew Poelstra
17a72c9c14
Merge c26b05c2b7 into merged_master (Bitcoin PR #17770 )
2020-11-14 16:52:11 +00:00
Andrew Poelstra
009bc2fdfb
Merge 99813a9745 into merged_master (Bitcoin PR #17829 )
2020-11-14 16:52:02 +00:00
Andrew Poelstra
98c5244de1
Merge a73775e4d5 into merged_master (Bitcoin PR #16917 )
2020-11-09 21:20:27 +00:00
Karl-Johan Alm
7e31ea9fa0
-maxapsfee: follow-up fixes
...
Co-authored-by: Jon Atack <jon@atack.com>
Co-authored-by: Samuel Dobson <dobsonsa68@gmail.com>
2020-08-18 19:24:39 +09:00
Karl-Johan Alm
72ae20fc14
tests: add sync_all to fix race condition in wallet groups test
2020-08-18 10:08:49 +09:00
Samuel Dobson
c831e105c5
Merge #14582 : wallet: always do avoid partial spends if fees are within a specified range
...
7f13dfb587 test: test the implicit avoid partial spends functionality (Karl-Johan Alm)
b82067bf69 wallet: try -avoidpartialspends mode and use its result if fees are below threshold (Karl-Johan Alm)
Pull request description:
The `-avoidpartialspends` feature is normally disabled, as it may affect the optimal fee for payments. This PR introduces a new parameter `-maxapsfee` (max avoid partial spends fee) which acts on the following values:
* -1: disable partial spend avoidance completely (do not even try it)
* 0: only do partial spend avoidance if fees are the same or better as the regular coin selection
* 1..∞: use APS variant if the absolute fee difference is less than or equal to the max APS fee
For values other than -1, the code will now try partial spend avoidance once, and if that gives a value within the accepted range, it will use that.
Example: -maxapsfee=0.00001000 means the wallet will do regular coin select, APS coin select, and then pick AKS iff the absolute fee difference is <= 1000 satoshi.
Edit: updated this to reflect the fact we are now using a max fee.
ACKs for top commit:
fjahr:
tested ACK 7f13dfb587
achow101:
ACK 7f13dfb587
jonatack:
ACK 7f13dfb58 , code review, debug build, verified the test fails with `AssertionError: not(2 == 1)` for the number of vouts when `-maxapsfee=0.0001` is changed to 0, and verified the new logging with an added assertion.
meshcollider:
Code review ACK 7f13dfb587
Tree-SHA512: 475929df57f6191bb4e36bfbcad5a280a64bb0ecd8767b76cb2e44e2301235d0eb294a3f2fac5bbf15d35d7ecfba47acb2285feadb883c9ce31c08377e3afb3c
2020-08-17 16:18:28 +12:00
Sebastian Falbesoner
dac7a111bd
refactor: test: use _ variable for unused loop counters
...
substitutes "for x in range(N):" by "for _ in range(N):"
indicates to the reader that a block is just repeated N times, and
that the loop counter is not used in the body
2020-08-06 18:39:33 +02:00
Karl-Johan Alm
7f13dfb587
test: test the implicit avoid partial spends functionality
...
Co-authored-by: Fabian Jahr <fjahr@protonmail.com>
2020-08-06 10:25:08 +09:00
MarcoFalke
fa488f131f
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-04-16 13:33:09 -04:00
MarcoFalke
fa19295250
test: Bump timeouts to avoid valgrind failures
2020-03-14 22:15:52 -04:00
MarcoFalke
c26b05c2b7
Merge #17770 : test: bump test timeouts so that functional tests run in valgrind
...
2d23082cbe bump test timeouts so that functional tests run in valgrind (Micky Yun Chan)
Pull request description:
ci/tests: Bump timeouts so all functional tests run on travis in valgrind #17763
Top commit has no ACKs.
Tree-SHA512: 5a8c6e2ea02b715facfcb58c761577be15ae58c45a61654beb98c2c2653361196c2eec521bcae4a9a1bab8e409d6807de771ef4c46d3d05996ae47a22d499d54
2020-01-25 11:20:47 -05:00
Micky Yun Chan
2d23082cbe
bump test timeouts so that functional tests run in valgrind
2020-01-25 15:51:35 +08:00
MarcoFalke
aaaaad6ac9
scripted-diff: Bump copyright of files changed in 2019
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2019-12-30 10:42:20 +13:00
fridokus
96299a9d6c
Test: Move common function assert_approx() into util.py
2019-09-19 14:53:40 +02:00
Steven Roose
f4889a5253
UPSTREAM MERGE BROKEN: Merge upstream commit ' 519b0bc5dc' into master
2019-05-17 16:17:09 +01:00
Gregory Sanders
0148024dd8
Functional test linting
2019-03-20 11:00:50 -04:00
Steven Roose
39020cdc7b
Adapt existing functional tests to CA
2019-03-20 12:06:03 +00:00
Steven Roose
b48aea8284
[BROKEN] Account for assets in all balance inspection in tests
2019-03-20 12:06:01 +00:00
MarcoFalke
fa71b38168
scripted-diff: Rename rpc_timewait to rpc_timeout
...
-BEGIN VERIFY SCRIPT-
sed -i -e 's/self.rpc_timewait/self.rpc_timeout/g' $(git grep -l self.rpc_timewait)
-END VERIFY SCRIPT-
2018-12-22 17:23:25 +01:00
MarcoFalke
fac9539836
qa: Run all tests even if wallet is not compiled
2018-09-10 17:53:21 -04:00
practicalswift
68400d8b96
tests: Use explicit imports
2018-08-13 14:13:39 +02:00
MarcoFalke
fa5b440971
qa: Extract rpc_timewait as test param
...
Also increase it for wallet_dump and wallet_groups
2018-08-01 14:37:07 -04:00
Suhas Daftuar
a13647b8bd
[qa] Add test for too-large wallet output groups
2018-07-30 12:08:23 -04:00
Karl-Johan Alm
0128121101
test: Add basic testing for wallet groups
2018-07-24 15:05:37 +09:00