Commit graph

4250 commits

Author SHA1 Message Date
Pablo Greco
afb63a43a6 Merge branch 'master' into elem-23.3.1-rc2 2025-10-07 07:53:22 -07:00
Tom Trevethan
ef7525a446 re-enable zero fee check 2025-07-22 12:10:18 +01:00
Tom Trevethan
cd1b94e64b Merge remote-tracking branch 'origin/master' into mintxfee 2025-07-22 11:57:05 +01:00
Tom Trevethan
e8e19528b0 Zero fee transactions without fee output 2025-07-22 11:37:30 +01:00
Pablo Greco
38cbe9282d Merge branch 'master' into elem-23.3.1-rc1 2025-07-14 16:35:03 -07:00
Tom Trevethan
c4bc9fd5b4
Fix position of version argument in walletcreatefundedpsbt (#1474)
* fix position of version argument and add test

* add test for version number

---------

Co-authored-by: Tom Trevethan <ttrevethan@blockstream.com>
2025-07-11 12:27:43 +02:00
Tom Trevethan
288e2a94eb removed duplicate solving_data for funding tx rpcs 2025-07-07 15:55:11 +01:00
Byron Hambly
10a8e36813
Merge pull request #1428 from psgreco/master-showpak
wallet: Show full pak entry in getwalletpakinfo
2025-06-10 19:30:06 +02:00
brunoerg
063ab84097 rpc: fix inappropriate warning for address type p2sh-segwit in createmultisig and addmultisigaddress
Github-Pull: #25220
Rebased-From: eaf6f630c0
2025-03-10 16:21:39 +00:00
Hennadii Stepanov
cc323e0d95 wallet: Postpone NotifyWalletLoaded() for encrypted wallets
Too early NotifyWalletLoaded() call in CWallet::Create() results the
notification goes before DescriptorScriptPubKeyMans were created and
added to an encrypted wallet.

Co-authored-by: Andrew Chow <achow101-github@achow101.com>

Github-Pull: bitcoin/bitcoin#24711
Rebased-From: 0c12f0116c
2025-03-10 15:36:55 +00:00
Hennadii Stepanov
92a518c4f3 wallet, refactor: Add wallet::NotifyWalletLoaded() function
This change is a prerequisite for the following bugfix.

Github-Pull: bitcoin/bitcoin#24711
Rebased-From: aeee419c6a
2025-03-10 15:36:42 +00:00
Pablo Greco
54fa255b85 Merge branch 'master' into elem-23.3.0rc5 2025-03-04 08:53:38 -08:00
Pablo Greco
c878b2587b wallet: Show full pak entry in getwalletpakinfo 2025-03-04 07:16:05 -08:00
Pablo Greco
59c30c0779 Blinding: update change_position after calling fillBlindDetails 2025-02-25 14:57:10 -08:00
Pablo Greco
1191d76821 Merge branch 'master' into elem-23.3.0-rc2 2025-01-23 05:47:52 -08:00
Byron Hambly
8dabb73663
moneyrange: check asset type 2025-01-17 13:09:10 +02:00
Byron Hambly
a3e0ce2e8c
amountfromvalue: add arg to check moneyrange 2025-01-17 13:09:10 +02:00
Pablo Greco
f138566ad3 Wallet: avoid scanning after the last known block 2024-12-17 05:35:31 -08:00
Pablo Greco
6ef35aca7b Merge branch 'master' into elem-23.2.3-rc1 2024-08-23 08:16:31 -07:00
Byron Hambly
c1bc7caff5
fix: size estimation for pegin transactions 2024-08-14 15:41:29 +02:00
James Dorfman
c5e8a2be77
Merge pull request #1337 from ElementsProject/master
elements-23.x: merge master to prep release
2024-06-14 11:14:47 -04:00
Byron Hambly
640e4ae422
wallet: allow mintxfee=0
This check for 0 feerate was inherited from upstream, and subsequently
removed in this commit:

f11eb1fe27
2024-05-22 15:56:17 +02:00
Byron Hambly
52962c16c9
discount: allow wallet to create discount txs 2024-05-14 19:03:37 +02:00
Pablo Greco
a71bddef0e Merge branch 'master' into elem-23.2.2-rc1 2024-04-19 11:00:45 -07:00
Pablo Greco
33a15604e8 getpeginaddress cannot be trusted during ibd, it should fail 2024-04-18 17:41:51 -07:00
Pablo Greco
d66c283f06 Remove constrains on liquidv1 pegout bitcoin descriptor 2023-11-22 09:57:12 -08:00
Pablo Greco
4599a5fac3 Merge branch 'master' into elem-23.2.1rc3 2023-10-27 08:39:57 -07:00
Pablo Greco
20c5630f8c
Merge pull request #1277 from delta1/issues-1259
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal
2023-10-27 12:38:05 -03:00
James Dorfman
39be0f0925 wallet: fix tx credit calculation issues introduced in merge of bitcoin/bitcoin#22100 in 3e939cca and 103069c4 2023-10-27 15:23:19 +00:00
James Dorfman
04cba29faf coinselection: fail KnapsackSolver if the policy asset doesn't have a solution 2023-10-23 15:55:03 +00:00
James Dorfman
5b72ae23af
coinselection: fail if each non-policy asset doesn't have a solution 2023-10-23 16:51:09 +02:00
goatpig
2e7125c3c8
fix: assert failure on non-policy asset consolidation in CreateTransactionInternal
Squash of 2 commits from https://github.com/ElementsProject/elements/pull/1258

- correct application of non_policy_effective_value to policy output in KnapsackSolver
- replace bad fee amount assert with error log and graceful failure in CWallet::CreateTransactionInternal

(cherry picked from commit 0f92a38254)

Update src/wallet/coinselection.cpp

Co-authored-by: Byron Hambly <byron@hambly.dev>
(cherry picked from commit cf0f56107b)
2023-10-18 16:30:41 +02:00
Byron Hambly
5326676ff3
fix: segfault on getpeginaddress rpc when not in elements mode
Fixes https://github.com/ElementsProject/elements/issues/1263

When not running in Elements mode, GetValidFedpegScripts returns an
empty vector. Subsequently `calculate_contract` is called with
`fedpegscripts.front().second` which is a null reference. This reference
is passed into `MatchLiquidWatchman` which tries to dereference the null
reference and causes a segfault.

This fix throws an exception in `getpeginaddress` if fedpegscripts is
empty, returning an error to the RPC caller. It also adds a functional
regression test.
2023-10-18 13:02:51 +02:00
Pablo Greco
d402d74cc4 [23.x] Partially revert 9c1052a521 to use legacy wallets by default 2023-10-10 10:08:57 -07:00
Pablo Greco
8719509424 Merge branch 'master' into temp-ci-rebased 2023-10-10 09:04:16 -07:00
Byron Hambly
99ed6e1bee msvc secp modules 2023-10-09 21:17:40 +00:00
Byron Hambly
0c2fbefe98 add missing 'complete' bool to psbt_updater_test 2023-10-09 21:17:00 +00:00
Pablo Greco
26e9be3aa2 Merge branch 'master' into elem-23.2.1-rc1 2023-09-27 10:41:12 -07:00
Byron Hambly
3eaccae830
lint: fix codespell warnings 2023-09-27 15:56:20 +02:00
James Dorfman
fbb5257424 Merge 313ea18e5e (Bitcoin PR bitcoin/bitcoin#25799) 2023-09-24 05:26:23 +00:00
James Dorfman
01b3a91bae Merge e089c68aa1 (Bitcoin PR bitcoin/bitcoin#24725) 2023-09-24 01:33:51 +00:00
James Dorfman
0497d1f894 build: fix additional ASAN issues in CI 2023-09-07 05:07:50 +00:00
James Dorfman
8783a30631
build: fix further ASAN issues in CI 2023-09-06 15:03:51 +02:00
Byron Hambly
860b2c3e4b
fix: move BlindDetails and IssuanceDetails to wallet.h
resolves the newly introduced circular dependencies correctly
2023-09-05 14:38:03 +02:00
Byron Hambly
4671addbe0
build: fix forward declaration of CRecipient 2023-09-01 18:13:19 +02:00
Pablo Greco
3dfd7a4e9f Linter fixes 2023-08-31 14:47:07 -07:00
James Dorfman
d457ef7dbe Merge 6802564be5 into merged_master (Elements PR #1246) 2023-08-29 04:21:31 +00:00
Byron Hambly
b958e586ef
Fix for calling GetAmount on potentially blinded output
Introduced in 103069c46c
for Bitcoin PR bitcoin/bitcoin#22100
2023-08-08 14:11:12 +02:00
James Dorfman
6a42ca5f74 Remove unused mapValueFromPresetInputs variable from src/wallet/spend.cpp.
This variable was rendered unused in the merge of bitcoin/bitcoin#22019 in e3ab195851.
2023-07-24 17:50:33 +00:00
Byron Hambly
49c3ea309e
fix: getnewaddress - don't blind bech32 addresses
fixes #1245
2023-07-19 12:40:22 +02:00