Andrew Poelstra
a4e0826481
Merge 3530d5d2d8 into merged_master (Bitcoin PR #18335 )
2021-06-27 20:40:06 +00:00
Andrew Poelstra
4447f4d24a
Merge 18cd0888ef into merged_master (Bitcoin PR #21328 )
2021-06-27 20:27:35 +00:00
Andrew Poelstra
26fd4eb181
Merge a9d1b40d53 into merged_master (Bitcoin PR #21415 )
2021-06-27 15:02:35 +00:00
Andrew Poelstra
7587699a63
Merge cabe63759c into merged_master (Bitcoin PR #20877 )
2021-06-25 22:50:12 +00:00
Andrew Poelstra
8446d721cb
Merge 4dc1ff809a into merged_master (Bitcoin PR #21192 )
2021-06-24 01:43:38 +00:00
Andrew Poelstra
639c731236
Merge b829894f84 into merged_master (Bitcoin PR #20764 )
2021-06-21 03:04:45 +00:00
Andrew Poelstra
bc289db9e0
Merge d0d256536c into merged_master (Bitcoin PR #21016 )
...
Copied the node.scheduler syntax to node.reverification_scheduler
2021-06-20 15:17:57 +00:00
Andrew Poelstra
713526f9ff
Merge e213382920 into merged_master (Bitcoin PR #21029 )
2021-06-19 16:59:56 +00:00
Andrew Poelstra
4796f602f0
Merge 3b6d1b61d3 into merged_master (Bitcoin PR #20829 )
2021-06-16 20:13:50 +00:00
MarcoFalke
3530d5d2d8
Merge #18335 : bitcoin-cli: print useful error if bitcoind rpc work queue exceeded
...
8dd5946c0b add functional test (Larry Ruane)
b5a80fa7e4 util: Handle HTTP_SERVICE_UNAVAILABLE in bitcoin-cli (Hennadii Stepanov)
Pull request description:
If `bitcoind` is processing 16 RPC requests, attempting to submit another request using `bitcoin-cli` produces this less-than-helpful error message: `error: couldn't parse reply from server`. This PR changes the error to: `error: server response: Work queue depth exceeded`.
ACKs for top commit:
fjahr:
tACK 8dd5946c0b
luke-jr:
utACK 8dd5946c0b (no changes since previous utACK)
hebasto:
re-ACK 8dd5946c0b , only suggested changes since my [previous](https://github.com/bitcoin/bitcoin/pull/18335#pullrequestreview-460621350 ) review.
darosior:
ACK 8dd5946c0b
Tree-SHA512: 33e25f6ff05d9b56fae2bdb68b132557bb8e995f5438ac4fbbc53c304c5152a98aa43c43600c31d8a6a2830cbd48bf8ec7d89dce50190b29ec00a43830126913
2021-03-19 20:52:16 +01:00
MarcoFalke
18cd0888ef
Merge #21328 : net, refactor: pass uint16 CService::port as uint16
...
52dd40a9fe test: add missing netaddress include headers (Jon Atack)
6f09c0f6b5 util: add missing braces and apply clang format to SplitHostPort() (Jon Atack)
2875a764f7 util: add ParseUInt16(), use it in SplitHostPort() (Jon Atack)
6423c8175f p2p, refactor: pass and use uint16_t CService::port as uint16_t (Jon Atack)
Pull request description:
As noticed during review today in https://github.com/bitcoin/bitcoin/pull/20685#discussion_r584873708 of the upcoming I2P network support, `CService::port` is `uint16_t` but is passed around the codebase and into the ctors as `int`, which causes uneeded conversions and casts. We can avoid these (including in the incoming I2P code without further changes to it) by using ports with the correct type. The remaining conversions are pushed out to the user input boundaries where they can be range-checked and raise with user feedback in the next patch.
ACKs for top commit:
practicalswift:
cr ACK 52dd40a9fe : patch looks correct
MarcoFalke:
cr ACK 52dd40a9fe
vasild:
ACK 52dd40a9fe
Tree-SHA512: 203c1cab3189a206c55ecada77b9548b810281cdc533252b8e3330ae0606b467731c75f730ce9deb07cbaab66facf97e1ffd2051084ff9077cba6750366b0432
2021-03-19 20:47:10 +01:00
fanquake
ebc4ab721b
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
Jon Atack
6423c8175f
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-16 19:52:31 +01:00
fanquake
57e980d13c
scripted-diff: remove Optional & nullopt
...
-BEGIN VERIFY SCRIPT-
git rm src/optional.h
sed -i -e 's/Optional</std::optional</g' $(git grep -l 'Optional<' src)
sed -i -e 's/{nullopt}/{std::nullopt}/g' $(git grep -l 'nullopt' src)
sed -i -e 's/ nullopt;/ std::nullopt;/g' $(git grep -l 'nullopt' src)
sed -i -e 's/ nullopt)/ std::nullopt)/g' $(git grep -l 'nullopt' src)
sed -i -e 's/(nullopt)/(std::nullopt)/g' $(git grep -l 'nullopt' src)
sed -i -e 's/ nullopt,/ std::nullopt,/g' $(git grep -l 'nullopt' src)
sed -i -e 's/? nullopt :/? std::nullopt :/g' $(git grep -l 'nullopt' src)
sed -i -e 's/: nullopt}/: std::nullopt}/g' $(git grep -l 'nullopt' src)
sed -i -e '/optional.h \\/d' src/Makefile.am
sed -i -e '/#include <optional.h>/d' src/test/fuzz/autofile.cpp src/test/fuzz/buffered_file.cpp src/test/fuzz/node_eviction.cpp
sed -i -e 's/#include <optional.h>/#include <optional>/g' $(git grep -l '#include <optional.h>' src)
-END VERIFY SCRIPT-
2021-03-15 10:41:30 +08:00
Jon Atack
7d3343fb8e
cli: update -netinfo help doc following the merge of 882ce251
2021-02-17 15:05:42 +01:00
Jon Atack
ef614bb408
cli: small -netinfo simplification and performance improvement
...
that removes code and particularly this code from the loop of all peers:
`m_is_i2p_on |= (network_id == NET_I2P);`
2021-02-17 15:05:03 +01:00
Jon Atack
6b45ef3233
cli: improve -netinfo invalid argument error message
2021-02-17 15:05:01 +01:00
Jon Atack
3732404afa
cli: warn in help that -netinfo is not intended to be a stable API
2021-02-17 15:04:50 +01:00
Jon Atack
7afdd72258
cli: enable -netinfo help to run without a remote server
2021-02-17 14:55:19 +01:00
Wladimir J. van der Laan
882ce25132
cli: Treat high detail levels as the maximum in -netinfo
...
I somehow often type `-netinfo 5` which gets treated as `-netinfo 0`,
after this change it's `-netinfo 4` which seems more convenient behavior.
2021-02-15 20:01:52 +01:00
Jon Atack
747cb5b994
netinfo: display only outbound block relay counts
2021-02-03 14:18:20 +01:00
Jon Atack
76d198a5c1
netinfo: add i2p network
...
the i2p peer counts column is displayed iff the node is connected
to at least one i2p peer, so this doesn't add clutter for users
who are not running an i2p service
2021-02-03 14:17:32 +01:00
Jon Atack
9d6aeca2c5
netinfo: add bip152 high-bandwidth to/from fields
2021-02-03 14:17:30 +01:00
Jon Atack
5de7a6cf63
netinfo: display manual peers count
2021-02-03 14:17:28 +01:00
Jon Atack
d3cca3be63
netinfo: update to use peer connection types
2021-02-03 14:17:18 +01:00
Jon Atack
62bf5b7850
netinfo: add ConnectionTypeForNetinfo member helper function
2021-02-02 15:22:22 +01:00
fanquake
dc8be12510
refactor: remove boost::thread_group usage
2021-01-29 15:39:44 +08:00
fanquake
e213382920
Merge #21029 : bitcoin-cli: Correct docs (no "generatenewaddress" exists)
...
71430aec43 bitcoin-cli: Correct docs (no "generatenewaddress" exists) (Luke Dashjr)
Pull request description:
ACKs for top commit:
jonatack:
ACK 71430aec43
Tree-SHA512: 45ee7a51080598141fac4446563bdf99a59bfaa0ee00d9e092511087a968e8535d9208683ed589be1c975531be6d0319d33720f1f0dc1c3635c7d5ea6d726a41
2021-01-29 11:36:57 +08:00
Luke Dashjr
71430aec43
bitcoin-cli: Correct docs (no "generatenewaddress" exists)
2021-01-29 00:38:57 +00:00
Jon Atack
6f2c4fd077
netinfo: add user help documentation
...
and drop no longer needed sort description header to save screen space
2021-01-05 21:31:48 +01:00
Andrew Poelstra
56bb454243
Merge 2e24197117 into merged_master (Bitcoin PR #20115 )
2020-12-01 19:06:05 +00:00
Andrew Poelstra
2a2f3e49ea
Merge 0d22482353 into merged_master (Bitcoin PR #20002 )
2020-12-01 03:42:49 +00:00
Andrew Poelstra
f2177876bd
Merge 60ec57b3d7 into merged_master (Bitcoin PR #20055 )
2020-11-30 04:25:38 +00:00
Andrew Poelstra
1f47015ba6
Merge 5db44c740e into merged_master (Bitcoin PR #20014 )
2020-11-29 23:32:59 +00:00
Andrew Poelstra
c1f937fe53
Merge 8219893825 into merged_master (Bitcoin PR #19993 )
2020-11-29 18:52:06 +00:00
Andrew Poelstra
e62380314d
Merge a33651866c into merged_master (Bitcoin PR #19643 )
2020-11-29 04:45:04 +00:00
Andrew Poelstra
532e650b1d
Merge 23d3ae7acc into merged_master (Bitcoin PR #19405 )
2020-11-28 22:56:34 +00:00
Andrew Poelstra
2942044881
Merge 62d137ac3b into merged_master (Bitcoin PR #19561 )
2020-11-26 22:20:40 +00:00
Andrew Poelstra
bf86dda30c
Merge 5802ea6bd3 into merged_master (Bitcoin PR #19453 )
2020-11-26 01:09:23 +00:00
Andrew Poelstra
dd30279412
Merge 47a30ef0c6 into merged_master (Bitcoin PR #19133 )
2020-11-26 01:09:10 +00:00
Andrew Poelstra
11afdcc66a
Merge 9ccaee1d5e into merged_master (Bitcoin PR #19004 )
2020-11-26 01:08:51 +00:00
Andrew Poelstra
3b7c182626
Merge 24f7029064 into merged_master (Bitcoin PR #18594 )
2020-11-26 01:08:49 +00:00
Andrew Poelstra
08d74600ea
Merge 5dcb061589 into merged_master (Bitcoin PR #18702 )
2020-11-26 01:08:28 +00:00
Andrew Poelstra
fd37b7c5d6
Merge 54f812d9d2 into merged_master (Bitcoin PR #18673 )
2020-11-26 01:08:23 +00:00
Andrew Poelstra
e978e137dd
Merge 4eb1eeb02c into merged_master (Bitcoin PR #18504 )
2020-11-26 01:08:16 +00:00
Andrew Poelstra
f3fc8e9b77
Merge 6ab96ec546 into merged_master (Bitcoin PR #18574 )
2020-11-26 01:08:15 +00:00
Andrew Poelstra
cc668250eb
Merge 97aadf98d0 into merged_master (Bitcoin PR #16117 )
2020-11-26 01:07:50 +00:00
Andrew Poelstra
2c846f5fa3
Merge da3611a580 into merged_master (Elements PR #808 )
2020-11-26 00:29:43 +00:00
Andrew Poelstra
009bc2fdfb
Merge 99813a9745 into merged_master (Bitcoin PR #17829 )
2020-11-14 16:52:02 +00:00
Andrew Poelstra
0c0b496469
Merge 5aee0e2163 into merged_master (Bitcoin PR #17650 )
2020-11-14 16:51:53 +00:00