Andrew Poelstra
27930edc9c
Merge 4a540683ec into merged_master (Bitcoin PR #20813 )
2021-06-16 14:11:07 +00:00
MarcoFalke
fa0074e2d8
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-12-31 09:45:41 +01:00
Andrew Poelstra
28c55d0a14
Merge 9bd1316697 into merged_master (Bitcoin PR bitcoin-core/gui#120 )
2020-12-02 13:45:04 +00:00
Andrew Poelstra
f29422f885
Merge 501203aa91 into merged_master (Bitcoin PR bitcoin-core/gui#17 )
2020-11-26 01:09:17 +00:00
Andrew Poelstra
3f85455775
Merge 4946400470 into merged_master (Bitcoin PR bitcoin-core/gui#8 )
2020-11-26 01:09:13 +00:00
Andrew Poelstra
c3b6bbba4a
Merge 0865a8881d into merged_master (Bitcoin PR bitcoin-core/gui#3 )
2020-11-26 01:09:08 +00:00
Andrew Poelstra
be610d6bda
Merge f2e2c5ebcc into merged_master (Bitcoin PR #14988 )
2020-11-26 01:08:53 +00:00
Andrew Poelstra
bfa1cef745
Merge f4b603cff6 into merged_master (Bitcoin PR #17993 )
2020-11-26 01:08:53 +00:00
Andrew Poelstra
d359b993f1
Merge a587f85853 into merged_master (Bitcoin PR #18587 )
2020-11-26 01:08:46 +00:00
Andrew Poelstra
85838bef74
Merge 3eb8b1c392 into merged_master (Bitcoin PR #17905 )
2020-11-26 01:08:17 +00:00
Andrew Poelstra
009bc2fdfb
Merge 99813a9745 into merged_master (Bitcoin PR #17829 )
2020-11-14 16:52:02 +00:00
Andrew Poelstra
378d8186d5
Merge a2ae766a61 into merged_master (Bitcoin PR #15098 )
2020-11-09 21:20:36 +00:00
Andrew Poelstra
d9b8570aca
Merge 868a8cea15 into merged_master (Bitcoin PR #16674 )
2020-11-09 21:20:17 +00:00
Andrew Poelstra
7a36a783eb
Merge 8046a3e0be into merged_master (Bitcoin PR #16348 )
2020-11-09 03:58:20 +00:00
Andrew Poelstra
68d9951825
Merge d0f81a96d9 into merged_master (Bitcoin PR #16129 )
2020-11-06 15:20:13 +00:00
João Barbosa
241434200e
refactor: qt: Use vQueueNotifications.clear()
2020-11-01 12:56:10 +00:00
João Barbosa
989e579d07
qt: Make transaction notification queue wallet specific
...
Drop global vQueueNotifications and make one for each wallet.
2020-10-28 00:35:17 +00:00
João Barbosa
7b3b2303f4
move-only: Define TransactionNotification before TransactionTablePriv
...
This is needed because next commit moves vQueueNotifications to
TransactionTablePriv member.
2020-10-28 00:12:47 +00:00
MarcoFalke
faebb60b8d
doc: Remove outdated comment in TransactionTablePriv
2020-06-30 19:29:23 -04:00
Hennadii Stepanov
d906aaa117
qt: Fix regression in TransactionTableModel
...
Since #17993 a crash is possible on exit.
Co-authored-by: Russell Yanofsky <russ@yanofsky.org>
2020-06-22 23:43:22 +03:00
Hennadii Stepanov
25f3554351
scripted-diff: Make SeparatorStyle a scoped enum
...
-BEGIN VERIFY SCRIPT-
# General rename helper: $1 -> $2
rename_global() { sed -i "s/\<$1\>/$2/g" $(git grep -l "$1"); }
# Helper to rename SeparatorStyle enumerators
rename_value() {
sed -i "s/ $1/ $2/g" src/qt/bitcoinunits.h;
rename_global $1 "SeparatorStyle::$2";
}
rename_global 'enum SeparatorStyle' 'enum class SeparatorStyle'
rename_value 'separatorNever' 'NEVER'
rename_value 'separatorStandard' 'STANDARD'
rename_value 'separatorAlways' 'ALWAYS'
-END VERIFY SCRIPT-
2020-06-18 15:30:15 +03:00
Jonas Schnelli
f2e2c5ebcc
Merge #14988 : wallet: Fix for confirmed column in csv export for payment to self transactions
...
9760293ce6Closes #3455
ACKs for top commit:
jonasschnelli:
Tested ACK 9760293ce6
2020-05-29 14:42:48 +02:00
furszy
2f867203b0
Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals.
...
[ClientModel] best header/block hash cached.
2020-05-23 20:02:04 -03:00
Russell Yanofsky
83f69fab3a
Switch transaction table to use wallet height not node height
...
Tweak of #17905 to make gui display of transactions and balances more
consistent. This change shouldn't cause visible effects in normal cases, just
make GUI wallet code more internally correct and consistent.
2020-05-01 06:59:09 -04:00
Russell Yanofsky
96cb597325
gui: Avoid redundant tx status updates
...
In TransactionTablePriv::index, avoid calling
interfaces::Wallet::tryGetTxStatus if the status is up to date as of the most
recent NotifyBlockTip notification. Store height from the most recent
notification in a new ClientModel::cachedNumBlocks variable in order to check
this.
This avoids floods of IPC traffic from tryGetTxStatus with #10102 when there
are a lot of transactions. It might also make the GUI a little more efficient
even when there is no IPC.
2020-01-09 16:05:35 -04:00
MarcoFalke
aaaaad6ac9
scripted-diff: Bump copyright of files changed in 2019
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2019-12-30 10:42:20 +13:00
Ben Carman
9760293ce6
wallet: Fix for exported confirmation field in payment to self transactions
2019-10-13 11:10:36 -05:00
fanquake
a2ae766a61
Merge #15098 : qt: Show addresses for "SendToSelf" transactions
...
11fdfcf7f9Fix #11464
Fix #12688
Ref: #11471 by jonasschnelli
Note: change addresses are not recognized (ref: https://github.com/bitcoin/bitcoin/pull/11471#discussion_r180547041 )
Result:
ACKs for top commit:
jonasschnelli:
Tested ACK 11fdfcf7f911fdfcf7f9
2019-10-09 14:35:29 -04:00
fanquake
153d9dd9ac
refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound
2019-08-22 13:43:47 +08:00
João Barbosa
64fee48944
qt: Assert QMetaObject::invokeMethod result
2019-07-08 21:30:25 +01:00
practicalswift
eca9767673
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
Steven Roose
f4889a5253
UPSTREAM MERGE BROKEN: Merge upstream commit ' 519b0bc5dc' into master
2019-05-17 16:17:09 +01:00
Steven Roose
7f894ae00b
UPSTREAM MERGE BROKEN: Merge commit ' f617e05c38' into master
2019-05-01 19:18:18 +01:00
Gregory Sanders
8adf591590
QT include linting
2019-04-10 12:59:03 -04:00
Luke Dashjr
988ed5effc
GUI: Abstract asset+amount formatting into new GUIUtil::formatAssetAmount
2019-04-09 10:07:17 -04:00
Luke Dashjr
4ea8f88274
GUI: TransactionRecord: When time/index/etc match, sort fee, issuance, send, then receive
2019-04-08 15:59:33 -04:00
Luke Dashjr
51e789722f
GUI: TransactionRecord: Add asset issuance record type
2019-04-08 15:54:35 -04:00
Luke Dashjr
eef551a588
GUI: TransactionTableModel: Remove bitcoin unit from Amount column header
2019-04-08 11:39:15 -04:00
Luke Dashjr
19c87c0ae7
GUI: TransactionTableModel: Include unit name with formatted amount
2019-04-08 11:37:07 -04:00
Luke Dashjr
060ad2f566
GUI: TransactionRecord: Collapse credit+debit fields to just amount
2019-04-08 11:13:31 -04:00
João Barbosa
3edcdf8f0b
gui: Add transaction record type Fee
...
Github-Pull: bitcoin/bitcoin #12578
Rebased-From: 550f1f3d3498d051ab94afdc0b9fb883c0655b99
2019-04-08 11:02:37 -04:00
Wladimir J. van der Laan
e8ad580f51
Merge #14556 : qt: fix confirmed transaction labeled "open" ( #13299 )
...
fb3ce75807Fix #13299 .
Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled, the checking `wtx.is_final` is meaningless until the syncing has completed (ref: #1026 ).
This PR makes the wallet mark a transaction "Unconfirmed" instead of misleading "Open for NNN more blocks" when syncing after a period of being offline.
Before this PR (with the issue):
With this PR (the issue has been resolved):
Tree-SHA512: 358ec83b43c266a4d32a37a79dda80e80d40a2b77ad38261c84a095e613399f674aa7184805b3f6310e51ddb83ae2636b8849fcc7c4333e1b3ecbb0f70ad86d3
2019-01-15 17:39:19 +01:00
Ben Woosley
3a0e76fc12
Replace remaining 0 with nullptr in Qt code
...
Also used type-appropriate enum values such as Qt::NoItemFlags in
some cases.
All cases identified via -Wzero-as-null-pointer-constant
2019-01-13 03:25:14 -08:00
Hennadii Stepanov
11fdfcf7f9
Show addresses for "SendToSelf" transactions
...
Change addresses are not recognized.
2019-01-06 11:52:37 +02:00
Hennadii Stepanov
fb3ce75807
Don't label transactions "Open" while catching up
...
Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled,
the checking `wtx.is_final` is meaningless until the syncing has
completed.
2019-01-03 00:10:24 +02:00
MarcoFalke
cbb91cd0ec
Merge #13743 : refactor: Replace boost::bind with std::bind
...
cb53b825c22196c51821
2018-12-29 14:14:26 +01:00
Wladimir J. van der Laan
69d574ac6c
Merge #14554 : qt: Remove unused adjustedTime parameter
...
04972fefd1#13622 the `adjustedTime` parameter in the `updateStatus` function is unused.
Tree-SHA512: 1d0e03e7343f076ee0032fb721f8ba50571d579958001aab372a43e45b4de24c2bf3bd18c245071cbd69f61ef38182e19666c6f936d55c9085b73c848ba62626
2018-11-05 12:50:11 +01:00
Jim Posen
2068f089c8
scripted-diff: Move util files to separate directory.
...
-BEGIN VERIFY SCRIPT-
mkdir -p src/util
git mv src/util.h src/util/system.h
git mv src/util.cpp src/util/system.cpp
git mv src/utilmemory.h src/util/memory.h
git mv src/utilmoneystr.h src/util/moneystr.h
git mv src/utilmoneystr.cpp src/util/moneystr.cpp
git mv src/utilstrencodings.h src/util/strencodings.h
git mv src/utilstrencodings.cpp src/util/strencodings.cpp
git mv src/utiltime.h src/util/time.h
git mv src/utiltime.cpp src/util/time.cpp
sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp')
sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp')
sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp')
sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp')
sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp')
sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h
sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h
sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h
sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h
sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h
sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am
sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am
sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am
sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am
sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am
sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh
sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh
sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh
sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh
sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj
-END VERIFY SCRIPT-
2018-11-04 22:46:07 -08:00
Hennadii Stepanov
04972fefd1
Remove unused adjustedTime parameter
...
qt: After merging #13622 the `adjustedTime` is not used any more in
wallet related functions.
2018-10-28 09:04:10 +02:00
Chun Kuan Lee
cb53b825c2
scripted-diff: Replace boost::bind with std::bind
...
-BEGIN VERIFY SCRIPT-
for j in $(seq 1 5)
do
sed -i "s/ _${j}/ std::placeholders::_${j}/g" $(git grep --name-only " _${j}" -- '*.cpp' '*.h')
done
sed -i "s/boost::bind/std::bind/g" $(git grep --name-only boost::bind -- '*.cpp' '*.h')
sed -i "s/boost::ref/std::ref/g" $(git grep --name-only boost::ref -- '*.cpp' '*.h')
sed -i '/boost\/bind/d' $(git grep --name-only boost/bind)
-END VERIFY SCRIPT-
2018-10-20 02:29:59 +08:00
