b104f95651 Undo default signalling behavior for dynafed unless enabled (Steven Roose)
Pull request description:
Backport of #986.
ACKs for top commit:
gwillen:
utACK b104f95 for the backport, after #986 is merged, assuming that b7a116d is the final version that goes in for #986 .
Tree-SHA512: 58eb99a21fcd6f853255fc09053955c5ac0a9e991ce5b65a01ced4d67352e9d9d6a52d84742cf5e62e3068a7bf3584a195fc284cf3959cc008d786dfaaf0d143
This fixes f.e. that when arguments are set in CLI or the config file
without a network attached (`port` instead of `liquidv1.port`), they
will now be assigned to the liquidv1 instead of Bitcoin mainnet.
693f20608 fill checkqueue_tests vector for completion checking (Gregory Sanders)
3cc720592 Assert that queued checks are non-null (Gregory Sanders)
d21e0563c Address some linter complaints (Steven Roose)
ad3d496d7 Add extra lock check for OSX build (Steven Roose)
872d39fbe Prevent Travis from failing when tests are disabled (Steven Roose)
4ed0bb36b Fix dead-code linter issues (Steven Roose)
bf4f1d009 MERGE-FIX: Disable p2p_invalid_messages tests to fix later (Steven Roose)
ee0e510f3 MERGE-FIX: Fix other functional tests (Steven Roose)
5492cefcc MERGE-FIX: Fix fedpeg and pak tests for 0.18.0 (Steven Roose)
1a2a93a5f MERGE-FIX: General fixes for functional tests (Steven Roose)
3a8398024 MERGE-FIX: Fix upstream functional tests (Steven Roose)
71723f794 MERGE-FIX: Adapt bitcoin_functional (Steven Roose)
449ac89f3 MERGE-FIX: Copy bitcoin_functional from upstream (Steven Roose)
9f4f2e751 MERGE-FIX: Fix compilation errors (Steven Roose)
7256637da MERGE-FIX: Makefile fix (Steven Roose)
7afddfa8c importmulti: Don't add internal addresses to address book (Gregory Sanders)
fa483e13b rpc: Add RPCHelpMan for machine-generated help (MarcoFalke)
fa0d36f71 rpc: Include rpc/util.h where needed for RPCHelpMan (MarcoFalke)
fa5a6ce10 qa: Raise ci test_runner timeout to 40 mins (MarcoFalke)
fa3df025e travis: Avoid timeout on verify-commits check (MarcoFalke)
fa2156820 qa: Avoid race in p2p_invalid_block by waiting for the block request (MarcoFalke)
6c787d340 tests: Make feature_block pass on centos (MarcoFalke)
27154ce76 util.h: explicitly include required QString header (1Il1)
4e4de10f6 Throw error if CPubKey is invalid during PSBT keypath serialization (Gregory Sanders)
a16f44c04 qt: Remove "Pay only required fee" checkbox (Hennadii Stepanov)
8711cc0c7 qt: Improve BitcoinAmountField class (Hennadii Stepanov)
a6b5ec18f rpc: creates possibility to preserve labels on importprivkey (marcoagner)
88a79cb43 fix converttopsbt permitsigdata arg, add basic test (Gregory Sanders)
038510944 Add test for rpcpassword hash error (MeshCollider)
13fe258e9 Error if rpcpassword in conf contains a hash character (MeshCollider)
ec1201a36 Don't use systray icon on inappropriate systems (Hennadii Stepanov)
fa9ed38d5 test_node: get_mem_rss fixups (MarcoFalke)
0a656f85a qt: All tray menu actions call showNormalIfMinimized (João Barbosa)
6fc21aca6 qt: Use GUIUtil::bringToFront where possible (João Barbosa)
5796671e1 qt: Add GUIUtil::bringToFront (João Barbosa)
6b1d2972b Remove obj_c for macOS Dock icon menu (Hennadii Stepanov)
2464925e7 Use Qt signal for macOS Dock icon click event (Hennadii Stepanov)
53bb6be3f Remove obj_c for macOS Dock icon setting (Hennadii Stepanov)
76e13b586 warnings: Compiler warning on memset usage for non-trivial type (Lenny Maiorani)
1e0f3c449 macOS: disable AppNap during sync (Alexey Ivanov)
6b8d86ddb Require a public key to be retrieved when signing a P2PKH input (Andrew Chow)
e13fea975 Add regression test for PSBT signing bug #14473 (Glenn Willen)
565500508 Refactor PSBTInput signing to enforce invariant (Glenn Willen)
0f5bda2bd Simplify arguments to SignPSBTInput (Glenn Willen)
53e6fffb8 Add bool PSBTInputSigned (Glenn Willen)
65166d4cf New PartiallySignedTransaction constructor from CTransction (Glenn Willen)
4f3f5cb4b Remove redundant txConst parameter to FillPSBT (Glenn Willen)
fe5d22bc6 More concise conversion of CDataStream to string (Glenn Willen)
081accb87 Pass chain locked variables where needed (Russell Yanofsky)
79d579f4e Remove uses of cs_main in wallet code (Russell Yanofsky)
ea961c3d7 Remove direct node->wallet calls in init.cpp (Russell Yanofsky)
8db11dd0b Pass chain and client variables where needed (Russell Yanofsky)
7e2e62cf7 Add skeleton chain and client classes (Russell Yanofsky)
fa4da3c05 [doc] conf: Remove deprecated options from docs, Other cleanup (MarcoFalke)
7a90b1b9d build: Fix windows build error if `--disable-bip70` (Chun Kuan Lee)
b191c7dfb doc: add comment explaining recentRejects-DoS behavior (James O'Beirne)
c82190cdb tests: Add Python dead code linter (vulture) (practicalswift)
590a57fde tests: Remove unused testing code (practicalswift)
535203075 Avoid using numeric_limits for sequence numbers and lock times (Russell Yanofsky)
bafb92150 Remove duplicated code (Hennadii Stepanov)
e4dc39b3b Replace platform dependent type with proper const (Hennadii Stepanov)
053b6f42d align items in contrib init (Harry Moreno)
99d33a6be appveyor: Script improvement part II (Chun Kuan Lee)
4773fa820 Add llvm-symbolizer directory to PATH. Needed to get symbolized stack traces from the sanitizers. (practicalswift)
5c292dafc Add UBSan suppressions needed to pass test suite (practicalswift)
fced6b508 Add UBSan options: print_stacktrace + halt_on_error (practicalswift)
3d305e3b8 Send fewer spam messages in p2p_invalid_messages (James O'Beirne)
5a05aa2db Add metavar to match var name in help text + Change wording for better readability (Martin Erlandsson)
fef5adcc3 blockfilter: Use unordered_set instead of set in blockfilter. (Jim Posen)
4fb789e9b Extract CSipHasher to it's own file in crypto/ directory. (Jim Posen)
bbbbb3f88 qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke)
d20a9fa13 tests: add tests for invalid P2P messages (James O'Beirne)
62f94d39f tests: add P2PConnection.send_raw_message (James O'Beirne)
5aa31f6ef tests: add utility to assert node memory usage hasn't increased (James O'Beirne)
825f779dc doc: Add historical release notes for 0.17.0.1 (Wladimir J. van der Laan)
9f49db733 Enable functional tests in UBSAN job. Enable -fsanitize=integer (part of UBSAN). Merge UBSAN Travis job with no depends. (practicalswift)
6c5355e43 example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)
b6022149e trivial: Don't translate in help text (ken2812221)
086fc8357 Tests: Fix a comment (fridokus)
dfef0df84 tests: Dry run bench_bitcoin (-evals=1 -scaling=0: <1 second running time) as part "make check" to allow for quick identification of assertion/sanitizer failures in benchmarking code (practicalswift)
00c6306a6 Remove RUN_BENCH logic (practicalswift)
a4edb168b ZMQ: add options to configure outbound message high water mark, aka SNDHWM (mruddy)
ab8c6f24d Add SAFE_CHARS[SAFE_CHARS_URI]: Chars allowed in URIs (RFC 3986) (practicalswift)
991248649 rpc: Make HTTP RPC debug logging more informative (practicalswift)
33ae98591 doc: Update OpenBSD build guide for 6.4 (fanquake)
6d247b114 gitignore contents of db4 folder (Marty Jones)
4ed730802 scripted-diff: Rename misleading 'defaultPort' to 'http_port' (Murray Nesbitt)
65f3672f3 wallet: Refactor to use WalletLocation (João Barbosa)
01a4c095c wallet: Add WalletLocation utility class (João Barbosa)
04972fefd Remove unused `adjustedTime` parameter (Hennadii Stepanov)
63c74d2d3 build: Remove illegal spacing in darwin.mk (Jon Layton)
2068f089c scripted-diff: Move util files to separate directory. (Jim Posen)
14a06525b tests: add test for 'getaddressinfo' RPC result 'ischange' field (whythat)
93d1aa9ab rpcwallet: add 'ischange' field to 'getaddressinfo' response (whythat)
fa4bcaf82 travis: Compile once on xenial (MarcoFalke)
fa4362661 test_runner: Remove travis specific code (MarcoFalke)
3fd7e76f6 [tests] Move deterministic address import to setup_nodes (John Newbery)
4fb3388db check that a separator is found for psbt inputs, outputs, and global map (Andrew Chow)
9605bbd31 Make clear function argument case in dev notes (Carl Dong)
fa77aaa5a doc: Add external interface consistency guarantees (MarcoFalke)
862d159d6 Add test for conversion from non-witness to witness UTXO (Pieter Wuille)
f8c171463 Convert non-witness UTXOs to witness if witness sig created (Andrew Chow)
0a0466761 FreeBSD: Document Python 3 requirement for 'gmake check' (Murray Nesbitt)
4bd125fff tests: Print dots by default (Chun Kuan Lee)
cf2f4306f gui: explicitly disable "Dark Mode" appearance on macOS (fanquake)
0e6de3aac added details about commit messages (Martin Erlandsson)
c11875c59 Add segwit address tests for importmulti (MeshCollider)
201451b1c Make getaddressinfo return solvability (MeshCollider)
1753d217e Add release notes for importmulti segwit change (MeshCollider)
353c06459 Fix typo in test_framework/blocktools (MeshCollider)
f6ed748cf Add SegWit support to importmulti with some ProcessImport cleanup (MeshCollider)
d8bf1071c Bugfix: RPC: Add address_type named param for createmultisig (Luke Dashjr)
15db77f4d Don't rely on locale dependent functions in base_blob<BITS>::SetHex(...) (uint256), DecodeBase58(...), ParseMoney(...) and ParseHex(...) (practicalswift)
36c8e6858 Various textual improvements in build docs (Martin Erlandsson)
fa511e8da Pass tx pool reference into CheckSequenceLocks (MarcoFalke)
fa78a2fc6 [tests] Test that nodes respond to getdata with notfound (MarcoFalke)
3387bb082 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee)
fbaccbf00 build: Fix Qt link order for Windows build (Chun Kuan Lee)
ed2e18398 Remove fs::relative call and fix listwalletdir tests (João Barbosa)
3be209d10 rpc: Always throw in getblockstats if -txindex is required (João Barbosa)
43719e0a3 [macOS] Remove DS_Store WindowBounds bytes object (Jonas Schnelli)
4dca7d0a9 appveyor: Enable multiwallet test (Chun Kuan Lee)
4ea77320c tests: add test case for loading copied wallet twice (Chun Kuan Lee)
2d796faf6 wallet: Fix duplicate fileid (Chun Kuan Lee)
96c509e4d show the progress of functional test (Isidoro Ghezzi)
8907df9e0 qa: Ensure wallet unload during walletpassphrase timeout (João Barbosa)
321decffa rpc: Fix wallet unload during walletpassphrase timeout (João Barbosa)
48439b3c1 Don't link SSL_LIBS with GUI unless BIP70 is enabled (James Hilliard)
fbb643d2a Add BIP70 deprecation warning (James Hilliard)
38b98507c qt: cleanup: Move BIP70 functions together in paymentserver (Wladimir J. van der Laan)
9dcf6c0df build: Add --disable-bip70 configure option (Wladimir J. van der Laan)
585b47cfe rpc: Prevent concurrent savemempool (João Barbosa)
2b91e42ec [docs] Add release note for removing getwitnessaddress (John Newbery)
ebec90ac9 [wallet] Remove deprecated addwitnessaddress RPC method (John Newbery)
07e3f585a [test] Remove deprecated addwitnessaddress from feature_segwit.py (John Newbery)
82f2fa03a [test] Remove deprecated addwitnessaddress from wallet_bumpfee.py (John Newbery)
9d7ee187a [test] Remove deprecated addwitnessaddress from p2p_compactblocks.py (John Newbery)
3cf77f0b3 [tests] Remove deprecated addwitnessaddress call from wallet_dump.py (John Newbery)
bdefc9705 [tests] Remove deprecated addwitnessaddress call from feature_nulldummy (John Newbery)
67d7d67cf [test] Fix flake8 warnings in tests (John Newbery)
69e7ee2dd Add GUARDED_BY(cs_wallet) for setExternalKeyPool, mapKeyMetadata, m_script_metadata and setLockedCoins (practicalswift)
37b2538c2 Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext (practicalswift)
dee42927c wallet: Add Clang thread safety analysis annotations (practicalswift)
1c7e25db0 wallet: Add missing locks (practicalswift)
008990536 Add compile time checking for cs_main locks which we assert at run time (practicalswift)
d4d70eda3 Fix listreceivedbyaddress not taking address as a string (Eric Scrivner)
ab9aca2bd [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text. (John Newbery)
c9f02955b [wallet] Deprecate the generate RPC method (John Newbery)
aab81720d [tests] Add generate method to TestNode (John Newbery)
c26920933 [tests] Small fixups before deprecating generate (John Newbery)
591820430 Removed explicit mention of storage requirement (squashed) (Martin Erlandsson)
8afb16687 Update documentation to incude origin information (Pieter Wuille)
ff37459ab Add tests for key origin support (Pieter Wuille)
2c6281f18 Add key origin support to descriptors (Pieter Wuille)
eeeaa2921 descriptors.md: Refer to descriptors as describing instead of matching (Russell Yanofsky)
eb4941256 doc/descriptors.md tweaks (Russell Yanofsky)
8640631eb docs: Document lint tests (Mason Simon)
97ddc6026 validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (practicalswift)
fadffae17 Revert "Make qt wallet test compatible with qt4" (MarcoFalke)
1fb3c167c Add `doc/bitcoin-conf.md` (Hennadii Stepanov)
94e21c150 test: forward timeouts properly in send_blocks_and_test (James O'Beirne)
b6b991531 Textual improvements (Martin Erlandsson)
29ed2d64f Improve CAmount tests (Hennadii Stepanov)
a3197c529 Disable wallet and address book Qt tests on macOS minimal platform (Russell Yanofsky)
1f01fe025 bitcoin-tx: Use constant for n pubkeys check (Antoine Le Calvez)
369244f65 utils: Fix broken Windows filelock (Chun Kuan Lee)
bc60c615a Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (practicalswift)
7e18673f0 Fix typo (Kristaps Kaupe)
ca6d86c32 tests: Stop node before removing the notification file (Chun Kuan Lee)
d56a06893 docs: Add release notes for listwalletdir RPC (João Barbosa)
0cb3cad16 qa: Add tests for listwalletdir RPC (João Barbosa)
cc3377360 rpc: Add listwalletdir RPC (João Barbosa)
d1b03b8e5 interfaces: Add getWalletDir and listWalletDir to Node (João Barbosa)
fc4db35bf wallet: Add ListWalletDir utility (João Barbosa)
96f6dc9fc Avoid triggering undefined behaviour in base_uint<BITS>::bits() (practicalswift)
2ab9140c9 Add tooltips for both datadir and blocksdir (Hennadii Stepanov)
304570450 Add "Blocksdir" to Debug window (Hennadii Stepanov)
b0510d78a Set C locale for amountWidget (Hennadii Stepanov)
2d471636e wallet: Remove trailing separators from -walletdir arg (Pierre Rochard)
ea3009ee9 wallet: Add walletdir arg unit tests (Pierre Rochard)
43c7fbb1e Make MSVC compiler read the source code using utf-8 (Chun Kuan Lee)
f86a571ed tests: Add test case for std::ios_base::ate (Chun Kuan Lee)
a554cc901 Move boost/std fstream to fsbridge (Chun Kuan Lee)
86eb3b3f1 utils: Add fsbridge fstream function wrapper (Chun Kuan Lee)
d56202707 [doc] getblocktemplate: use SegWit in example (Sjors Provoost)
081cc02a9 Fix QCompleter popup regression (Hennadii Stepanov)
ee0b7c4e8 build: Pin to specific versions of Python packages we install from PyPI in Travis (practicalswift)
c32cf6a0f Add ignored word: mut (practicalswift)
4ae50daaa Revert "qa: Fix codespell error and have lint-spelling error instead of warn" (practicalswift)
032488e6e Move SocketHandler logic to private method. (Patrick Strateman)
2af9cff11 Move InactivityCheck logic to private method. (Patrick Strateman)
7479b63d9 Move DisconnectNodes logic to private method. (Patrick Strateman)
edb5350c3 Move NotifyNumConnectionsChanged logic to private method. (Patrick Strateman)
7d173c4cd qt: Revert "Force TLS1.0+ for SSL connections" (Tim Ruffing)
36323e2ac Clean systray icon menu for -disablewallet mode (Hennadii Stepanov)
2f6b466ae Stop requiring imported pubkey to sign non-PKH schemes (Pieter Wuille)
b8edb9810 [rpc] Descriptions: Textual consistency fixes (Jon Layton)
a48e44bd4 Fix CLEAN_BITCOIN_TEST to remove .log files for all BITCOIN_TESTS files (James O'Beirne)
3e9f6c821 Add missing locks and locking annotations for CAddrMan (practicalswift)
f149e31ea depends: qt: avoid system harfbuzz and bz2 (Cory Fields)
854c85ae9 test: allow arguments to be forwarded to flake8 in lint-python.sh (James O'Beirne)
3f5ac2720 Include some files currently missed by 'make distclean'. (murrayn)
3b706212a doc: RPC documentation (Karel Bílek)
0bd64dc6d Fix macOS files description (Hennadii Stepanov)
faa4043c6 qa: Run more tests with wallet disabled (MarcoFalke)
62c304ea4 tests: Allow closed http server in assert_start_raises_init_error (Chun Kuan Lee)
59a50c217 appveyor: trivial build cache modifications (Chun Kuan Lee)
42a995ae4 [tests] Remove rpc_zmq.py (John Newbery)
b09c81454 Don't access out of bounds array entry array[sizeof(array)] (Ben Woosley)
64937fda6 [docs] path to descriptors.md fixed (Damian Mee)
380c84321 utils: Convert Windows args to utf-8 string (Chun Kuan Lee)
4a9f064ea Fix typos (Dimitris Apostolou)
86eddd466 doc: miss install (poiuty)
d10f2cd7d travis: set codespell version to avoid breakage (MarcoFalke)
fad95e8da doc: Split build linux dependencies (MarcoFalke)
000000901 doc: Split depends installation instructions per arch (MarcoFalke)
ff94da788 tests: Make appveyor run with --usecli (practicalswift)
db0183936 test: Add missing call to skip_if_no_cli() (practicalswift)
1f59c6f3e doc: Remove "temporary file" notice from 0.17.0 release notes (Wladimir J. van der Laan)
5aaf1a047 doc: Add historical release notes for 0.17.0 (Wladimir J. van der Laan)
d813266db [gitian] use versioned unsigned tarballs instead of generically named ones (Andrew Chow)
fa69ac761 doxygen: Fix member comments (MarcoFalke)
430bf6c7a depends: fix bitcoin-qt back-compat with older freetype versions at runtime (Cory Fields)
0809e68a9 doc: Add historical release notes for 0.14.3 and 0.15.2 (Wladimir J. van der Laan)
fae9e84cb doc: Add GitHub pr template (MarcoFalke)
c7b3e487f tests: exclude all tests with difference parameters (Chun Kuan Lee)
fa84723e7 amount: Move CAmount CENT to unit test header (MarcoFalke)
9c5af58d5 Consolidate redundant implementations of ParseHashStr (Ben Woosley)
66b3fc543 Skip stale tip checking if outbound connections are off or if reindexing. (Gregory Maxwell)
a2a04a5ab Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (Luke Dashjr)
92af71cea configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx (Luke Dashjr)
e46023287 Document fixed attribute behavior in critical test framework classes. (Justin Turner Arthur)
17b42f412 Check for specific tx acceptance failures based on script signature (Justin Turner Arthur)
3a4449e9a Strictly enforce instance attrs in critical functional test classes. (Justin Turner Arthur)
1d0ce94a5 Fix for incorrect version attr set on functional test segwit block. (Justin Turner Arthur)
ba923e32a test: Fix broken segwit test (practicalswift)
7ac911afe [docs] Add release notes for removing `-usehd` (John Newbery)
25548b295 [wallet] Remove -usehd (John Newbery)
20442f617 [wallet] remove redundand restart node (gustavonalle)
db1580566 [wallet] Ensure wallet is unlocked before signing (gustavonalle)
2c3eade70 Make fs::path::string() always return utf-8 string (Chun Kuan Lee)
fa6b30c40 lcov: filter /usr/lib/ from coverage reports (MarcoFalke)
ff40357da AppVeyor: Move AppVeyor YAML to dot-file-style YAML (Mitchell Cash)
67654b640 tests: write the notification to different files to avoid race condition (Chun Kuan Lee)
6fa901fb4 Don't edit Chainparams after initialization (Jorge Timón)
980b38f8a MOVEONLY: Move versionbits info out of versionbits.o (Jorge Timón)
661ac15a4 appveyor: Run functional tests on appveyor (Chun Kuan Lee)
2148c36b6 tests: Make it possible to run functional tests on Windows (Chun Kuan Lee)
5eb20f81d Consistently use ParseHashV to validate hash inputs in rpc (Ben Woosley)
1eb9a9b52 [RPC] Remove warning for removed estimatefee RPC (John Newbery)
30973e984 [REST] improve performance for JSON calls (Antoine Le Calvez)
a23a7f60a wallet: Avoid potential use of unitialized value bnb_used in CWallet::CreateTransaction(...) (practicalswift)
b6718e373 tests: Use MakeUnique to construct objects owned by unique_ptrs (practicalswift)
3ccfa34b3 convert C-style (void) parameter lists to C++ style () (Arvid Norberg)
fa910e430 init: Remove deprecated args from hidden args (MarcoFalke)
52beb9ed8 Add autogen.sh in ARM Cross-compilation (Walter)
a2eb6f540 [rpc] Add getnodeaddresses RPC command (chris-belcher)
fd5c95cc4 doc: Add historical release notes for 0.16.3 (Wladimir J. van der Laan)
9b4a36eff [qa] Test for duplicate inputs within a transaction (Suhas Daftuar)
b8f801964 Fix crash bug with duplicate inputs within a transaction (Suhas Daftuar)
0ca4c8b3c Changed functional tests which do not require wallets to run without (sanket1729)
f1bd03eb0 [depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions (mruddy)
be54f42e5 use integer division instead of double conversion and multiplication for computing amounts (Arvid Norberg)
Pull request description:
Currently this catches up until Core commit f617e05c38 and has everything working except the `p2p_invalid_messages` unit test that gets some updates in later upstream commits.
I'm planning to continue to catch up to 519b0bc5dc next, which is the merge-base between upstream master and upstream v0.18.0.
Fixes#532.
Tree-SHA512: a8da8fe1c03d3317fc42d610b2203b7b84ac403ecdff88cf54be525c7a94b0b366ae8741b2652274152f9da657631c221bf2540b79c9c121b5b1e74facd197c1
The block height validation is gated by the startup option
`con_blockheightinheader`, accesible in custom chains only
using option `chain=<name>`. Only if set to true will this
field be (de)serialized and evaluated in consensus logic.
Otherwise the field is simply ignored, other than being
stored in memory as the default value 0.
And use it to reduce chainparamsbase's direct reliance on util.h to
only args handling.
utilmemory.h can be replaced with <memory> once we move to C++14.
Many options are extremely technical, and refer internals, making it
difficult to translate usefully. This came up in discussion of e.g.
#10949. If a message is not understood by translators (which are
typically end-users, not developers) they'll either translate it
literally, making it harder to understand instead of easier, with the
added drawback of the user no longer being able to google it.
Also the translation was only working for bitcoin-qt as with
the console programs, there is no translation backend. So it was
injecting never-used translation messages for bitcoin-cli, -tx.
For these reasons, stop translating options help completely. This should
not affect the output **in any way** except for bitcoin-qt when a
non-English language is configured in the locale.
This implements #10962.
a5bca13 Bugfix: Include <memory> for std::unique_ptr (Luke Dashjr)
Pull request description:
Not sure why all these includes were missing, but it's breaking builds for some users:
https://bugs.gentoo.org/show_bug.cgi?id=652142
(Added to all files with a reference to `std::unique_ptr`)
Tree-SHA512: 8a2c67513ca07b9bb52c34e8a20b15e56f8af2530310d9ee9b0a69694dd05e02e7a3683f14101a2685d457672b56addec591a0bb83900a0eb8e2a43d43200509
