Andrew Poelstra
68d0a25901
Merge 1326092e6c into merged_master (Bitcoin PR #17156 )
...
This fixes a segfault I introduced in 981df590811 (#17371 ) a couple hundred PRs
ago, where we might out-of-bounds access the vout arrray of a non_witness_utxo
transaction in a PSBT.
This logic should probably be refactored after the rebase -- we sift through
the non_witness_utxos to find a scriptpubkey, which we use to get a wallet
provider, so we can pass this to SignPSBTInput, which then repeats the same
logic (for its own reasons, and without the segfault bug)....and we aren't
even calling SignPSBTInput for signing reasons! It has something to do with
blinding.
2020-11-14 16:52:12 +00:00
Andrew Poelstra
17a72c9c14
Merge c26b05c2b7 into merged_master (Bitcoin PR #17770 )
2020-11-14 16:52:11 +00:00
Andrew Poelstra
6f1d11cd82
Merge daae6403d8 into merged_master (Bitcoin PR #17777 )
2020-11-14 16:52:09 +00:00
Andrew Poelstra
1b7df1d514
Merge 95ca6aeec7 into merged_master (Bitcoin PR #17691 )
2020-11-14 16:52:08 +00:00
Andrew Poelstra
b5dd54f5cd
Merge ec9b964cc9 into merged_master (Bitcoin PR #17541 )
2020-11-14 16:52:08 +00:00
Andrew Poelstra
d308abd052
Merge 4e8b564df0 into merged_master (Bitcoin PR #17931 )
2020-11-14 16:52:07 +00:00
Andrew Poelstra
8bbbb28dae
Merge ac61ec9da6 into merged_master (Bitcoin PR #17843 )
2020-11-14 16:52:07 +00:00
Andrew Poelstra
7c53615bb6
Merge af05bd9e1e into merged_master (Bitcoin PR #17891 )
2020-11-14 16:52:07 +00:00
Andrew Poelstra
eb8d73022f
Merge f8c69677a1 into merged_master (Bitcoin PR #17893 )
2020-11-14 16:52:06 +00:00
Andrew Poelstra
bf82cc6a32
Merge e7f8450357 into merged_master (Bitcoin PR #16688 )
2020-11-14 16:52:06 +00:00
Andrew Poelstra
32b9383743
Merge 295211e668 into merged_master (Bitcoin PR #17445 )
2020-11-14 16:52:05 +00:00
Andrew Poelstra
75726e3bc3
Merge 40a495a38a into merged_master (Bitcoin PR #16975 )
2020-11-14 16:52:05 +00:00
Andrew Poelstra
74d2e8da1b
Merge 7ea3b85ecf into merged_master (Bitcoin PR #17578 )
2020-11-14 16:52:04 +00:00
Andrew Poelstra
c0f55c006c
Merge 45f151913e into merged_master (Bitcoin PR #16373 )
2020-11-14 16:52:04 +00:00
Andrew Poelstra
4f611f400d
Merge bcb4cdcca3 into merged_master (Bitcoin PR #17621 )
2020-11-14 16:52:04 +00:00
Andrew Poelstra
a936f8e538
Merge 816464198c into merged_master (Bitcoin PR #17851 )
2020-11-14 16:52:03 +00:00
Andrew Poelstra
c4e2622681
Merge 3f8dbcd655 into merged_master (Bitcoin PR #16658 )
2020-11-14 16:52:03 +00:00
Andrew Poelstra
009bc2fdfb
Merge 99813a9745 into merged_master (Bitcoin PR #17829 )
2020-11-14 16:52:02 +00:00
Andrew Poelstra
021eccb56e
Merge 6cb80a068d into merged_master (Bitcoin PR #17806 )
2020-11-14 16:52:01 +00:00
Andrew Poelstra
6b5ef039c0
Merge 03dfa36641 into merged_master (Bitcoin PR #17229 )
2020-11-14 16:52:00 +00:00
Andrew Poelstra
c6c5243a64
Merge 806a2c602c into merged_master (Bitcoin PR #17071 )
2020-11-14 16:51:59 +00:00
Andrew Poelstra
37b9b15143
Merge a595011f5a into merged_master (Bitcoin PR #17728 )
2020-11-14 16:51:59 +00:00
Andrew Poelstra
7776084b8f
Merge 988fe5b1ad into merged_master (Bitcoin PR #12763 )
2020-11-14 16:51:58 +00:00
Andrew Poelstra
7187ea2de7
Merge 3f1966ead6 into merged_master (Bitcoin PR #17705 )
2020-11-14 16:51:57 +00:00
Andrew Poelstra
f3ec9fa522
Merge 7da9e3a817 into merged_master (Bitcoin PR #17050 )
2020-11-14 16:51:57 +00:00
Andrew Poelstra
c9585d0fde
Merge 3d6752779f into merged_master (Bitcoin PR #17633 )
2020-11-14 16:51:56 +00:00
Andrew Poelstra
9709d02c23
Merge fae94785d9 into merged_master (Bitcoin PR #17524 )
...
lol converting the psbt test vector to a pset one was pretty brutal. Conversion to
hex using rust-bitcoin and then manual hex-editing in vim.
2020-11-14 16:51:56 +00:00
Andrew Poelstra
0f9ee77fe1
Merge 1189b6acab into merged_master (Bitcoin PR #17109 )
2020-11-14 16:51:56 +00:00
Andrew Poelstra
f68c3ea229
Merge 347dd76ec8 into merged_master (Bitcoin PR #17093 )
2020-11-14 16:51:56 +00:00
Andrew Poelstra
11487538e9
Merge df2b743759 into merged_master (Bitcoin PR #17675 )
2020-11-14 16:51:55 +00:00
Andrew Poelstra
c59a715d27
Merge cb11324a63 into merged_master (Bitcoin PR #17051 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
96822eee94
Merge 910a4301b1 into merged_master (Bitcoin PR #17522 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
0c0b496469
Merge 5aee0e2163 into merged_master (Bitcoin PR #17650 )
2020-11-14 16:51:53 +00:00
Andrew Poelstra
c7bf5baf96
Merge 526e802d69 into merged_master (Elements PR #755 )
...
This Elements PR includes components of Core PR #17211 , which since the
refactors to use effective value landed, no longer provides the right
error message when a user provides an unowned input from a wallet tx.
See https://github.com/bitcoin/bitcoin/pull/17211#pullrequestreview-528389011
This breaks a functional test which was included in this PR, but which
conveniently has been changed in the current version of the Core PR. I
fixed the behavior (commented, in SelectCoins) rather than updating the
test to the most recent version.
2020-11-14 16:51:53 +00:00
Andrew Poelstra
5a48ca16e3
Merge fee01bb053 into merged_master (Bitcoin PR #17517 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
fd78a12518
Merge 2949ea924f into merged_master (Elements PR #751 )
2020-11-14 16:51:52 +00:00
Andrew Poelstra
c3c860b38a
Merge 69ca6cdd66 into merged_master (Bitcoin PR #17599 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
05bbc1a822
Merge 2b6575d989 into merged_master (Bitcoin PR #17643 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
27de4bdecf
Merge 19698ac6bc into merged_master (Bitcoin PR #17568 )
2020-11-14 16:51:51 +00:00
Andrew Poelstra
b4d7d9d503
Merge 1f59885d27 into merged_master (Bitcoin PR #17361 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
6a5fc1dd58
Merge d8a66626d6 into merged_master (Bitcoin PR #17283 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
cc2097087c
Merge dd1478870c into merged_master (Elements PR #791 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
569c46ca22
Merge 6d00035cae into merged_master (Elements PR #778 )
2020-11-14 16:51:50 +00:00
Andrew Poelstra
7a8b5877f2
Merge 9cbd87d8ee into merged_master (Bitcoin PR #17518 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
6da00c1830
Merge 4effd67bf4 into merged_master (Bitcoin PR #17387 )
2020-11-14 16:51:48 +00:00
Andrew Poelstra
f1f5409705
Merge bb862d7864 into merged_master (Bitcoin PR #14384 )
2020-11-09 23:10:14 +00:00
Andrew Poelstra
9fdb7c094a
Merge 69a6f1ad1f into merged_master (Bitcoin PR #17513 )
2020-11-09 23:10:14 +00:00
Andrew Poelstra
01f4eb2404
Merge 5ff798c39b into merged_master (Bitcoin PR #17439 )
2020-11-09 23:10:13 +00:00
Andrew Poelstra
2720aad76b
Merge 3671c5721d into merged_master (Bitcoin PR #17532 )
2020-11-09 23:10:13 +00:00
Andrew Poelstra
db065548fc
Merge b4a1da9ef8 into merged_master (Bitcoin PR #17515 )
2020-11-09 23:10:12 +00:00
