ci: temporarily disable qa-assets unit tests

These "pass" locally but in CI they download pre-signed transactions
from https://github.com/bitcoin-core/qa-assets/ which we need to
fork and recreate.

Essentially these files are the output of the Taproot functional
test (which passes), so I am not too worried about actual failures
here. But we should wait until after the Taproot sighash is finalized
to recreate these assets.
This commit is contained in:
Andrew Poelstra 2020-12-08 00:47:07 +00:00
parent db64bd5276
commit ee5d4e3256

View file

@ -1681,7 +1681,7 @@ static void AssetTest(const UniValue& test)
CMutableTransaction mtx = TxFromHex(test["tx"].get_str());
const std::vector<CTxOut> prevouts = TxOutsFromJSON(test["prevouts"]);
BOOST_CHECK(prevouts.size() == mtx.vin.size());
BOOST_CHECK(prevouts.size() == mtx.witness.vtxinwit.size());
mtx.witness.vtxinwit.resize(mtx.vin.size());
size_t idx = test["index"].get_int64();
unsigned int test_flags = ParseScriptFlags(test["flags"].get_str());
bool fin = test.exists("final") && test["final"].get_bool();
@ -1743,9 +1743,12 @@ BOOST_AUTO_TEST_CASE(script_assets_test)
BOOST_CHECK(tests.isArray());
BOOST_CHECK(tests.size() > 0);
/*
ELEMENTS: temporarily disabled until we implement the new Taproot sighash and upload new qa-assets
for (size_t i = 0; i < tests.size(); i++) {
AssetTest(tests[i]);
}
*/
file.close();
}