mirror of
https://github.com/ElementsProject/elements.git
synced 2026-08-16 13:01:19 +02:00
Merge 2eb8c5d7a2 into merged_master (Bitcoin PR #15758)
This commit is contained in:
Andrew Poelstra
commit
be9a0adaed
1 changed files with 87 additions and 26 deletions
|
|
@ -4,21 +4,23 @@
|
|||
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
"""Test the wallet balance RPC methods."""
|
||||
from decimal import Decimal
|
||||
import struct
|
||||
|
||||
from test_framework.address import ADDRESS_BCRT1_UNSPENDABLE as ADDRESS_WATCHONLY
|
||||
from test_framework.test_framework import BitcoinTestFramework
|
||||
from test_framework.util import (
|
||||
assert_equal,
|
||||
assert_raises_rpc_error,
|
||||
connect_nodes_bi,
|
||||
sync_blocks,
|
||||
BITCOIN_ASSET,
|
||||
)
|
||||
|
||||
RANDOM_COINBASE_ADDRESS = 'XSUuFy4upmMmBo75Gpw3RPXsKJp81FpVVi'
|
||||
|
||||
def create_transactions(node, address, amt, fees):
|
||||
# Create and sign raw transactions from node to address for amt.
|
||||
# Creates a transaction for each fee and returns an array
|
||||
# of the raw transactions.
|
||||
utxos = node.listunspent(0)
|
||||
utxos = [u for u in node.listunspent(0) if u['spendable']]
|
||||
|
||||
# Create transactions
|
||||
inputs = []
|
||||
|
|
@ -42,6 +44,7 @@ def create_transactions(node, address, amt, fees):
|
|||
outputs["fee"] = fee
|
||||
raw_tx = node.createrawtransaction(inputs, outputs, 0, True)
|
||||
raw_tx = node.signrawtransactionwithwallet(raw_tx)
|
||||
assert_equal(raw_tx['complete'], True)
|
||||
txs.append(raw_tx)
|
||||
|
||||
return txs
|
||||
|
|
@ -50,21 +53,26 @@ class WalletTest(BitcoinTestFramework):
|
|||
def set_test_params(self):
|
||||
self.num_nodes = 2
|
||||
self.setup_clean_chain = True
|
||||
self.extra_args = [
|
||||
['-limitdescendantcount=3'], # Limit mempool descendants as a hack to have wallet txs rejected from the mempool
|
||||
[],
|
||||
]
|
||||
|
||||
def skip_test_if_missing_module(self):
|
||||
self.skip_if_no_wallet()
|
||||
|
||||
def run_test(self):
|
||||
self.nodes[0].importaddress(ADDRESS_WATCHONLY)
|
||||
# Check that nodes don't own any UTXOs
|
||||
assert_equal(len(self.nodes[0].listunspent()), 0)
|
||||
assert_equal(len(self.nodes[1].listunspent()), 0)
|
||||
|
||||
self.log.info("Mining one block for each node")
|
||||
self.log.info("Mining blocks ...")
|
||||
|
||||
self.nodes[0].generate(1)
|
||||
self.sync_all()
|
||||
self.nodes[1].generate(1)
|
||||
self.nodes[1].generatetoaddress(100, RANDOM_COINBASE_ADDRESS)
|
||||
self.nodes[1].generatetoaddress(101, ADDRESS_WATCHONLY)
|
||||
self.sync_all()
|
||||
|
||||
assert_equal(self.nodes[0].getbalance()['bitcoin'], 50)
|
||||
|
|
@ -73,8 +81,10 @@ class WalletTest(BitcoinTestFramework):
|
|||
self.log.info("Test getbalance with different arguments")
|
||||
assert_equal(self.nodes[0].getbalance("*")['bitcoin'], 50)
|
||||
assert_equal(self.nodes[0].getbalance("*", 1)['bitcoin'], 50)
|
||||
assert_equal(self.nodes[0].getbalance("*", 1, True)['bitcoin'], 50)
|
||||
assert_equal(self.nodes[0].getbalance("*", 1, True)['bitcoin'], 100)
|
||||
assert_equal(self.nodes[0].getbalance(minconf=1)['bitcoin'], 50)
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0, include_watchonly=True)['bitcoin'], 100)
|
||||
assert_equal(self.nodes[1].getbalance(minconf=0, include_watchonly=True)['bitcoin'], 50)
|
||||
|
||||
# Send 40 BTC from 0 to 1 and 60 BTC from 1 to 0.
|
||||
txs = create_transactions(self.nodes[0], self.nodes[1].getnewaddress(), 40, [Decimal('0.01')])
|
||||
|
|
@ -92,32 +102,34 @@ class WalletTest(BitcoinTestFramework):
|
|||
|
||||
self.log.info("Test getbalance and getunconfirmedbalance with unconfirmed inputs")
|
||||
|
||||
# getbalance without any arguments includes unconfirmed transactions, but not untrusted transactions
|
||||
assert_equal(self.nodes[0].getbalance()['bitcoin'], Decimal('9.99')) # change from node 0's send
|
||||
assert_equal(self.nodes[1].getbalance()['bitcoin'], Decimal('29.99')) # change from node 1's send
|
||||
# Same with minconf=0
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0)['bitcoin'], Decimal('9.99'))
|
||||
assert_equal(self.nodes[1].getbalance(minconf=0)['bitcoin'], Decimal('29.99'))
|
||||
# getbalance with a minconf incorrectly excludes coins that have been spent more recently than the minconf blocks ago
|
||||
# TODO: fix getbalance tracking of coin spentness depth
|
||||
assert_equal(self.nodes[0].getbalance(minconf=1)['bitcoin'], Decimal('0'))
|
||||
assert_equal(self.nodes[1].getbalance(minconf=1)['bitcoin'], Decimal('0'))
|
||||
# getunconfirmedbalance
|
||||
assert_equal(self.nodes[0].getunconfirmedbalance()['bitcoin'], Decimal('60')) # output of node 1's spend
|
||||
assert_equal(self.nodes[1].getunconfirmedbalance()['bitcoin'], Decimal('0')) # Doesn't include output of node 0's send since it was spent
|
||||
def test_balances(*, fee_node_1=0):
|
||||
# getbalance without any arguments includes unconfirmed transactions, but not untrusted transactions
|
||||
assert_equal(self.nodes[0].getbalance()['bitcoin'], Decimal('9.99')) # change from node 0's send
|
||||
assert_equal(self.nodes[1].getbalance()['bitcoin'], Decimal('30') - fee_node_1) # change from node 1's send
|
||||
# Same with minconf=0
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0)['bitcoin'], Decimal('9.99'))
|
||||
assert_equal(self.nodes[1].getbalance(minconf=0)['bitcoin'], Decimal('30') - fee_node_1)
|
||||
# getbalance with a minconf incorrectly excludes coins that have been spent more recently than the minconf blocks ago
|
||||
# TODO: fix getbalance tracking of coin spentness depth
|
||||
assert_equal(self.nodes[0].getbalance(minconf=1)['bitcoin'], Decimal('0'))
|
||||
assert_equal(self.nodes[1].getbalance(minconf=1)['bitcoin'], Decimal('0'))
|
||||
# getunconfirmedbalance
|
||||
assert_equal(self.nodes[0].getunconfirmedbalance()['bitcoin'], Decimal('60')) # output of node 1's spend
|
||||
assert_equal(self.nodes[0].getwalletinfo()["unconfirmed_balance"]['bitcoin'], Decimal('60'))
|
||||
assert_equal(self.nodes[1].getunconfirmedbalance()['bitcoin'], Decimal('0')) # Doesn't include output of node 0's send since it was spent
|
||||
assert_equal(self.nodes[1].getwalletinfo()["unconfirmed_balance"]['bitcoin'], Decimal('0'))
|
||||
|
||||
test_balances(fee_node_1=Decimal('0.01'))
|
||||
|
||||
# Node 1 bumps the transaction fee and resends
|
||||
self.nodes[1].sendrawtransaction(txs[1]['hex'])
|
||||
self.nodes[0].sendrawtransaction(txs[1]['hex']) # sending on both nodes is faster than waiting for propagation
|
||||
self.sync_all()
|
||||
|
||||
self.log.info("Test getbalance and getunconfirmedbalance with conflicted unconfirmed inputs")
|
||||
test_balances(fee_node_1=Decimal('0.02'))
|
||||
|
||||
assert_equal(self.nodes[0].getwalletinfo()["unconfirmed_balance"]['bitcoin'], Decimal('60')) # output of node 1's send
|
||||
assert_equal(self.nodes[0].getunconfirmedbalance()['bitcoin'], Decimal('60'))
|
||||
assert_equal(self.nodes[1].getwalletinfo()["unconfirmed_balance"]['bitcoin'], Decimal('0')) # Doesn't include output of node 0's send since it was spent
|
||||
assert_equal(self.nodes[1].getunconfirmedbalance()['bitcoin'], Decimal('0'))
|
||||
|
||||
self.nodes[1].generatetoaddress(1, RANDOM_COINBASE_ADDRESS)
|
||||
self.nodes[1].generatetoaddress(1, ADDRESS_WATCHONLY)
|
||||
self.sync_all()
|
||||
|
||||
# balances are correct after the transactions are confirmed
|
||||
|
|
@ -127,7 +139,7 @@ class WalletTest(BitcoinTestFramework):
|
|||
# Send total balance away from node 1
|
||||
txs = create_transactions(self.nodes[1], self.nodes[0].getnewaddress(), Decimal('29.97'), [Decimal('0.01')])
|
||||
self.nodes[1].sendrawtransaction(txs[0]['hex'])
|
||||
self.nodes[1].generatetoaddress(2, RANDOM_COINBASE_ADDRESS)
|
||||
self.nodes[1].generatetoaddress(2, ADDRESS_WATCHONLY)
|
||||
self.sync_all()
|
||||
|
||||
# getbalance with a minconf incorrectly excludes coins that have been spent more recently than the minconf blocks ago
|
||||
|
|
@ -149,6 +161,55 @@ class WalletTest(BitcoinTestFramework):
|
|||
after = self.nodes[1].getunconfirmedbalance()['bitcoin']
|
||||
assert_equal(before + Decimal('0.1'), after)
|
||||
|
||||
# Create 3 more wallet txs, where the last is not accepted to the
|
||||
# mempool because it is the third descendant of the tx above
|
||||
for _ in range(3):
|
||||
# Set amount high enough such that all coins are spent by each tx
|
||||
txid = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), 99)
|
||||
|
||||
self.log.info('Check that wallet txs not in the mempool are untrusted')
|
||||
assert txid not in self.nodes[0].getrawmempool()
|
||||
assert_equal(self.nodes[0].gettransaction(txid)['trusted'], False)
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0)['bitcoin'], 0)
|
||||
|
||||
self.log.info("Test replacement and reorg of non-mempool tx")
|
||||
tx_orig = self.nodes[0].gettransaction(txid)['hex']
|
||||
# Increase fee by 1 coin
|
||||
tx_replace = tx_orig.replace(
|
||||
struct.pack(">q", 99 * 10**8).hex(),
|
||||
struct.pack(">q", 98 * 10**8).hex(),
|
||||
)
|
||||
tx_replace = tx_replace.replace( ## is there something less fragile we can do here?
|
||||
struct.pack(">q", 7480).hex(),
|
||||
struct.pack(">q", 7480 + 10**8).hex(),
|
||||
)
|
||||
tx_replace = self.nodes[0].signrawtransactionwithwallet(tx_replace)['hex']
|
||||
# Total balance is given by the sum of outputs of the tx
|
||||
total_amount = sum([o['value'] for o in self.nodes[0].decoderawtransaction(tx_replace)['vout'] if o['scriptPubKey']['type'] != 'fee'])
|
||||
self.sync_all()
|
||||
self.nodes[1].sendrawtransaction(hexstring=tx_replace, maxfeerate=0)
|
||||
|
||||
# Now confirm tx_replace
|
||||
block_reorg = self.nodes[1].generatetoaddress(1, ADDRESS_WATCHONLY)[0]
|
||||
self.sync_all()
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0)['bitcoin'], total_amount)
|
||||
|
||||
self.log.info('Put txs back into mempool of node 1 (not node 0)')
|
||||
self.nodes[0].invalidateblock(block_reorg)
|
||||
self.nodes[1].invalidateblock(block_reorg)
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0)['bitcoin'], 0) # wallet txs not in the mempool are untrusted
|
||||
self.nodes[0].generatetoaddress(1, ADDRESS_WATCHONLY)
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0)['bitcoin'], 0) # wallet txs not in the mempool are untrusted
|
||||
|
||||
# Now confirm tx_orig
|
||||
self.restart_node(1, ['-persistmempool=0'])
|
||||
connect_nodes_bi(self.nodes, 0, 1)
|
||||
sync_blocks(self.nodes)
|
||||
self.nodes[1].sendrawtransaction(tx_orig)
|
||||
self.nodes[1].generatetoaddress(1, ADDRESS_WATCHONLY)
|
||||
self.sync_all()
|
||||
assert_equal(self.nodes[0].getbalance(minconf=0)['bitcoin'], total_amount + 1) # The reorg recovered our fee of 1 coin
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
WalletTest().main()
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue