From 9a0b5241396efe3b3ceb3931717c30bb94f99bfb Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Tue, 21 Mar 2023 13:04:12 +0000 Subject: [PATCH] clang-tidy, test: Fix bugprone-use-after-move in `Correct_Queue_range()` --- src/test/checkqueue_tests.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/test/checkqueue_tests.cpp b/src/test/checkqueue_tests.cpp index 8d55ce75f7..2a8f4f0444 100644 --- a/src/test/checkqueue_tests.cpp +++ b/src/test/checkqueue_tests.cpp @@ -184,12 +184,14 @@ static void Correct_Queue_range(std::vector range) small_queue->StartWorkerThreads(SCRIPT_CHECK_THREADS); // Make vChecks here to save on malloc (this test can be slow...) std::vector vChecks; + vChecks.reserve(9); for (const size_t i : range) { size_t total = i; FakeCheckCheckCompletion::n_calls = 0; CCheckQueueControl control(small_queue.get()); while (total) { - vChecks.resize(std::min(total, (size_t) InsecureRandRange(10))); + vChecks.clear(); + vChecks.resize(std::min(total, InsecureRandRange(10))); total -= vChecks.size(); control.Add(std::move(vChecks)); }