diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp index 331da7b391..33f4e1b607 100644 --- a/src/script/interpreter.cpp +++ b/src/script/interpreter.cpp @@ -2644,7 +2644,7 @@ void PrecomputedTransactionData::Init(const T& txTo, std::vector&& spent simplicityRawTx.version = txTo.nVersion; simplicityRawTx.lockTime = txTo.nLockTime; - m_simplicity_tx_data = simplicity_elements_mallocTransaction(&simplicityRawTx); + m_simplicity_tx_data = SimplicityTransactionUniquePtr(simplicity_elements_mallocTransaction(&simplicityRawTx)); m_bip341_taproot_ready = true; } @@ -3096,7 +3096,7 @@ bool GenericTransactionSignatureChecker::CheckSimplicity(const valtype& progr assert(txdata->m_simplicity_tx_data); assert(simplicityTapEnv); - if (!simplicity_elements_execSimplicity(&error, nullptr, txdata->m_simplicity_tx_data, nIn, simplicityTapEnv, txdata->m_hash_genesis_block.data(), budget, nullptr, program.data(), program.size(), witness.data(), witness.size())) { + if (!simplicity_elements_execSimplicity(&error, 0, txdata->m_simplicity_tx_data.get(), nIn, simplicityTapEnv, txdata->m_hash_genesis_block.data(), budget, 0, program.data(), program.size(), witness.data(), witness.size())) { assert(!"simplicity_elements_execSimplicity internal error"); } simplicity_elements_freeTapEnv(simplicityTapEnv); diff --git a/src/script/interpreter.h b/src/script/interpreter.h index 3000e73939..eddffebede 100644 --- a/src/script/interpreter.h +++ b/src/script/interpreter.h @@ -169,9 +169,18 @@ enum : uint32_t { bool CheckSignatureEncoding(const std::vector &vchSig, unsigned int flags, ScriptError* serror); +struct SimplicityTransactionDeleter +{ + void operator()(transaction* ptr) + { + simplicity_elements_freeTransaction(ptr); + } +}; +using SimplicityTransactionUniquePtr = std::unique_ptr; + struct PrecomputedTransactionData { - transaction* m_simplicity_tx_data = nullptr; + SimplicityTransactionUniquePtr m_simplicity_tx_data; // BIP341 precomputed data. // These are single-SHA256, see https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#cite_note-16. uint256 m_prevouts_single_hash; @@ -221,9 +230,6 @@ struct PrecomputedTransactionData template explicit PrecomputedTransactionData(const T& tx); - ~PrecomputedTransactionData() { - simplicity_elements_freeTransaction(m_simplicity_tx_data); - } }; enum class SigVersion diff --git a/src/test/fuzz/simplicity.cpp b/src/test/fuzz/simplicity.cpp index 6dfc907d46..ffcbbc3319 100644 --- a/src/test/fuzz/simplicity.cpp +++ b/src/test/fuzz/simplicity.cpp @@ -204,13 +204,13 @@ FUZZ_TARGET_INIT(simplicity, initialize_simplicity) PrecomputedTransactionData txdata{GENESIS_HASH}; std::vector spent_outs_copy{spent_outs}; txdata.Init(mtx, std::move(spent_outs_copy)); - assert(txdata.m_simplicity_tx_data != nullptr); + assert(txdata.m_simplicity_tx_data); // 4. Main test unsigned char imr_out[32]; unsigned char *imr = mtx.vin[0].prevout.hash.data()[2] & 2 ? imr_out : nullptr; - const transaction* tx = txdata.m_simplicity_tx_data; + const transaction* tx = txdata.m_simplicity_tx_data.get(); tapEnv* taproot = simplicity_elements_mallocTapEnv(&simplicityRawTap); simplicity_elements_execSimplicity(&error, imr, tx, nIn, taproot, GENESIS_HASH.data(), budget, amr, prog_bytes.data(), prog_bytes.size(), wit_bytes.data(), wit_bytes.size()); diff --git a/src/test/fuzz/simplicity_tx.cpp b/src/test/fuzz/simplicity_tx.cpp index 0854ee6626..3f065ced68 100644 --- a/src/test/fuzz/simplicity_tx.cpp +++ b/src/test/fuzz/simplicity_tx.cpp @@ -219,7 +219,7 @@ FUZZ_TARGET_INIT(simplicity_tx, initialize_simplicity_tx) // that we will allocate Simplicity data. The check for whether to do this is very // lax: is this a 34-byte scriptPubKey that starts with OP_1 and does it have a // nonempty witness. - assert(txdata.m_simplicity_tx_data != nullptr); + assert(txdata.m_simplicity_tx_data); } const CTransaction tx{mtx};