GlcoinCore/elements
1
0
Fork 0
mirror of https://github.com/ElementsProject/elements.git synced 2026-08-15 12:51:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

updated keypath spend test vectors for elements and re-enabled equility checks

Browse source 
(cherry picked from commit 4142ceabbe46b7ac68840d1a100fc0c6adfa86a0)
This commit is contained in:
Tom Trevethan 2026-01-08 13:17:52 +00:00 • committed by Byron Hambly
parent 491900cffd
commit 78f831139f
No known key found for this signature in database
GPG key ID: DE8F6EA20A661697
2 changed files with 34 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/test/script_tests.cpp
View file

@ -1875,7 +1875,6 @@ BOOST_AUTO_TEST_CASE(script_assets_test)
file.close();
}
// ELEMENTS FIXME: Some of these test vectors need updating
BOOST_AUTO_TEST_CASE(bip341_keypath_test_vectors)
{
UniValue tests;
@ -1903,8 +1902,7 @@ BOOST_AUTO_TEST_CASE(bip341_keypath_test_vectors)
}
BOOST_CHECK(txdata.m_bip341_taproot_ready);
// ELEMENTS: FIXME
//BOOST_CHECK_EQUAL(HexStr(txdata.m_spent_amounts_single_hash), vec["intermediary"]["hashAmounts"].get_str());
BOOST_CHECK_EQUAL(HexStr(txdata.m_spent_asset_amounts_single_hash), vec["intermediary"]["hashAmounts"].get_str());
BOOST_CHECK_EQUAL(HexStr(txdata.m_outputs_single_hash), vec["intermediary"]["hashOutputs"].get_str());
BOOST_CHECK_EQUAL(HexStr(txdata.m_prevouts_single_hash), vec["intermediary"]["hashPrevouts"].get_str());
BOOST_CHECK_EQUAL(HexStr(txdata.m_spent_scripts_single_hash), vec["intermediary"]["hashScriptPubkeys"].get_str());
@ -1935,12 +1933,10 @@ BOOST_AUTO_TEST_CASE(bip341_keypath_test_vectors)
MutableTransactionSignatureCreator creator(tx, txinpos, utxos[txinpos].nValue, &txdata, hashtype);
std::vector<unsigned char> signature;
BOOST_CHECK(creator.CreateSchnorrSig(provider, signature, pubkey, nullptr, &merkle_root, SigVersion::TAPROOT));
// ELEMENTS: FIXME
//BOOST_CHECK_EQUAL(HexStr(signature), input["expected"]["witness"][0].get_str());
BOOST_CHECK_EQUAL(HexStr(signature), input["expected"]["witness"][0].get_str());
// We can't observe the tweak used inside the signing logic, so verify by recomputing it.
// ELEMENTS: FIXME
//BOOST_CHECK_EQUAL(HexStr(pubkey.ComputeTapTweakHash(merkle_root.IsNull() ? nullptr : &merkle_root)), input["intermediary"]["tweak"].get_str());
BOOST_CHECK_EQUAL(HexStr(pubkey.ComputeTapTweakHash(merkle_root.IsNull() ? nullptr : &merkle_root)), input["intermediary"]["tweak"].get_str());
// We can't observe the sighash used inside the signing logic, so verify by recomputing it.
ScriptExecutionData sed;
@ -1951,8 +1947,7 @@ BOOST_AUTO_TEST_CASE(bip341_keypath_test_vectors)
// BOOST_CHECK_EQUAL(HexStr(sighash), input["intermediary"]["sigHash"].get_str());
// To verify the sigmsg, hash the expected sigmsg, and compare it with the (expected) sighash.
// ELEMENTS: FIXME
// BOOST_CHECK_EQUAL(HexStr((HashWriter{HASHER_TAPSIGHASH_ELEMENTS} << Span{ParseHex(input["intermediary"]["sigMsg"].get_str())}).GetSHA256()), input["intermediary"]["sigHash"].get_str());
BOOST_CHECK_EQUAL(HexStr((HashWriter{HASHER_TAPSIGHASH_ELEMENTS} << Span{ParseHex(input["intermediary"]["sigMsg"].get_str())}).GetSHA256()), input["intermediary"]["sigHash"].get_str());
}
}