From 4940ceeea6f40f4035fab3c3cb9770bd51bcb492 Mon Sep 17 00:00:00 2001
From: Andrew Chow <achow101-github@achow101.com>
Date: Thu, 17 Jun 2021 18:47:24 -0400
Subject: [PATCH] Use a constant for maximum surjection targets

---
 src/blind.cpp     | 2 +-
 src/blind.h       | 2 ++
 src/blindpsbt.cpp | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/blind.cpp b/src/blind.cpp
index 4612066dfa..5d23dfc03c 100644
--- a/src/blind.cpp
+++ b/src/blind.cpp
@@ -192,7 +192,7 @@ bool SurjectOutput(CTxOutWitness& txoutwit, const std::vector<secp256k1_fixed_as
 {
     int ret;
     // 1 to 3 targets
-    size_t nInputsToSelect = std::min((size_t)3, surjection_targets.size());
+    size_t nInputsToSelect = std::min(MAX_SURJECTION_TARGETS, surjection_targets.size());
     unsigned char randseed[32];
     GetStrongRandBytes(randseed, 32);
     size_t input_index;
diff --git a/src/blind.h b/src/blind.h
index 424aa5cb71..0ce2140eb0 100644
--- a/src/blind.h
+++ b/src/blind.h
@@ -23,6 +23,8 @@ static const size_t MAX_RANGEPROOF_SIZE = 5126;
 static const size_t DEFAULT_SURJECTIONPROOF_SIZE = 135;
 // 32 bytes of asset type, 32 bytes of asset blinding factor in sidechannel
 static const size_t SIDECHANNEL_MSG_SIZE = 64;
+// Maximum number of inputs to select for surjection proof
+static const size_t MAX_SURJECTION_TARGETS = 3;
 
 // Blinding context
 extern secp256k1_context* secp256k1_blind_context;
diff --git a/src/blindpsbt.cpp b/src/blindpsbt.cpp
index 2ffc897810..da7399f114 100644
--- a/src/blindpsbt.cpp
+++ b/src/blindpsbt.cpp
@@ -38,7 +38,7 @@ bool CreateAssetSurjectionProof(std::vector<unsigned char>& output_proof, const
 {
     int ret;
     // 1 to 3 targets
-    size_t inputs_to_select = std::min((size_t)3, fixed_input_tags.size());
+    size_t inputs_to_select = std::min(MAX_SURJECTION_TARGETS, fixed_input_tags.size());
     unsigned char randseed[32];
     GetStrongRandBytes(randseed, 32);
     size_t input_index;