From 0a6f0551d2e6a32b0457995e031b978f4c5c1dfb Mon Sep 17 00:00:00 2001
From: Steven Roose <steven@stevenroose.org>
Date: Thu, 30 May 2019 16:32:37 +0100
Subject: [PATCH] Rename -con_connect_coinbase to -con_connect_genesis_outputs

---
 src/chainparams.cpp                                           | 2 +-
 src/chainparamsbase.cpp                                       | 2 +-
 test/bitcoin_functional/functional/test_framework/util.py     | 2 +-
 test/functional/feature_assetsdir.py                          | 2 +-
 test/functional/feature_confidential_transactions.py          | 2 +-
 ...connect_coinbase.py => feature_connect_genesis_outputs.py} | 4 ++--
 test/functional/feature_default_asset_name.py                 | 2 +-
 test/functional/feature_initial_reissuance_token.py           | 2 +-
 test/functional/test_framework/util.py                        | 2 +-
 test/functional/test_runner.py                                | 2 +-
 10 files changed, 11 insertions(+), 11 deletions(-)
 rename test/functional/{feature_connect_coinbase.py => feature_connect_genesis_outputs.py} (91%)

diff --git a/src/chainparams.cpp b/src/chainparams.cpp
index eaeba7f9af..0d5081da2e 100644
--- a/src/chainparams.cpp
+++ b/src/chainparams.cpp
@@ -547,7 +547,7 @@ class CCustomParams : public CRegTestParams {
         consensus.mandatory_coinbase_destination = CScript(man_bytes.begin(), man_bytes.end()); // Blank script allows any coinbase destination
 
         // Custom chains connect coinbase outputs to db by default
-        consensus.connect_genesis_outputs = args.GetArg("-con_connect_coinbase", true);
+        consensus.connect_genesis_outputs = args.GetArg("-con_connect_genesis_outputs", true);
 
         initialFreeCoins = gArgs.GetArg("-initialfreecoins", 0);
 
diff --git a/src/chainparamsbase.cpp b/src/chainparamsbase.cpp
index 588293ac51..4f12c2328b 100644
--- a/src/chainparamsbase.cpp
+++ b/src/chainparamsbase.cpp
@@ -29,7 +29,7 @@ void SetupChainParamsBaseOptions()
     // ELEMENTS
     gArgs.AddArg("-con_mandatorycoinbase", "All non-zero valued coinbase outputs must go to this scriptPubKey, if set.", false, OptionsCategory::ELEMENTS);
     gArgs.AddArg("-con_blocksubsidy", "Defines the amount of block subsidy to start with, at genesis block, in satoshis.", false, OptionsCategory::ELEMENTS);
-    gArgs.AddArg("-con_connect_coinbase", "Connect outputs in genesis block to utxo database.", false, OptionsCategory::ELEMENTS);
+    gArgs.AddArg("-con_connect_genesis_outputs", "Connect outputs in genesis block to utxo database.", false, OptionsCategory::ELEMENTS);
     gArgs.AddArg("-con_elementsmode", "Use Elements-like instead of Core-like witness encoding.  This is required for CA/CT. (default: true)", false, OptionsCategory::ELEMENTS);
     gArgs.AddArg("-con_blockheightinheader", "Whether the chain includes the block height directly in the header, for easier validation of block height in low-resource environments. (default: true)", false, OptionsCategory::CHAINPARAMS);
     gArgs.AddArg("-con_genesis_style=<style>", "Use genesis style <style> (default: elements). Results in genesis block compatibility with various networks. Allowed values: elements, bitcoin", true, OptionsCategory::ELEMENTS);
diff --git a/test/bitcoin_functional/functional/test_framework/util.py b/test/bitcoin_functional/functional/test_framework/util.py
index 09fdc013a1..9bb1ada4a4 100644
--- a/test/bitcoin_functional/functional/test_framework/util.py
+++ b/test/bitcoin_functional/functional/test_framework/util.py
@@ -304,7 +304,7 @@ def initialize_datadir(dirname, n):
         f.write("printtoconsole=0\n")
         # Elements:
         f.write("con_blocksubsidy=5000000000\n")
-        f.write("con_connect_coinbase=0\n")
+        f.write("con_connect_genesis_outputs=0\n")
         f.write("con_has_parent_chain=0\n")
         f.write("parentgenesisblockhash=0\n")
         f.write("anyonecanspendaremine=0\n")
diff --git a/test/functional/feature_assetsdir.py b/test/functional/feature_assetsdir.py
index 1312802756..1de3cf03c8 100755
--- a/test/functional/feature_assetsdir.py
+++ b/test/functional/feature_assetsdir.py
@@ -20,7 +20,7 @@ class AssetdirTests(BitcoinTestFramework):
     def set_test_params(self):
         self.setup_clean_chain = True
         self.num_nodes = 1
-        [["-initialfreecoins=2100000000000000", "-anyonecanspendaremine=1", "-con_connect_coinbase=1", "-con_blocksubsidy=0"]]
+        [["-initialfreecoins=2100000000000000", "-anyonecanspendaremine=1", "-con_connect_genesis_outputs=1", "-con_blocksubsidy=0"]]
 
     def skip_test_if_missing_module(self):
         self.skip_if_no_wallet()
diff --git a/test/functional/feature_confidential_transactions.py b/test/functional/feature_confidential_transactions.py
index 9c1877bb17..a22a362fd6 100755
--- a/test/functional/feature_confidential_transactions.py
+++ b/test/functional/feature_confidential_transactions.py
@@ -33,7 +33,7 @@ class CTTest (BitcoinTestFramework):
     def set_test_params(self):
         self.num_nodes = 3
         self.setup_clean_chain = True
-        args = ["-blindedaddresses=1", "-initialfreecoins=2100000000000000", "-con_blocksubsidy=0", "-con_connect_coinbase=1"]
+        args = ["-blindedaddresses=1", "-initialfreecoins=2100000000000000", "-con_blocksubsidy=0", "-con_connect_genesis_outputs=1"]
         self.extra_args = [args] * self.num_nodes
         self.extra_args[0].append("-anyonecanspendaremine=1") # first node gets the coins
 
diff --git a/test/functional/feature_connect_coinbase.py b/test/functional/feature_connect_genesis_outputs.py
similarity index 91%
rename from test/functional/feature_connect_coinbase.py
rename to test/functional/feature_connect_genesis_outputs.py
index 9340a1e4bf..ef97c76168 100755
--- a/test/functional/feature_connect_coinbase.py
+++ b/test/functional/feature_connect_genesis_outputs.py
@@ -16,8 +16,8 @@ class ConnectGenesisTest(BitcoinTestFramework):
         self.num_nodes = 2
         self.setup_clean_chain = True
         # First node doesn't connect coinbase output to db, second does
-        self.extra_args = [["-con_connect_coinbase=0", "-initialfreecoins={}".format(NUM_INITIAL_COINS * COIN)],
-                           ["-con_connect_coinbase=1", "-initialfreecoins={}".format(NUM_INITIAL_COINS * COIN), '-anyonecanspendaremine=1']]
+        self.extra_args = [["-con_connect_genesis_outputs=0", "-initialfreecoins={}".format(NUM_INITIAL_COINS * COIN)],
+                           ["-con_connect_genesis_outputs=1", "-initialfreecoins={}".format(NUM_INITIAL_COINS * COIN), '-anyonecanspendaremine=1']]
 
     def skip_test_if_missing_module(self):
         self.skip_if_no_wallet()
diff --git a/test/functional/feature_default_asset_name.py b/test/functional/feature_default_asset_name.py
index 5718d3306d..a7c713f122 100755
--- a/test/functional/feature_default_asset_name.py
+++ b/test/functional/feature_default_asset_name.py
@@ -21,7 +21,7 @@ class NamedDefaultAssetTest(BitcoinTestFramework):
         self.num_nodes = 2
 
         #Set default asset name
-        self.extra_args = [["-defaultpeggedassetname=testasset", "-initialfreecoins=2100000000000000", "-anyonecanspendaremine=1", "-con_connect_coinbase=1", "-con_blocksubsidy=0"]]*2
+        self.extra_args = [["-defaultpeggedassetname=testasset", "-initialfreecoins=2100000000000000", "-anyonecanspendaremine=1", "-con_connect_genesis_outputs=1", "-con_blocksubsidy=0"]]*2
 
     def setup_network(self, split=False):
         self.setup_nodes()
diff --git a/test/functional/feature_initial_reissuance_token.py b/test/functional/feature_initial_reissuance_token.py
index 5c4a0a5e9a..77f12e7c6c 100755
--- a/test/functional/feature_initial_reissuance_token.py
+++ b/test/functional/feature_initial_reissuance_token.py
@@ -21,7 +21,7 @@ class InitialReissuanceTokenTest(BitcoinTestFramework):
         self.num_nodes = 2
 
         #Set number of initial reissuance tokens and also set initial free coins less than max so we can reissue more later
-        self.extra_args = [["-initialreissuancetokens=200000000", "-initialfreecoins=2000000000000000", "-anyonecanspendaremine=1", "-con_connect_coinbase=1", "-con_blocksubsidy=0", "-blindedaddresses=1"]]*2
+        self.extra_args = [["-initialreissuancetokens=200000000", "-initialfreecoins=2000000000000000", "-anyonecanspendaremine=1", "-con_connect_genesis_outputs=1", "-con_blocksubsidy=0", "-blindedaddresses=1"]]*2
 
     def skip_test_if_missing_module(self):
         self.skip_if_no_wallet()
diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py
index 580c7321e7..6a2a8c6123 100644
--- a/test/functional/test_framework/util.py
+++ b/test/functional/test_framework/util.py
@@ -322,7 +322,7 @@ def initialize_datadir(dirname, n, chain):
         f.write("validatepegin=0\n")
         f.write("con_parent_pegged_asset=" + BITCOIN_ASSET + "\n")
         f.write("con_blocksubsidy=5000000000\n")
-        f.write("con_connect_coinbase=0\n")
+        f.write("con_connect_genesis_outputs=0\n")
         f.write("anyonecanspendaremine=0\n")
         f.write("walletrbf=0\n") # Default is 1 in Elements
         f.write("con_bip34height=500\n")
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index 659aef9036..e31926a943 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -72,7 +72,7 @@ BASE_SCRIPTS = [
     'feature_fedpeg.py',
     'feature_mandatory_coinbase.py',
     'feature_block_subsidy.py',
-    'feature_connect_coinbase.py',
+    'feature_connect_genesis_outputs.py',
     'feature_block_v4.py',
     'feature_pak.py',
     'feature_blocksign.py',