GlcoinCore/cln
1
0
Fork 0
mirror of https://github.com/ElementsProject/lightning.git synced 2026-08-15 12:50:22 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
cln/wallet
History
Lagrang3 7e5cf41b4e htlc_wire: fix crash when adding an HTLC 
In line channeld/channeld_wiregen.c:832 `*added+i` is not a tal object hence
the instruction in common/htlc_wire.c:200 `tal_arr(ctx, struct tlv_field, 0);` crashes CLN.
This is fixed by stating that added_htlc is a a varsize_type.

Logs:

2025-08-16T02:25:28.640Z **BROKEN** lightningd: FATAL SIGNAL 6 (version v25.05-200-g79b959b)V
...
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:95 (call_error) 0x54f6bc
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:169 (check_bounds) 0x54f75a
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:178 (to_tal_hdr) 0x54f782
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:193 (to_tal_hdr_or_null) 0x54f7c7
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:471 (tal_alloc_) 0x54ffe4
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:517 (tal_alloc_arr_) 0x5500c4
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: common/htlc_wire.c:200 (fromwire_len_and_tlvstream) 0x48d63d
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: common/htlc_wire.c:234 (fromwire_added_htlc) 0x48dd23
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: channeld/channeld_wiregen.c:832 (fromwire_channeld_got_commitsig) 0x4c61fa
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/peer_htlcs.c:2377 (peer_got_commitsig) 0x4549cb
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/channel_control.c:1552 (channel_msg) 0x4140fe
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/subd.c:560 (sd_msg_read) 0x461513
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:60 (next_plan) 0x544885
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:422 (do_plan) 0x544cea
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:439 (io_ready) 0x544d9d
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/poll.c:455 (io_loop) 0x54665d
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/io_loop_with_timers.c:22 (io_loop_with_timers) 0x42d220
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/lightningd.c:1487 (main) 0x43280f

gdb inspection:
830             *added = num_added ? tal_arr(ctx, struct added_htlc, num_added) : NULL;
831             for (size_t i = 0; i < num_added; i++)
832                     fromwire_added_htlc(&cursor, &plen, *added + i);
(gdb) p i
$3 = 1

Changelog-None: crash introduced this release.
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
[ Added test, removed Changelog --RR ]
2025-08-27 14:14:31 +09:30
..
test htlc_wire: fix crash when adding an HTLC 2025-08-27 14:14:31 +09:30
.gitignore reorganize .gitignore entries across subdirs. 2021-05-18 09:43:50 +09:30
account_migration.c lightningd: allow account db version 18. 2025-08-21 13:21:17 +09:30
account_migration.h lightningd: migrate events from bookkeeper at startup. 2025-08-19 13:37:50 +09:30
db.c lightningd: migrate events from bookkeeper at startup. 2025-08-19 13:37:50 +09:30
db.h db: migrate old runes table to fix up id fields. 2023-08-31 05:33:15 +09:30
invoices.c lightningd: migrate events from bookkeeper at startup. 2025-08-19 13:37:50 +09:30
invoices.h lightningd: remove delexpiredinvoice 2024-03-25 15:02:35 +10:30
Makefile lightningd: migrate events from bookkeeper at startup. 2025-08-19 13:37:50 +09:30
psbt_fixup.c wallet/psbt_fixup: routine to fix invalid PBSTs which modern libwally won't load. 2023-03-31 09:16:25 +10:30
psbt_fixup.h wallet/psbt_fixup: routine to fix invalid PBSTs which modern libwally won't load. 2023-03-31 09:16:25 +10:30
reservation.c common/utxo: use a real type for the UTXO, not a boolean is_p2sh. 2025-05-06 12:27:53 +09:30
txfilter.c wallet: create htable to store scriptpubkeys for issued indexes. 2025-02-13 15:42:51 -06:00
txfilter.h wallet: create htable to store scriptpubkeys for issued indexes. 2025-02-13 15:42:51 -06:00
wallet.c wallet: generate fixup chainmoves and channelmoves when first starting. 2025-08-19 13:37:50 +09:30
wallet.h lightningd: migrate events from bookkeeper at startup. 2025-08-19 13:37:50 +09:30
walletrpc.c wallet: record all coin movements into chain_moves or channel_moves tables. 2025-08-19 13:37:50 +09:30
walletrpc.h wallet: save keytype when issuing new address. 2024-11-17 20:27:13 +10:30