mirror of
https://github.com/ZmnSCPxj/clboss.git
synced 2026-08-13 12:33:20 +02:00
The pre-v26.06 getroutes compatibility fallback read the deprecated per-hop fields (next_node_id / amount_msat / delay), whose values CLN defines as the in-side of each hop -- one hop shifted from the out-side values (node_id_out / amount_out_msat / cltv_out, shipped in v26.06) that sendpay routes must be built from. On stock CLN v24.11..v26.04 the fallback therefore built mispriced routes: small overpays on the routes that survived, spurious FEE_INSUFFICIENT / INCORRECT_CLTV_EXPIRY failures on the rest, and -- worst -- those failures hard-excluded healthy channels in the persistent failure-learning layer for hours, compounding across restarts. Drop the fallback entirely and enforce the requirement twice: - Initiator gains a CLN version gate, ordered before the database and signer steps so a refusal leaves no on-disk trace: a getinfo version older than v26.06 logs a detailed Error and aborts. The new clboss-skip-cln-version-check flag bypasses the gate for operators whose older CLN carries a backport of the v26.06 getroutes fields (the version string alone cannot show that); an unparseable version string warns and proceeds rather than locking out custom builds. - The three getroutes parse sites (FundsMover/Attempter, ActiveProber, ChannelCandidateMatchmaker) verify the new fields on every response and fail the attempt with a clear Error if absent, so a mistakenly bypassed gate degrades into loud per-attempt failures rather than shifted routes. CHANGELOG.md gains a prominent BREAKING entry; README documents the requirement and the escape hatch. Users on older CLN releases stay on CLBOSS 0.16.x, which uses the legacy getroute/pay APIs those versions still provide.
229 lines
5.9 KiB
C++
229 lines
5.9 KiB
C++
#include"Boss/Mod/ChannelCandidateMatchmaker.hpp"
|
|
#include"Boss/Mod/Rpc.hpp"
|
|
#include"Boss/Msg/AmountSettings.hpp"
|
|
#include"Boss/Msg/Init.hpp"
|
|
#include"Boss/Msg/PatronizeChannelCandidate.hpp"
|
|
#include"Boss/Msg/PreinvestigateChannelCandidates.hpp"
|
|
#include"Boss/Msg/ProposeChannelCandidates.hpp"
|
|
#include"Boss/concurrent.hpp"
|
|
#include"Boss/log.hpp"
|
|
#include"Ev/Io.hpp"
|
|
#include"Ev/yield.hpp"
|
|
#include"Jsmn/Object.hpp"
|
|
#include"Json/Out.hpp"
|
|
#include"Ln/Amount.hpp"
|
|
#include"Ln/NodeId.hpp"
|
|
#include"S/Bus.hpp"
|
|
#include<memory>
|
|
#include<sstream>
|
|
|
|
namespace Boss { namespace Mod {
|
|
|
|
/* This is effectively a single run of the matchmaker. */
|
|
class ChannelCandidateMatchmaker::Run
|
|
: public std::enable_shared_from_this<Run> {
|
|
private:
|
|
S::Bus& bus;
|
|
Boss::Mod::Rpc& rpc;
|
|
|
|
Ln::NodeId proposal;
|
|
std::queue<Ln::NodeId> guide;
|
|
|
|
Ln::Amount min_channel;
|
|
|
|
explicit
|
|
Run( S::Bus& bus_
|
|
, Boss::Mod::Rpc& rpc_
|
|
, Ln::NodeId proposal_
|
|
, std::queue<Ln::NodeId> guide_
|
|
, Ln::Amount min_channel_
|
|
) : bus(bus_)
|
|
, rpc(rpc_)
|
|
, proposal(std::move(proposal_))
|
|
, guide(std::move(guide_))
|
|
, min_channel(min_channel_)
|
|
{ }
|
|
|
|
public:
|
|
Run() =delete;
|
|
Run(Run&&) =delete;
|
|
Run(Run const&) =delete;
|
|
|
|
static
|
|
std::shared_ptr<Run>
|
|
create( S::Bus& bus
|
|
, Boss::Mod::Rpc& rpc
|
|
, Ln::NodeId proposal
|
|
, std::queue<Ln::NodeId> guide
|
|
, Ln::Amount min_channel
|
|
) {
|
|
return std::shared_ptr<Run>(
|
|
new Run( bus
|
|
, rpc
|
|
, std::move(proposal)
|
|
, std::move(guide)
|
|
, min_channel
|
|
)
|
|
);
|
|
}
|
|
|
|
Ev::Io<void> run() {
|
|
auto self = shared_from_this();
|
|
return self->core_run().then([self]() {
|
|
return Ev::lift();
|
|
});
|
|
}
|
|
private:
|
|
Ev::Io<void> core_run() {
|
|
return Ev::yield().then([this]() {
|
|
if (guide.empty())
|
|
/* Failed. */
|
|
return Boss::log( bus, Debug
|
|
, "ChannelCandidateMatchmaker:"
|
|
" Could not find patron for "
|
|
"%s."
|
|
, std::string(proposal
|
|
).c_str()
|
|
);
|
|
|
|
return step();
|
|
});
|
|
}
|
|
Ev::Io<void> step() {
|
|
auto target = std::move(guide.front());
|
|
guide.pop();
|
|
|
|
auto probe_amount = 2.0 * min_channel;
|
|
auto parms = Json::Out()
|
|
.start_object()
|
|
.field("source", std::string(proposal))
|
|
.field("destination", std::string(target))
|
|
/* 2x min_channel because the dowser will
|
|
* halve the channel capacity of the first
|
|
* hop.
|
|
*/
|
|
.field("amount_msat", probe_amount.to_msat())
|
|
/* No layers: source is a remote node
|
|
* (proposal), not us, so the
|
|
* auto.localchans / auto.sourcefree
|
|
* helpers do not apply -- they would
|
|
* inject our private local channels and
|
|
* zero out the source's outgoing fees,
|
|
* either of which could make askrene
|
|
* pick a patron that the proposal cannot
|
|
* actually reach via public topology.
|
|
*/
|
|
.start_array("layers").end_array()
|
|
/* Generous max-fee tolerance for what is a
|
|
* route-discovery probe, not an actual
|
|
* payment.
|
|
*/
|
|
.field("maxfee_msat",
|
|
(probe_amount * 0.01).to_msat())
|
|
.field("final_cltv", 14)
|
|
.field("maxparts", 1)
|
|
.end_object()
|
|
;
|
|
return rpc.command("getroutes", std::move(parms)
|
|
).then([this](Jsmn::Object res) {
|
|
auto patron = Ln::NodeId();
|
|
try {
|
|
/* getroutes' path[K].node_id_out shipped in
|
|
* CLN v26.06. No fallback to the
|
|
* deprecated next_node_id: the Initiator
|
|
* version gate refuses stock older CLN at
|
|
* startup, and this check keeps a bypassed
|
|
* gate (clboss-skip-cln-version-check)
|
|
* loud instead of subtly wrong.
|
|
*/
|
|
auto path0 = res["routes"][0]["path"][0];
|
|
if (!path0.has("node_id_out"))
|
|
return Boss::log( bus, Error
|
|
, "ChannelCandidateMatchmaker: "
|
|
"getroutes hop lacks "
|
|
"node_id_out; CLBOSS "
|
|
"requires CLN v26.06+ (or "
|
|
"a backport of the "
|
|
"getroutes fields)."
|
|
).then([]()
|
|
-> Ev::Io<void>{
|
|
throw RpcError( "getroutes"
|
|
, Jsmn::Object()
|
|
);
|
|
});
|
|
patron = Ln::NodeId(std::string(
|
|
path0["node_id_out"]
|
|
));
|
|
} catch (std::exception const&) {
|
|
/* Jsmn::TypeError from the field access OR
|
|
* std::range_error (via BacktraceException)
|
|
* from Ln::NodeId on a malformed id -- both
|
|
* mean an unexpected getroutes result; log and
|
|
* route to the retry path rather than aborting
|
|
* the run. */
|
|
auto os = std::ostringstream();
|
|
os << res;
|
|
return Boss::log( bus, Error
|
|
, "ChannelCandidateMatchmaker:"
|
|
" Unexpected result from "
|
|
"getroutes: %s"
|
|
, os.str().c_str()
|
|
).then([]()
|
|
-> Ev::Io<void>{
|
|
throw RpcError( "getroutes"
|
|
, Jsmn::Object()
|
|
);
|
|
});
|
|
}
|
|
auto act = Ev::lift();
|
|
act += Boss::log( bus, Debug
|
|
, "ChannelCandidateMatchmaker: "
|
|
"Matched proposal %s to patron %s."
|
|
, std::string(proposal).c_str()
|
|
, std::string(patron).c_str()
|
|
);
|
|
auto propose = Msg::ProposeChannelCandidates{
|
|
std::move(proposal), std::move(patron)
|
|
};
|
|
auto preinv = Msg::PreinvestigateChannelCandidates{
|
|
{std::move(propose)},
|
|
1
|
|
};
|
|
act += bus.raise(std::move(preinv));
|
|
return act;
|
|
}).catching<RpcError>([this](RpcError const&) {
|
|
/* Try next. */
|
|
return core_run();
|
|
});
|
|
}
|
|
};
|
|
|
|
void ChannelCandidateMatchmaker::start() {
|
|
bus.subscribe<Msg::AmountSettings
|
|
>([this](Msg::AmountSettings const& r) {
|
|
min_channel = r.min_channel;
|
|
return Ev::lift();
|
|
});
|
|
bus.subscribe<Msg::Init
|
|
>([this](Msg::Init const& init) {
|
|
rpc = &init.rpc;
|
|
return Ev::lift();
|
|
});
|
|
bus.subscribe<Msg::PatronizeChannelCandidate
|
|
>([this](Msg::PatronizeChannelCandidate const& m) {
|
|
if (!rpc)
|
|
return Ev::lift();
|
|
|
|
/* Construct queue. */
|
|
auto q = std::queue<Ln::NodeId>();
|
|
for (auto const& n : m.guide)
|
|
q.push(n);
|
|
/* Create run object. */
|
|
auto run = Run::create( bus, *rpc, m.proposal, std::move(q)
|
|
, min_channel
|
|
);
|
|
return Boss::concurrent(run->run());
|
|
});
|
|
}
|
|
|
|
}}
|