From de45be31a335d693034d0a2bf4487ee672ebec28 Mon Sep 17 00:00:00 2001 From: Ken Sedgwick Date: Wed, 17 Dec 2025 09:35:45 -0800 Subject: [PATCH] Add missing runtime dependencies and fix structure of dev shell MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit coderabbit: 1. The main buildInputs (libev, libunwind, curlWithGnuTls, sqlite) from lines 31-36 are not included—developers won't be able to build/link the project in this shell. 2. autoconf-archive is duplicated (line 80 and already inherited via nativeBuildInputs). 3. libevdev (line 77) is a different library than libev—verify this is intentional. --- flake.nix | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/flake.nix b/flake.nix index 303aeb1..e443699 100644 --- a/flake.nix +++ b/flake.nix @@ -69,22 +69,16 @@ devShells.default = pkgs.mkShell { inherit nativeBuildInputs; - buildInputs = - with pkgs; - nativeBuildInputs - ++ [ - gcc - libevdev - bind - autoconf - autoconf-archive - libtool - automake - git - - # editor support - bear - ]; + buildInputs = buildInputs ++ (with pkgs; [ + gcc + bind + autoconf + libtool + automake + git + # editor support + bear + ]); }; } );