From d90ca280efc9cd5013dbadd491aa0305fa2b7678 Mon Sep 17 00:00:00 2001 From: Ken Sedgwick Date: Wed, 4 Mar 2026 11:10:33 -0800 Subject: [PATCH] fix: initialize ReservoirSampler::wsum to silence build warning GCC's deeper inlining at -O2 detects that wsum may be used uninitialized when ReservoirSampler::add() is inlined into JitRebalancer. Debug builds (-Og) don't trigger this because GCC doesn't inline deeply enough. The value is overwritten on the first add() call, so this is purely to satisfy the compiler. --- Stats/ReservoirSampler.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Stats/ReservoirSampler.hpp b/Stats/ReservoirSampler.hpp index 1e65a32..51d2d64 100644 --- a/Stats/ReservoirSampler.hpp +++ b/Stats/ReservoirSampler.hpp @@ -26,10 +26,10 @@ private: Weight wsum; public: - ReservoirSampler() : max_selected(1) { } + ReservoirSampler() : max_selected(1), wsum(0) { } explicit ReservoirSampler(std::size_t max_selected_ - ) : max_selected(max_selected_) { } + ) : max_selected(max_selected_), wsum(0) { } ReservoirSampler(ReservoirSampler&&) =default; ReservoirSampler(ReservoirSampler const&) =default;