f07099488d
In this commit, we update TxPool's internal validation methods to call the newly extracted standalone validation functions in policy.go. This removes code duplication and ensures both TxPool and TxMempoolV2 use identical validation logic. The validateSegWitDeployment method now delegates to CheckSegWitDeployment, passing the necessary deployment checker, chain parameters, and best height. This reduces the method from 30 lines to a simple delegation call while maintaining identical behavior. The validateSigCost method now calls CheckTransactionSigCost, passing the configured maximum signature operation cost. The standalone function handles all the blockchain.GetSigOpCost logic and error wrapping that was previously inline. The validateRelayFeeMet method has been simplified to call CheckRelayFee for the core fee and priority validation, then handle rate limiting separately. This separation of concerns makes the rate limiting logic more obvious, as it only applies after the minimum fee checks pass. The rate limiting code remains in TxPool since it maintains per-pool state (mp.pennyTotal) that is specific to the legacy implementation. These changes maintain full backward compatibility with existing behavior while enabling TxMempoolV2 to reuse the same validation logic without reimplementing it. All error messages and rejection codes remain identical to preserve RPC compatibility. |
||
|---|---|---|
| .. | ||
| txgraph | ||
| doc.go | ||
| error.go | ||
| estimatefee.go | ||
| estimatefee_test.go | ||
| interface.go | ||
| log.go | ||
| mempool.go | ||
| mempool_test.go | ||
| mempool_v2.go | ||
| mempool_v2_test.go | ||
| mocks.go | ||
| orphan.go | ||
| orphan_test.go | ||
| policy.go | ||
| policy_enforcer.go | ||
| policy_enforcer_test.go | ||
| policy_test.go | ||
| README.md | ||
mempool
Package mempool provides a policy-enforced pool of unmined bitcoin transactions.
A key responsibility of the bitcoin network is mining user-generated transactions into blocks. In order to facilitate this, the mining process relies on having a readily-available source of transactions to include in a block that is being solved.
At a high level, this package satisfies that requirement by providing an in-memory pool of fully validated transactions that can also optionally be further filtered based upon a configurable policy.
One of the policy configuration options controls whether or not "standard" transactions are accepted. In essence, a "standard" transaction is one that satisfies a fairly strict set of requirements that are largely intended to help provide fair use of the system to all users. It is important to note that what is considered a "standard" transaction changes over time. For some insight, at the time of this writing, an example of some of the criteria that are required for a transaction to be considered standard are that it is of the most-recently supported version, finalized, does not exceed a specific size, and only consists of specific script forms.
Since this package does not deal with other bitcoin specifics such as network communication and transaction relay, it returns a list of transactions that were accepted which gives the caller a high level of flexibility in how they want to proceed. Typically, this will involve things such as relaying the transactions to other peers on the network and notifying the mining process that new transactions are available.
This package has intentionally been designed so it can be used as a standalone package for any projects needing the ability create an in-memory pool of bitcoin transactions that are not only valid by consensus rules, but also adhere to a configurable policy.
Feature Overview
The following is a quick overview of the major features. It is not intended to be an exhaustive list.
- Maintain a pool of fully validated transactions
- Reject non-fully-spent duplicate transactions
- Reject coinbase transactions
- Reject double spends (both from the chain and other transactions in pool)
- Reject invalid transactions according to the network consensus rules
- Full script execution and validation with signature cache support
- Individual transaction query support
- Orphan transaction support (transactions that spend from unknown outputs)
- Configurable limits (see transaction acceptance policy)
- Automatic addition of orphan transactions that are no longer orphans as new transactions are added to the pool
- Individual orphan transaction query support
- Configurable transaction acceptance policy
- Option to accept or reject standard transactions
- Option to accept or reject transactions based on priority calculations
- Rate limiting of low-fee and free transactions
- Non-zero fee threshold
- Max signature operations per transaction
- Max orphan transaction size
- Max number of orphan transactions allowed
- Additional metadata tracking for each transaction
- Timestamp when the transaction was added to the pool
- Most recent block height when the transaction was added to the pool
- The fee the transaction pays
- The starting priority for the transaction
- Manual control of transaction removal
- Recursive removal of all dependent transactions
Installation and Updating
$ go get -u github.com/btcsuite/btcd/mempool
License
Package mempool is licensed under the copyfree ISC License.