mirror of
https://github.com/btcsuite/btcd.git
synced 2026-08-13 12:32:51 +02:00
7e9414fa6c
In this commit, we reject maxpeers values that cannot represent a usable peer budget. A zero value reached connmgr as TargetOutbound=0, where zero means to use the default target of eight. The server then rejected every completed peer and immediately created a replacement request. Rejecting the value during configuration avoids that outbound reconnect loop.
85 lines
2 KiB
Go
85 lines
2 KiB
Go
package main
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"regexp"
|
|
"runtime"
|
|
"testing"
|
|
)
|
|
|
|
func TestValidateMaxPeers(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
maxPeers int
|
|
wantErr bool
|
|
}{
|
|
{name: "negative", maxPeers: -1, wantErr: true},
|
|
{name: "zero", wantErr: true},
|
|
{name: "positive", maxPeers: 1},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
err := validateMaxPeers(test.maxPeers)
|
|
if test.wantErr && err == nil {
|
|
t.Fatal("expected validation error")
|
|
}
|
|
if !test.wantErr && err != nil {
|
|
t.Fatalf("unexpected validation error: %v", err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
var (
|
|
rpcuserRegexp = regexp.MustCompile("(?m)^rpcuser=.+$")
|
|
rpcpassRegexp = regexp.MustCompile("(?m)^rpcpass=.+$")
|
|
)
|
|
|
|
func TestCreateDefaultConfigFile(t *testing.T) {
|
|
// find out where the sample config lives
|
|
_, path, _, ok := runtime.Caller(0)
|
|
if !ok {
|
|
t.Fatalf("Failed finding config file path")
|
|
}
|
|
sampleConfigFile := filepath.Join(filepath.Dir(path), "sample-btcd.conf")
|
|
|
|
// Setup a temporary directory
|
|
tmpDir := t.TempDir()
|
|
testpath := filepath.Join(tmpDir, "test.conf")
|
|
|
|
// copy config file to location of btcd binary
|
|
data, err := os.ReadFile(sampleConfigFile)
|
|
if err != nil {
|
|
t.Fatalf("Failed reading sample config file: %v", err)
|
|
}
|
|
appPath, err := filepath.Abs(filepath.Dir(os.Args[0]))
|
|
if err != nil {
|
|
t.Fatalf("Failed obtaining app path: %v", err)
|
|
}
|
|
tmpConfigFile := filepath.Join(appPath, "sample-btcd.conf")
|
|
err = os.WriteFile(tmpConfigFile, data, 0644)
|
|
if err != nil {
|
|
t.Fatalf("Failed copying sample config file: %v", err)
|
|
}
|
|
|
|
err = createDefaultConfigFile(testpath)
|
|
|
|
if err != nil {
|
|
t.Fatalf("Failed to create a default config file: %v", err)
|
|
}
|
|
|
|
content, err := os.ReadFile(testpath)
|
|
if err != nil {
|
|
t.Fatalf("Failed to read generated default config file: %v", err)
|
|
}
|
|
|
|
if !rpcuserRegexp.Match(content) {
|
|
t.Error("Could not find rpcuser in generated default config file.")
|
|
}
|
|
|
|
if !rpcpassRegexp.Match(content) {
|
|
t.Error("Could not find rpcpass in generated default config file.")
|
|
}
|
|
}
|