GlcoinCore/btcd
1
0
Fork 0
mirror of https://github.com/btcsuite/btcd.git synced 2026-08-13 12:32:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

netsync: allow sync with non-localhost peers on regtest/simnet

Browse source 
In this commit, we remove the localhost-only restriction for sync peer
candidates on regtest and simnet. Previously, isSyncCandidate rejected
any regtest peer not on 127.0.0.1 or localhost, which prevented IBD
when nodes run in Docker containers on bridge networks (e.g. 172.18.0.x).

We also replace fragile pointer-equality checks against global chaincfg
params with value-based Name field comparisons, and extend the exception
to simnet since it has the same local-only usage pattern.
This commit is contained in:
Abdullahi Yunus 2026-02-23 10:29:06 +01:00 • committed by Olaoluwa Osuntokun
parent c70d6b9026
commit 26124d2754
1 changed files with 7 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

22
netsync/manager.go
View file

@ -6,7 +6,6 @@ package netsync
import (
"math/rand"
"net"
"sync"
"sync/atomic"
"time"
@ -364,19 +363,12 @@ func (sm *SyncManager) isSyncCandidate(peer *peerpkg.Peer) bool {
// Typically a peer is not a candidate for sync if it's not a full node,
// however regression test is special in that the regression tool is
// not a full node and still needs to be considered a sync candidate.
if sm.chainParams == &chaincfg.RegressionNetParams {
// The peer is not a candidate if it's not coming from localhost
// or the hostname can't be determined for some reason.
host, _, err := net.SplitHostPort(peer.Addr())
if err != nil {
return false
}
if host != "127.0.0.1" && host != "localhost" {
return false
}
// Candidate if all checks passed.
switch sm.chainParams.Name {
case chaincfg.RegressionNetParams.Name, chaincfg.SimNetParams.Name:
// In regtest/simnet mode, any peer is a valid sync candidate
// regardless of its address or service flags. This allows
// syncing from peers on non-localhost networks such as Docker
// bridge networks.
return true
}
@ -715,7 +707,7 @@ func (sm *SyncManager) handleBlockMsg(bmsg *blockMsg) {
// the peer or ignore the block when we're in regression test
// mode in this case so the chain code is actually fed the
// duplicate blocks.
if sm.chainParams != &chaincfg.RegressionNetParams {
if sm.chainParams.Name != chaincfg.RegressionNetParams.Name {
log.Warnf("Got unrequested block %v from %s -- "+
"disconnecting", blockHash, peer.Addr())
peer.Disconnect()