From 3f8860999b993560b3bafe4bf1a0e629f6589258 Mon Sep 17 00:00:00 2001
From: Stefan Stammberger <some.fusion@gmail.com>
Date: Wed, 27 Oct 2021 19:23:21 +0200
Subject: [PATCH] fix: sse message composition

---
 app/main.py  | 24 ++++++++++++++++--------
 app/utils.py |  6 +-----
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/app/main.py b/app/main.py
index e930578..8aafe55 100644
--- a/app/main.py
+++ b/app/main.py
@@ -1,7 +1,9 @@
 import asyncio
+import json
 
 from aioredis import Channel, Redis
 from fastapi import FastAPI, Request
+from fastapi.encoders import jsonable_encoder
 from fastapi_plugins import (
     RedisSettings,
     get_config,
@@ -22,7 +24,7 @@ from app.repositories.system import register_hardware_info_gatherer
 from app.repositories.utils import get_client_warmup_data
 from app.routers import apps, bitcoin, lightning, setup, system
 from app.sse_starlette import EventSourceResponse
-from app.utils import SSE, convert_json
+from app.utils import SSE
 
 
 @registered_configuration
@@ -109,17 +111,23 @@ async def warmup_new_connections():
     for c in new_connections:
         await asyncio.gather(
             *[
-                c.put({"id": SSE.SYSTEM_INFO, "data": convert_json(res[0].dict())}),
-                c.put({"id": SSE.BTC_INFO, "data": convert_json(res[1].dict())}),
-                c.put({"id": SSE.LN_INFO_LITE, "data": convert_json(res[2].dict())}),
-                c.put({"id": SSE.WALLET_BALANCE, "data": convert_json(res[3].dict())}),
-                c.put({"id": SSE.INSTALLED_APP_STATUS, "data": convert_json(res[4])}),
+                c.put(_make_evt_data(SSE.SYSTEM_INFO, res[0].dict())),
+                c.put(_make_evt_data(SSE.BTC_INFO, res[1].dict())),
+                c.put(_make_evt_data(SSE.LN_INFO_LITE, res[2].dict())),
+                c.put(_make_evt_data(SSE.WALLET_BALANCE, res[3].dict())),
+                c.put(_make_evt_data(SSE.INSTALLED_APP_STATUS, res[4])),
             ]
         )
 
     new_connections.clear()
 
 
+def _make_evt_data(evt: SSE, data):
+    d1 = {"event": evt, "data": json.dumps(jsonable_encoder(data))}
+    # d2 = {"event": evt, "data": jsonable_encoder(data)}
+    return d1
+
+
 async def subscribe(request: Request, id: int, q: asyncio.Queue):
     try:
         while True:
@@ -128,7 +136,7 @@ async def subscribe(request: Request, id: int, q: asyncio.Queue):
                 await request.close()
                 break
             else:
-                data = await q.get()
+                data = jsonable_encoder(await q.get())
                 yield data
     except asyncio.CancelledError as e:
         connections.pop(id)
@@ -148,7 +156,7 @@ async def register_all_handlers(redis: Redis):
 
 async def broadcast_data_sse(sub):
     while await sub.wait_message():
-        data = await sub.get(encoding="utf-8")
+        data = json.loads(await sub.get(encoding="utf-8"))
         for k in connections.keys():
             if connections.get(k):
                 await connections.get(k).put(data)
diff --git a/app/utils.py b/app/utils.py
index 3b89fd2..065ee2a 100644
--- a/app/utils.py
+++ b/app/utils.py
@@ -123,10 +123,6 @@ async def bitcoin_rpc_async(method: str, params: list = []) -> coroutine:
             return await resp.json()
 
 
-def convert_json(dict):
-    return json.dumps(jsonable_encoder(dict))
-
-
 async def send_sse_message(id: str, json_data: Dict):
     """Send a message to any SSE connections
 
@@ -139,7 +135,7 @@ async def send_sse_message(id: str, json_data: Dict):
     """
 
     await redis_plugin.redis.publish_json(
-        "default", {"id": id, "data": jsonable_encoder(json_data)}
+        "default", {"event": id, "data": json.dumps(jsonable_encoder(json_data))}
     )