alby-hub/nip47/controllers/get_info_controller_test.go
Adithya Vardhan a2af8fd598
fix: return optional total balance in list apps response for subwallets (#2057)
* fix: return optional total balance in list apps response for subwallets

* chore: add error handling to subwallet balance query

* chore: add METADATA_APPSTORE_APP_ID_KEY constant

* chore: add MAX_FREE_SUBWALLETS constant

* chore: use subwallet query and total count for limit check
2026-02-26 12:25:06 +05:30

353 lines
11 KiB
Go

package controllers
import (
"context"
"encoding/json"
"testing"
"github.com/nbd-wtf/go-nostr"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/getAlby/hub/config"
"github.com/getAlby/hub/constants"
"github.com/getAlby/hub/db"
"github.com/getAlby/hub/nip47/models"
"github.com/getAlby/hub/tests"
)
const nip47GetInfoJson = `
{
"method": "get_info"
}
`
func TestHandleGetInfoEvent_NoPermission(t *testing.T) {
ctx := context.TODO()
svc, err := tests.CreateTestService(t)
require.NoError(t, err)
defer svc.Remove()
app, _, err := tests.CreateApp(svc)
assert.NoError(t, err)
lightningAddress := "hello@getalby.com"
svc.Cfg.SetUpdate("AlbyLightningAddress", lightningAddress, "")
nip47Request := &models.Request{}
err = json.Unmarshal([]byte(nip47GetInfoJson), nip47Request)
assert.NoError(t, err)
dbRequestEvent := &db.RequestEvent{}
err = svc.DB.Create(&dbRequestEvent).Error
assert.NoError(t, err)
// delete the existing app permissions (the app was created with get_info scope)
svc.DB.Exec("delete from app_permissions")
appPermission := &db.AppPermission{
AppId: app.ID,
Scope: constants.GET_BALANCE_SCOPE,
ExpiresAt: nil,
}
err = svc.DB.Create(appPermission).Error
assert.NoError(t, err)
var publishedResponse *models.Response
publishResponse := func(response *models.Response, tags nostr.Tags) {
publishedResponse = response
}
NewTestNip47Controller(svc).
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)
assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Nil(t, nodeInfo.Alias)
assert.Nil(t, nodeInfo.Color)
assert.Nil(t, nodeInfo.Pubkey)
assert.Nil(t, nodeInfo.Network)
assert.Nil(t, nodeInfo.BlockHeight)
assert.Nil(t, nodeInfo.BlockHash)
assert.Nil(t, nodeInfo.LightningAddress)
// get_info method is always granted, but does not return pubkey
assert.Contains(t, nodeInfo.Methods, models.GET_INFO_METHOD)
assert.Equal(t, []string{}, nodeInfo.Notifications)
}
func TestHandleGetInfoEvent_SubwalletNoPermission(t *testing.T) {
ctx := context.TODO()
svc, err := tests.CreateTestService(t)
require.NoError(t, err)
defer svc.Remove()
lightningAddress := "hello@getalby.com"
metadata := map[string]interface{}{
constants.METADATA_APPSTORE_APP_ID_KEY: constants.SUBWALLET_APPSTORE_APP_ID,
"lud16": lightningAddress,
}
svc.Cfg.SetUpdate("LNBackendType", config.LDKBackendType, "")
app, _, err := svc.AppsService.CreateApp("test", "", 0, "monthly", nil, []string{constants.GET_INFO_SCOPE}, true, metadata)
assert.NoError(t, err)
nip47Request := &models.Request{}
err = json.Unmarshal([]byte(nip47GetInfoJson), nip47Request)
assert.NoError(t, err)
dbRequestEvent := &db.RequestEvent{}
err = svc.DB.Create(&dbRequestEvent).Error
assert.NoError(t, err)
// delete the existing app permissions (the app was created with get_info scope)
svc.DB.Exec("delete from app_permissions")
appPermission := &db.AppPermission{
AppId: app.ID,
Scope: constants.GET_BALANCE_SCOPE,
ExpiresAt: nil,
}
err = svc.DB.Create(appPermission).Error
assert.NoError(t, err)
var publishedResponse *models.Response
publishResponse := func(response *models.Response, tags nostr.Tags) {
publishedResponse = response
}
NewTestNip47Controller(svc).
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)
assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Nil(t, nodeInfo.Alias)
assert.Nil(t, nodeInfo.Color)
assert.Nil(t, nodeInfo.Pubkey)
assert.Nil(t, nodeInfo.Network)
assert.Nil(t, nodeInfo.BlockHeight)
assert.Nil(t, nodeInfo.BlockHash)
assert.Nil(t, nodeInfo.LightningAddress)
// get_info method is always granted, but does not return pubkey
assert.Contains(t, nodeInfo.Methods, models.GET_INFO_METHOD)
assert.Equal(t, []string{}, nodeInfo.Notifications)
}
func TestHandleGetInfoEvent_WithPermission(t *testing.T) {
ctx := context.TODO()
svc, err := tests.CreateTestService(t)
require.NoError(t, err)
defer svc.Remove()
app, _, err := tests.CreateApp(svc)
assert.NoError(t, err)
nip47Request := &models.Request{}
err = json.Unmarshal([]byte(nip47GetInfoJson), nip47Request)
assert.NoError(t, err)
dbRequestEvent := &db.RequestEvent{}
err = svc.DB.Create(&dbRequestEvent).Error
assert.NoError(t, err)
appPermission := &db.AppPermission{
AppId: app.ID,
Scope: constants.GET_INFO_SCOPE,
ExpiresAt: nil,
}
err = svc.DB.Create(appPermission).Error
assert.NoError(t, err)
var publishedResponse *models.Response
publishResponse := func(response *models.Response, tags nostr.Tags) {
publishedResponse = response
}
NewTestNip47Controller(svc).
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)
assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{}, nodeInfo.Notifications)
}
func TestHandleGetInfoEvent_WithMetadata(t *testing.T) {
ctx := context.TODO()
svc, err := tests.CreateTestService(t)
require.NoError(t, err)
defer svc.Remove()
lightningAddress := "hello@getalby.com"
svc.Cfg.SetUpdate("AlbyLightningAddress", lightningAddress, "")
metadata := map[string]interface{}{
"a": 123,
}
app, _, err := svc.AppsService.CreateApp("test", "", 0, "monthly", nil, []string{constants.GET_INFO_SCOPE}, false, metadata)
assert.NoError(t, err)
nip47Request := &models.Request{}
err = json.Unmarshal([]byte(nip47GetInfoJson), nip47Request)
assert.NoError(t, err)
dbRequestEvent := &db.RequestEvent{}
err = svc.DB.Create(&dbRequestEvent).Error
assert.NoError(t, err)
appPermission := &db.AppPermission{
AppId: app.ID,
Scope: constants.GET_INFO_SCOPE,
ExpiresAt: nil,
}
err = svc.DB.Create(appPermission).Error
assert.NoError(t, err)
var publishedResponse *models.Response
publishResponse := func(response *models.Response, tags nostr.Tags) {
publishedResponse = response
}
NewTestNip47Controller(svc).
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)
assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Equal(t, lightningAddress, *nodeInfo.LightningAddress)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{}, nodeInfo.Notifications)
assert.NoError(t, err)
assert.Equal(t, float64(123), nodeInfo.Metadata.(map[string]interface{})["a"])
}
func TestHandleGetInfoEvent_SubwalletWithMetadata(t *testing.T) {
ctx := context.TODO()
svc, err := tests.CreateTestService(t)
require.NoError(t, err)
defer svc.Remove()
lightningAddress := "hello@getalby.com"
metadata := map[string]interface{}{
constants.METADATA_APPSTORE_APP_ID_KEY: constants.SUBWALLET_APPSTORE_APP_ID,
"lud16": lightningAddress,
"a": 123,
}
svc.Cfg.SetUpdate("LNBackendType", config.LDKBackendType, "")
app, _, err := svc.AppsService.CreateApp("test", "", 0, "monthly", nil, []string{constants.GET_INFO_SCOPE}, true, metadata)
assert.NoError(t, err)
nip47Request := &models.Request{}
err = json.Unmarshal([]byte(nip47GetInfoJson), nip47Request)
assert.NoError(t, err)
dbRequestEvent := &db.RequestEvent{}
err = svc.DB.Create(&dbRequestEvent).Error
assert.NoError(t, err)
appPermission := &db.AppPermission{
AppId: app.ID,
Scope: constants.GET_INFO_SCOPE,
ExpiresAt: nil,
}
err = svc.DB.Create(appPermission).Error
assert.NoError(t, err)
var publishedResponse *models.Response
publishResponse := func(response *models.Response, tags nostr.Tags) {
publishedResponse = response
}
NewTestNip47Controller(svc).
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)
assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Equal(t, lightningAddress, *nodeInfo.LightningAddress)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{}, nodeInfo.Notifications)
assert.NoError(t, err)
assert.Equal(t, float64(123), nodeInfo.Metadata.(map[string]interface{})["a"])
}
func TestHandleGetInfoEvent_WithNotifications(t *testing.T) {
ctx := context.TODO()
svc, err := tests.CreateTestService(t)
require.NoError(t, err)
defer svc.Remove()
app, _, err := tests.CreateApp(svc)
assert.NoError(t, err)
nip47Request := &models.Request{}
err = json.Unmarshal([]byte(nip47GetInfoJson), nip47Request)
assert.NoError(t, err)
dbRequestEvent := &db.RequestEvent{}
err = svc.DB.Create(&dbRequestEvent).Error
assert.NoError(t, err)
appPermission := &db.AppPermission{
AppId: app.ID,
Scope: constants.GET_INFO_SCOPE,
ExpiresAt: nil,
}
err = svc.DB.Create(appPermission).Error
assert.NoError(t, err)
appPermission = &db.AppPermission{
AppId: app.ID,
Scope: constants.NOTIFICATIONS_SCOPE,
ExpiresAt: nil,
}
err = svc.DB.Create(appPermission).Error
assert.NoError(t, err)
var publishedResponse *models.Response
publishResponse := func(response *models.Response, tags nostr.Tags) {
publishedResponse = response
}
NewTestNip47Controller(svc).
HandleGetInfoEvent(ctx, nip47Request, dbRequestEvent.ID, app, publishResponse)
assert.Nil(t, publishedResponse.Error)
nodeInfo := publishedResponse.Result.(*getInfoResponse)
assert.Equal(t, tests.MockNodeInfo.Alias, *nodeInfo.Alias)
assert.Equal(t, tests.MockNodeInfo.Color, *nodeInfo.Color)
assert.Equal(t, tests.MockNodeInfo.Pubkey, *nodeInfo.Pubkey)
assert.Equal(t, tests.MockNodeInfo.Network, *nodeInfo.Network)
assert.Equal(t, tests.MockNodeInfo.BlockHeight, *nodeInfo.BlockHeight)
assert.Equal(t, tests.MockNodeInfo.BlockHash, *nodeInfo.BlockHash)
assert.Contains(t, nodeInfo.Methods, "get_info")
assert.Equal(t, []string{"payment_received", "payment_sent"}, nodeInfo.Notifications)
}